marahin/letter-bot

Letter is a Discord bot for reserving respawns in Tibia.

letter-bot's Issues

Make BotPort part of Application services

In the past we did not do many Discord operations as part of an application logic. Features have been growing (DM notifications, DM summaries) and it's time to encapsulate Discord operations as part of Application services, instead of passing Bot instance to some of the hooks handled by the event handler.

Add 🟢 🔴 indicators to reservations

It would benefit users if we could indicate whether they're online or offline. 🟢 🔴

Better error handling for 50007 (user blocked DM)

Users who have DMs blocked may receive DC error code 50007 (couldn't send DM to a user).

Per user report:

could not send letter message: HTTP 403 Forbidden, {"message": "Cannot send messages to this user", "code": 50007}

We should instead notify the user the action failed, and provide some basic instructions (unblocking DMs, unblocking the bot).

Conflicting reservations should be 'shortened' instead of removed

Imagine the following scenario:

• reservation exists for 19:00-22:00
• a new reservation request came, for 21:30-23:30 with overbook set to true

Current behavior

The conflicting reservation (1st) is removed entirely, and a new reservation from 21:30 to 23:30 is created.

Expected behavior

The conflicting reservation (1st) is shortened to 19:00 - 21:29, and the 2nd one is created 21:30-23:30

Send notification when mentioning user

Reduced reservations don't seem to apply when there's non-multilevel zone

R1 Bashmuu 21 : 01 - 22 : 44
R2 Prison -1 16 : 00-17 : 00
R3 Prison -2 16 : 00-17 : 00

overbooking only after after 10 min

Hello, please change "overbook". It should be possible to overbook only if there is more than 10mins after begin of reservation. Example: I booked a spot 10:00-12:00, and it should be possible to overbook only after 10:10.

Add Discord infrastructure tests using mock

https://github.com/mavolin/dismock

Sanitize hours input during Booking

We could sanitize those inputs, so that:

• "19.05" becomes "19:05" (sub "." to ":")
• "24:00" is translated to "00:00" before proceeding with BookRequest

Unability to reserve a spot even when it's empty

Things to consider:

• this has only encountered for hours with "0" preceding (08:30, 09:00)
• this was only encountered on a respawn with a zone descriptor (Werelions -2)

Cannot make a reservation even though there are minutes available