marcgreenstock/data-api-suite

Monorepo that includes libraries, Serverless Framework plugins and development tools to simplify and enhance the development, deployment and use of the Data API for Aurora Serverless.

data-api-suite's Issues

Deletes do not return record count in data-api-local

Deletes, as updates, should return a count of the records updated.

data-api-local: totally unusable, because of an old pg version

See brianc/node-postgres#2338
Local connection will hang indefinitely on any nodejs >= 14.0

Data API local fails if a table has a dropped column

The query to pull schema information from Postgres fails if a table has a dropped column:

2020-12-03 11:06:06.539 EST [20366] ERROR:  column "........pg.dropped.2........" of relation "xyz" does not exist
2020-12-03 11:06:06.539 EST [20366] STATEMENT:
                SELECT
                  c.oid AS "tableID",
                  a.attnum AS "columnID",
                  c.relname AS "tableName",
                  CASE a.attnotnull
                    WHEN true THEN 0
                    WHEN false then 1
                  END AS "nullable",
                  CASE
                    WHEN pg_get_serial_sequence(n.nspname||'.'||c.relname, a.attname) IS NULL
                    THEN false
                    ELSE true
                  END AS "isAutoIncrement"
                  FROM pg_class c
                  JOIN pg_namespace n ON n.oid = c.relnamespace
                  JOIN pg_attribute a ON attrelid = c.oid
                  WHERE c.oid = ANY($1::oid[])
                  ORDER BY a.attnum ASC

Bug in FormatISO9075

There is a bug in formatISO9075 in retrieving the date. It retrieves the day of the week instead. See this fix:

export const formatISO9075 = (date: Date): string => {
    const y = date.getUTCFullYear().toString()
    const m = (date.getUTCMonth() + 1).toString().padStart(2, '0')
    const d = date.getUTCDate().toString().padStart(2, '0')
    const h = date.getUTCHours().toString().padStart(2, '0')
    const min = date.getUTCMinutes().toString().padStart(2, '0')
    const sec = date.getUTCSeconds().toString().padStart(2, '0')
    const ms = date.getUTCMilliseconds().toString()
    return `${y}-${m}-${d} ${h}:${min}:${sec}.${ms}`
}```

Dates are misformatted in data-api-local

Dates get returned to the client as {"stringValue": "\"2021-01-01T05:00:00.000Z\""}.

Migrations table name

Hi! First of all, thanks for sharing this suite of tools.

Would you be open to allowing the table name used for storing migrations to be customised? This would be useful if you're using Postgres schemas, so that __migrations__ becomes schema1.__migrations__, for example.

Also, when do you typically run migrations? Do you have any experience with automatically running migrations after the function is deployed?

Thanks again!