marcogorelli/pylint-reenable

Remove unnecessary `# pylint: disable` comments

pylint-reenable

A tool (and pre-commit hook) to automatically remove unnecessary # pylint: disable comments, for example: a check that's no longer applicable (say you increased your max line length), a mistake (# pylint: disable added to a line that wasn't failing), or other code in the file caused it to no longer need a # pylint: disable (such as an unused import).

NOTE: this is lifted from yesqa, whose license is included here (as per its terms).

Installation

pip install pylint-reenable

Command-line example

$ pylint-reenable my_file.py

As a pre-commit hook

See pre-commit for instructions

Sample .pre-commit-config.yaml:

-   repo: https://github.com/MarcoGorelli/pylint-reenable
    rev: v0.1.4
    hooks:
    -   id: pylint-reenable

If you need to select a specific version of pylint and/or run with specific pylint plugins, add them to additional_dependencies.

pylint-reenable's Issues

` while True: # pylint: disable=while_used` is a valid disable

while-used is also valid, but when re-enabled, it leaves _used behind

`bad-plugin-value` should be propagated to the user

pylint-reenable/README.md

Lines 41 to 44 in 770a2ce

	If you need to select a specific version of pylint and/or run with specific
	pylint plugins, add them to [`additional_dependencies`][0].
	[0]: http://pre-commit.com/#pre-commit-configyaml---hooks

makes sense, but pylint-reenable could propagate bad-plugin-value errors to help the user

Having a comment after `# pylint=disable:...` makes the python file un-executable

    except Exception:  # pylint: disable=broad-except; avoid throwing

becomes

    except Exception:  ; avoid throwing

Which seriously affects the parse-ability of the file