margierain/eventmanager

Plan your event right

eventmanager's Issues

if you had a token service, maybe this would be there

eventManager/app/middleware/index.js

Line 37 in f561c24

return jwt.verify(token, config.secret, function (err, decoded) {

Am curious about this,

eventManager/app/controllers/events.js

Line 116 in f561c24

function eventUpdateEmail(event) {

If i wanted to update my name, will there be an update name controller function

Better to separate biz logic and data access code

eventManager/app/controllers/users.js

Line 1 in f561c24

const Validator = require('validator');

This looks like it should be in your business logic layer

eventManager/app/routes/roles.js

Line 9 in f561c24

Role.all((err, roles) => {

How about using exceptions where errors occur

eventManager/app/controllers/events.js

Line 178 in f561c24

function deleteEvent(req, res) {

Example

[Event Controller]
function deleteEvent(req, res) {
DeleteService.delete(some-event-id);
return res.status(200) .. with some message
}

[Delete Service]

function Delete(id) {
const result = EventRepository.delete(id)
If(result === some failure)
throw SOMEEXCEPTION;
}

[SOMEEXCEPTION]
This basically handles the exception and decides what one can send back to the user depending on whether your on prod qa dev or test
We can talk about this

File does many things

eventManager/app/utils/index.js

Line 13 in f561c24

function resolveError(err, res, status) {

Besides doing many things:

1. Javascript already has an error / exception class, how could you use it (Custom errors). In addition if you were following a standard for api responses, it already defines a standard so you dont really need to think about how to structure the api
2. Think the filtering can fall under a search service maybe

Dont you think that jwt generation should be its own service

eventManager/app/models/users.js

Line 78 in f561c24

userSchema.methods.generateJwt = function () {

In the spirit of SRP, maybe it should be on its own service.

Are there any modules that can help you achieve versioning the api

eventManager/app/routes/events.js

Line 9 in f561c24

app.post('/api/v.1/events', (req, res, next) => customMiddleware

Is the only validation a required one ?

eventManager/app/middleware/index.js

Line 9 in f561c24

const requiredFields = options.requiredFields;

What about the structure of an email, telephone number etc.

Looks like you dont use this

eventManager/app/routes/roles.js

Line 1 in f561c24

const rolesController = require('../controllers').rolesController;

Ugly

eventManager/app/controllers/events.js

Line 94 in f561c24

if (req.body.phoneNo) event.phoneNo = req.body.phoneNo;

Feels more like a service than a coontroller

eventManager/app/controllers/sendEmail.js

Line 1 in f561c24

const sgMail = require('@sendgrid/mail');

Is this used

eventManager/app/controllers/roles.js

Line 3 in f561c24

function list(req, res) {

This secret isnt very secret

eventManager/config/dev.json

Line 4 in f561c24

"secret": "iloveeventmanagement"

Maybe it should be an environment variable or something else