Giter Site home page Giter Site logo

Comments (8)

MikeDMorgan avatar MikeDMorgan commented on August 10, 2024 1

Hi @mdeea we have introduced an alternative to computing the nhood distance matrix, which has superior scaling performance. Could you re-run the makeNhoods with refinement_scheme="graph" - this dispenses with the need to run calcNhoodDistances - you will also need to adjust testNhoods with fdr.weighting="graph-overlap".

I'll flag this deprecated syntax in the next Bioc release (April).

from milor.

MikeDMorgan avatar MikeDMorgan commented on August 10, 2024 1

Hi @mihem - you can also access these updates by installing from the devel branch devtools::github_install("MarioniLab/miloR", ref="devel").

from milor.

mdeea avatar mdeea commented on August 10, 2024

Thanks, I did manage to get the tute running using a singularity instance of R built on Bioconductor 3.16, R 4.2 prior to the Matrix package update to 1.5.
However your workaround worked also and was much easier to use. Thanks!

from milor.

mihem avatar mihem commented on August 10, 2024

This is very helpful, but should be mentioned in the vignette IMO, because right now the vignette leads to an error because of this Matrix issue.

from milor.

MikeDMorgan avatar MikeDMorgan commented on August 10, 2024

Hi @mihem This seems to be heavily dependent on the R version - updating to R4.3 indicates this is not an issue - can you confirm which R and package versions you are using?

from milor.

mihem avatar mihem commented on August 10, 2024

Thanks for the swift reponse. I work on Ubuntu LTS and still work with R 4.2.1, and use miloR 1.7.1 (master branch from github).

from milor.

MikeDMorgan avatar MikeDMorgan commented on August 10, 2024

Hi @mihem the recommended installation pathway is through Bioconductor. I'd recommend to upgrade to R4.3 and Bioc 3.17 to get the updates.

from milor.

mihem avatar mihem commented on August 10, 2024

Hi Mike, well Bioconductor R 4.3 and Bioc 3.17 are pretty new (End of April), so for projects that have been started a few weeks or months ago and are under renv control, I would prefer to keep these older version.

But thanks for fixing, I will update soon for future projects and report if I still experience this issue.

from milor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.