method does not use '.' to separate service and method

[markaren]

method does not use '.' to separate service and method

[markaren]

Yeah, you are right. This is a yaj-rpc thing, which allows you to have several services per end-point.

[markaren]

I could of course relax the requirement. For instance if only one service is defined. The '.' could be omitted.

[markaren]

The following backwards compatible change allows you to omit the '.' when only one service has been defined:

private fun handle(req: RpcRequest): String? {
        val id = req.id
        val service: RpcService
        val methodName: String

        val split = req.methodName!!.split("\\.".toRegex()).dropLastWhile { it.isEmpty() }
        if (split.size == 2) {
            val serviceName = split[0]
            if (!services.containsKey(serviceName)) {
                val msg = "No such registered service '$serviceName'"
                LOG.warn(msg)
                return createErrorResponse(id, RpcError.ErrorType.METHOD_NOT_FOUND, msg)
            }
            service = services[serviceName]!!
            methodName = split[1]
        } else if (services.size == 1) {
            service = services.values.toList()[0]
            methodName = req.methodName!!
        } else {
            val msg = "Multiple services defined and method does not use '.' to separate service and method!"
            LOG.warn(msg)
            return createErrorResponse(id, RpcError.ErrorType.INVALID_REQUEST, msg)
        }

       ...
    }

Will push the change upstream

[markaren]

@ligi I will release a version 0.10.1 of the library with the above changes included soon.

[ligi]

thanks! will try it out and consume it via jitpack in the meantime. What would be super awesome to squeeze into the 0.10.1 release: a way to change the context - currently I need to do:

class MyRPCServer(handler: RpcHandler) : RpcHttpServer(handler) {
    override val context: String
        get() = "/"
}

It would be great if there could be a direct way to change this.

[markaren]

Like this:

open class RpcHttpServer @JvmOverloads constructor(
        val handler: RpcHandler,
        override val context: String = "/jsonrpc"
) 

?

[ligi]

yes - LGTM

[ligi]

FIY: just tried out the patch for the opened issue via jitpack and it works for me - thanks for the really fast fix!