markaren/yaj-rpc

Yet Another JSON RPC (YAJ-RPC) is a JSON RPC 2.0 implementation for JVM languages, written in Kotlin

yaj-rpc's Issues

Upload artifacts to bintray

typo

opening this as an issue as I cannot edit the wiki

https://github.com/markaren/YAJ-RPC/wiki/HTTP

implmented -> implemented
bundles -> bundled

Type wrapped as string

I am having the following RPC method:

@RpcMethod
    fun account_list(): List<String> {
        println("accounts")
        return listOf("0xafb2f771f58513609765698f65d3f2f0224a956f")
    }

I would expect it to return:

{"jsonrpc":"2.0","id":43,"result":["0xafb2f771f58513609765698f65d3f2f0224a956f"]}

but it returns:

{"jsonrpc":"2.0","result":"[\"0xafb2f771f58513609765698f65d3f2f0224a956f\"]","id":43.0}

type of ID is changed

in this example the ID is changed from a int to a floating point value

⋊> ~ curl --data '{"jsonrpc":"2.0","id":43,"method":"account_list","params":[]}' -H 'content-type:application/json' http://127.0.0.1:5000/                                                          17:19:35
{"jsonrpc":"2.0","result":"[{\"address\":\"afb2f771f58513609765698f65d3f2f0224a956f\",\"type\":\"account\",\"url\":\"keystore://foo\"}]","id":43.0}

method does not use '.' to separate service and method

I am currently running into:

method does not use '.' to separate service and method

caused by

val split = req.methodName!!.split("\\.".toRegex()).dropLastWhile { it.isEmpty() }.toTypedArray()
if (split.size != 2) {
    val msg = "method does not use '.' to separate service and method"
     LOG.warn(msg)
     return createErrorResponse(id, RpcError.ErrorType.INVALID_REQUEST, msg)
}

I do not find anything in the json-rpc spec: https://www.jsonrpc.org/specification that states a method name must contain a dot.