markrofail/bus-booking-system

Backend API using Django for a Bus Booking System.

Hello! 👋

I'm Mark Rofail (markrofail)   
Software Development Engineer @Amazon   

About me

Languages

Frameworks

Testing

bus-booking-system's Issues

do not return error messages as such from `services`

Description

This could expose how the API works. The API needs to appear as a blackbox.

Possible Fix

Handle the error messages and return a custom message from the topmost layer (services)

enhance query performance for `get_seats_reserved`

Description

the current implementation has a WHERE clause of 6 terms

Possible Fix

reduce the WHERE clauses. I think negation would work fine here.

write Unit Tests to ensure refactoring does not break the code

Detailed Description

need to add end-to-end test cases
need to add unit tests

create Trip.availableSeat() to remove model logic from controller

Detailed Description

The reservation.py serves as the core for the project and that is not correct. Some methods should be delegated to other files.

Possible Implementation

move some of the logic for POST /reservation to its corresponding model

a Customer needs to know which seat he reserved

Detailed Description

currently, the customer has no idea which seat he was assigned to when he makes a reservation

Possible Implementation

create a new BusSeat object and link it to a reservation

allow `GET /trips` to take fewer parameters

Description

currently, the GET /trips takes date_from, date_to, departure_station, arrival_station. It should deliver output even without the dates or station parameters.

Possible Fix

implement default parameters if none is found