Giter Site home page Giter Site logo

Comments (7)

Beakerboy avatar Beakerboy commented on May 12, 2024

The function is defined for a real numbers, but this algorithm only works for integer multiples of .5.

Implementing regularized incomplete beta for the rest will require a continuous fraction. I'll do it today.

from math-php.

Beakerboy avatar Beakerboy commented on May 12, 2024

This is also in the pending pull request.

from math-php.

markrogoyski avatar markrogoyski commented on May 12, 2024

Thanks for updating the function.

I added many unit tests and it looks good for most calculations. However, I found a case where the calculations don't match the online calculator I was using to create the unit test data.
When $a is a half integer (#.5) and $b is an integer, the result doesn't seem to match the online calculators.
For example:
$x = 0.55, $a = 2.5, $b = 2
This online calculator gives this result: 0.47672251 (http://www.analyticscalculators.com/calculator.aspx?id=37)

However, our function gives this result: 0.35452425122782244

Can you check this case?
Thanks.

from math-php.

Beakerboy avatar Beakerboy commented on May 12, 2024

Will do. I was using the Mathworld Site for checking values.

from math-php.

Beakerboy avatar Beakerboy commented on May 12, 2024

Those recursive functions in the top 'exact' part of the method are likely extensions of the translation functions in the bottom. I bet if I pull out my algebra skill, I can double check the for loop to make sure it's correct.

from math-php.

Beakerboy avatar Beakerboy commented on May 12, 2024

I added a pull request to fix this.

from math-php.

markrogoyski avatar markrogoyski commented on May 12, 2024

Merged pull request and added new unit tests. All tests pass.

from math-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.