marlass/code-review-example

Example repo to demonstrate code review process

code-review-example's Issues

Missing cart e2e test for automatic cart load

To make sure cart refactor didn't break anything regarding cart existing cart tests needs to be inspected and if needed to be expanded to cover more use cases.

Active cart behavior:

• user logs in without cart -> attempt to load current cart
• users logs in with cart saved in a browser -> attempt to load 'saved' cart
• anonymous cart is stored in browser
• anonymous user have cart and logs in -> merge anonymous cart with current
• anonymous users want to add the product to the cart (cart doesn't exist) -> create new cart, then add
• logged user want to add the product to the cart (cart not loaded in spa, but exists) -> load current and add entry
• logged user want to add the product to the cart (cart not loaded in spa, doesn't exists) -> try to load, then fallback to create and then add entry
• current cart should be loaded when previous cart throws Cart not found
• user adds entry (cart created) -> no new cart created
• user removes entry -> entry removed
• user updates quantity to 2 -> entry updated
• adding an incorrect product to the cart shouldn't invoke added to cart modal

Mobile E2E test doesn't need to be updated. Most of the test focus on API communication. UI is already well tested.

What to look for:

• loading status correctly persist through cart updates/creating/loading
• no errors with cart (eg. cart not found)

New behavior found in some tickets into consideration:

• remove cart when we remove last entry (I am not sure if this is really needed)