Giter Site home page Giter Site logo

Comments (4)

fzaninotto avatar fzaninotto commented on June 9, 2024

Hi, and thanks for your suggestion.

You can already override the success side effects with the mutationOptions.onSuccess prop, as in the screenshot you pasted in the "Additional context" section. This is also the way to customize the notification text in the Edit view (see https://marmelab.com/react-admin/Create.html#changing-the-notification-message). If this option doesn't work, please elaborate on the reproduction.

We won't offer an additional prop to do something you can already do with mutationOptions.

from react-admin.

ethembynkr avatar ethembynkr commented on June 9, 2024

Hi, thank you for your answer.

I can customise the notification text with mutationOptions in DeleteWithConfirmButton component, but in this case the confirm dialog does not close.

I made a demo that shows this case. Please select and delete a record on the post page or delete a record on the edit page. You will see that the Confirm dialogue does not close.

You can access the demo here

image

from react-admin.

fzaninotto avatar fzaninotto commented on June 9, 2024

Understood, thanks for the reproduction.

You're right: there is no easy way to do what you ask without rewriting significant parts of the controller. So we need to expose an option to let users override the message (something like successNotification) in useDeleteWithConfirmController and the associated buttons.

I'm marking this as an enhancement. We'll welcome a PR implementing this feature.

from react-admin.

ethembynkr avatar ethembynkr commented on June 9, 2024

@fzaninotto I opened a PR for this feature. Can you review it?

#9868

from react-admin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.