martijnhols/actions-cache

Enhanced actions/cache: Get full control over caching

Hoi, ik ben Martijn. 👋 🇳🇱

Learn more about me and my work on my website: https://martijnhols.nl/ (Dutch) or my blog: https://martijnhols.nl/gists (English)

actions-cache's Issues

Restore does not find cache key even though it seems to exist

Given the following yaml:

      - name: Check if cache key exists
        uses: martijnhols/actions-cache/[email protected]
        id: cache_exists
        with:
          path: .venv
          key: ${{ runner.os }}-python-deps-${{ hashFiles('poetry.lock') }}

      - name: Set up Python
        uses: actions/setup-python@v4
        if: steps.cache_exists.outputs.cache-hit != 'true'
        with:
          python-version: ${{ env.PYTHON_VERSION }}

      - name: Restore dependency cache
        uses: actions/cache@v3
        if: steps.cache_exists.outputs.cache-hit != 'true'
        id: deps-cache
        with:
          path: .venv
          key: ${{ runner.os }}-python-deps-${{ hashFiles('poetry.lock') }}

I get this output:

Comparing the keys, they look identical (copy pasted manually from output):

• Linux-python-deps-905d6047b1ef7816097d7c2ed5d59e9334470b45f129b2df87b40a4f33058e2a
• Linux-python-deps-905d6047b1ef7816097d7c2ed5d59e9334470b45f129b2df87b40a4f33058e2a

With 3.0.3 cache stopped working

Upgrade to Node.js 16

I'm getting this warning in all of my pipelines.
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: martijnhols/actions-cache

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Posting it here for awareness.

5GB size limit

Hello, first of all thank you for the alternative actions-cache. I use it to control when to restore and save cache.

Recently I started hitting 5GB limit when uploading cache. However Github has increased cache size limit to 10GB. https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#usage-limits-and-eviction-policy

If cache is not hist in restore, there is not cache-hit output

Hi !

Looking at the code, it seems that the branch managing the cache not hit in restore.ts doesn't set output before returning:

         if (!cacheKey) {
            const message = `Cache not found for input keys: ${[
                primaryKey,
                ...restoreKeys
            ].join(", ")}`;
            if (isCacheRequired()) {
                throw new Error(message);
            } else {
                core.info(message);
                // I expected to have an utils.setCacheHitOutput(false); here
                return false;
            }
        }

I may be missing something here, If right I can write you the PR.

Thanks !