Language prefix not used in CMS split view

[martimiz]

Language prefix not used in CMS split view

[Martimiz]

Thanks, that's obviously a bug. I'm working on a solution.

[Martimiz]

I've uploaded a testbranch 'previewtest', that fixes this issue and more. These are rather big changes, so it needs some extra testing. The hardest part is to work around basic SilverStripe and Translatable behaviour, mostly in static functions, that cannot deal with language prefixes. :(

Please check out the 'previewtest' branch and let me know of any issues you might find! Thanks.

Martine

[806software]

Thanks for the quick fix. Will be trying it out tomorrow.

[806software]

Hi Martine,

I've updated to the previewtest branch, but the issue still exists. I've flushed and run /dev/build also. I must have missed something.

[Martimiz]

OK: this is what I did to test a clean install (just now):

• downloaded silverstripe 3.1 installer
• did composer update (see composer.json below)
• downloaded, unpacked (and renamed) silverstripe-languageprefix-previewtest.zip
• performed the installation
• went to domain/admin
• opened split view <---- Works!

I'm not sure why your version would fail... Can you please confirm you're actually using the new branch (removing the old one)?

composer.json:

{
    "name": "silverstripe/installer",
    "description": "The SilverStripe Framework Installer",
    "require": {
        "silverstripe/cms": "3.1.*@dev",
        "silverstripe/framework": "3.1.*@dev",
        "silverstripe-themes/simple": "*",
        "silverstripe/translatable": "dev-master"
    },
    "require-dev": {
        "silverstripe/docsviewer": "*",
        "silverstripe/behat-extension": "*",
        "silverstripe/buildtools": "*",
        "phpunit/phpunit": "3.7.*"
    },
    "config": {
        "process-timeout": 600  
    },
    "minimum-stability": "dev"
}

[806software]

ok, I'll give it another go. Yes, using the new branch. Will report back.

[806software]

Ok, still not working for me - going to start fresh as there must be something I've done somewhere that is causing an issue.

[806software]

Right, definitely something I have done. Done a fresh setup as advised, and I can confirm the language prefix works in the CMS split view. Now I just need to figure out what I have done in my project.

Thanks for your help, very much appreciated.

Jason.

[Martimiz]

Please let me know of any other issues you might come across, I want to be really sure everything's fine now before I merge this into master.

Thanks, Martine

[806software]

Right, a bit more testing, and it seems if I add entries into locale_prefix_map (_config/languageprefix.yml), that seems to present the issue, e.g.

prefixconfig:
  locale_prefix_map:
    'en_GB' : 'en'
    'en_US' : 'us'
    'fr_FR' : 'fr'
    'de_DE' : 'de'

But removing those (in the fresh install), re-instates the desired behaviour.

I'm just working through the fresh install (that works), applying configuration from my current project, to try and work out what I've done to persist the issue in my project.

[Martimiz]

Would you try the updated previewtest version and see if this now works for you?

Martine

[806software]

Will do as soon as possible. Thanks for the quick responses, I'm sure you are busy on other things.

[806software]

sorry, pressed the wrong button. Update to follow

[806software]

Hi Martine,

The latest update sorts the issue of using the locale_prefix_map. Thanks for your help! Now I just need to pinpoint the setup in my project that causes the problem.

Jason

[806software]

Found the problem in my project (facepalm). The version of 3.1 that I have in my active project, in the SiteTree method RelativeLink, the following doesn't exist:

$this->extend('updateRelativeLink', $base, $action);

The perils of using Beta...

Now going to spend the morning making updating the base system much easier that I have it (not really using Composer, for example)

[Martimiz]

While we're at it: I'm having problems with Translatable and deleting draft pages from a translated language (not the default language) - often but not always :( Seems like most times on updateTreeNodes the 'ids=' param is empty in the URL (using FireBug). I first thought this to be an issue with LanguagePrefix, but without it the issue persists.

Can you by any chance confirm this?

[806software]

Yes, I can confirm the same behaviour.

[Martimiz]

Tested this on a clean install with newest 3.1 and translatable-master: problem persists, so it's definitely not a LanguagePrefix issue.

[806software]

Yes, I had just updated my project to latest 3.1 framework and cms, also with translatable master before I tested the delete issue.