URLSegment same on various languages -> another solution?

[martimiz]

URLSegment same on various languages -> another solution?

[Martimiz]

Wow, that one caught me by surprise - how come I never even looked for that? :( I just happily went along with the earlier suggestion... Looks like it's working nicely though, I can't really think of anything that would break that wouldn't break in the other solution...

I couldn't find a similar option to force the duplicate URLSegment right on creation of a new translation though. Is there something else I've missed?

Martine

Martine

[hubertusanton]

Hi Martine,

That's indeed something which doesnt work i see (when creating a translation)

Bart

[Martimiz]

I could hackishly fix this in an onBeforeWrite() but I feel this should really be a Translatable issue/enhancement...

[Martimiz]

I've changed the previewtest branch to use your solution, The LanguagePrefixTranslatable class is no longer necessary, so it is removed.

I've added a (temporary) LanguagePrefix::onBeforeWrite() to keep the original URLSegment intact if duplicate URLSegments are allowed and created a request to the Translatable module to allow for this feature.

Please could you test the 'previewtest' branch, before I merge it into master?

[Martimiz]

No further comments, so I'm going to merge this into master