martinkersner/non-maximum-suppression-cpp

non-maximum-suppression-cpp's Issues

Subtraction functions with odd "+ 1" at the end

Hi Martin,

The nms function only returned one bounding box for me every time.

This was fixed for me by editing line 85 from:
auto tmpArea = (x2[idx] - x1[idx] + 1) * (y2[idx] - y1[idx] + 1);
to:
auto tmpArea = (x2[idx] - x1[idx]) * (y2[idx] - y1[idx]);

and line 157 from:
result.push_back(vec1[idx] - vec2[idx] + 1);
to:
result.push_back(vec1[idx] - vec2[idx]);

I am not sure if there is a reason behind adding the +1 after every subtraction, but after removing it I got great results from the nms() function.

License

Which license is that code?

Pass vectors by reference

All the vectors are copied on the stack in each function call, use & to pass them by reference.

Vector iterator out of bounds

Hi,
I compile and run example.cpp.
But, Error occurred.
The message is :
Debug Assertion Failed!
Program .... *.exe File C:\Program file...msvc\14.16.27023\include\vector Line 122
Expression: cannot seek vector iterator after end ....

Line number 206 at nms.cpp
resultVec.erase(esultVec.begin() + idx + offset);

Please let me know why error occurred.
Thanks..

I use VS 2017 + windows 10 64bit.