martinmicunda/employee-scheduling-ui

An UI component for Employee Scheduling application.

employee-scheduling-ui's Issues

Add ng-maxlength for each input field.

Minification code doesn't work in production bundle

This is because we are using ES6 for controller with 1.3 Angular. NG-ANNOTATE already start some work to cover ES6 however is experimental at this stage. Also look at new Angular 2 DI.

Missing step to run application

I think jspm install is needed to run the app. Cool project man.

Add unique error message

Currently the application only handle 409 conflict error but if there is unique resource error how this should be handle?

[
 { 
   field: "zip"
   message: "must be at least 2 characters and at most 30 characters"
 }
]

Image upload to S3

Add option to upload profile images to s3:

http://stackoverflow.com/questions/22941535/mean-stack-file-uploads
http://stackoverflow.com/questions/24026320/node-js-image-resizing-without-imagemagick?rq=1
http://eyalarubas.com/image-processing-nodejs.html
https://github.com/EyalAr/lwip

require.extensions.hasOwnProperty is not a function

if (!require.extensions.hasOwnProperty(ext)) {
                       ^
TypeError: require.extensions.hasOwnProperty is not a function

Got this issue after running npm start
Any idea ?

npm build failed

Hi, I checkouted the app, ran npm install, it failed as following. My environment is Mac yosemite, node: v4.2.1, npm: v2.14.7

\
> [email protected] postinstall /Users/ypwu1/dev/github/employee-scheduling-ui
> jspm install

module.js:339
    throw err;
    ^

Error: Cannot find module 'core-js/es6/string'
    at Function.Module._resolveFilename (module.js:337:15)
    at Function.Module._load (module.js:287:25)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/Users/ypwu1/dev/github/employee-scheduling-ui/node_modules/jspm/cli.js:16:2)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)

scheduling and availability

Hi!

Anyone can please tell me if scheduling and availability is availeble in this repo?
As I can see demo shows "comming soon " info is it working properly after instalation?

A.

Error when running 'npm start'

Fix asset header version when CI is creating production bundle

Currently the asset header is always set to v.0.0.0 and it should add commit version(v.0.0.0-commit ) for staging env and normal proper version for production env v.1.0.0

Add SystemJS conditional imports

Add SystemJS conditional imports to load different files for different environments.

[Question] Typescript vs Babel

To begin with, I would like to thank you for this project. It is a great inspiration and very impressive. Chapeau!

I would like to know why you prefer Babel over TypeScript, considering the fact Angular2 is written in TypeScript?

Replace angular $q promises with ES6 promises in all application

Usage of WeakMap to manage instance variables

Hi,

cool project. I'm just migrating over from a more old-fashioned RequireJS structured Angular project to using gulp, ES6, SystemJS and JSPM. Regarding your usage of WeakMap.

class MmReallyClick {
    constructor($modal) {
        ...
        MODAL.set(this, $modal);
    }
    ...
}

Saw that in another project as well and was wondering whether this is really necessary as it seems overcomplicated. Wouldn't it be enough to simply assign $modal to this?

Thx for your answer 😄

npm install fails due to incorrect url in npm-shrinkwrap.json

When I npm install, I get those errors :

npm ERR! fetch failed http://npm-registry.snc1/package/jspm-0.16.0-beta.tgz
npm WARN retry will retry, error on last attempt: Error: getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! fetch failed http://npm-registry.snc1/package/systemjs-builder-0.11.3.tgz
npm WARN retry will retry, error on last attempt: Error: getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! fetch failed http://npm-registry.snc1/package/karma-coveralls-1.1.0.tgz
npm WARN retry will retry, error on last attempt: Error: getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! fetch failed http://npm-registry.snc1/package/systemjs-builder-0.11.3.tgz
npm WARN retry will retry, error on last attempt: Error: getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! fetch failed http://npm-registry.snc1/package/karma-coveralls-1.1.0.tgz
npm WARN retry will retry, error on last attempt: Error: getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! fetch failed http://npm-registry.snc1/package/jspm-0.16.0-beta.tgz
npm WARN retry will retry, error on last attempt: Error: getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! fetch failed http://npm-registry.snc1/package/karma-coveralls-1.1.0.tgz
npm ERR! fetch failed http://npm-registry.snc1/package/jspm-0.16.0-beta.tgz
npm ERR! fetch failed http://npm-registry.snc1/package/systemjs-builder-0.11.3.tgz
npm ERR! Darwin 14.3.0
npm ERR! argv "/Users/Tophe/.nvm/versions/node/v0.12.0/bin/node" "/Users/Tophe/.nvm/versions/node/v0.12.0/bin/npm" "install"
npm ERR! node v0.12.0
npm ERR! npm  v2.5.1
npm ERR! code ENOTFOUND
npm ERR! errno ENOTFOUND
npm ERR! syscall getaddrinfo

npm ERR! network getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! network This is most likely not a problem with npm itself
npm ERR! network and is related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/Tophe/projects/front/employee-scheduling-ui-original/npm-debug.log

• I'm not behind any proxy
• I tried npm cache clean

The npm install didn't work. It's weird, it's trying to retrieve tarballs from a domain npm-registry.snc1.

I found out that your npm-shrinkwrap.json was pointing to this specific remote repo. I followed this workaround :

rm npm-shrinkwrap.json
npm install

It worked out great. Maybe you should review your local npm remote repositories config before generating and commiting the npm-shrinkwrap.json file ?

npm version : 2.5.1
node version : 0.12.0

Your email contact on your site doesn't work...Tried contacting you...

Martin,

I wanted to chat with you about some work but could your contact form on your portfolio site doesn't work. Is there a way I can contact you?

Angular 2 migration

The follow ng-forward library has richer options of Angular 2 decorators then my own ng-decorators library so it seems to better option for migration plan to Angular 2.

Add drag and drop like JIRA for documents upload

error in dist

Hello I've tried to run
gulp serve:dist

but the application doesn't work because I receive this error in the browser console:
Uncaught System.register provided no module namen @ main.min-bbf224e4.js:10(anonymous function) @ main.min-bbf224e4.js:21(anonymous function) @ main.min-bbf224e4.js:10(anonymous function) @ main.min-bbf224e4.js:10

No error in the console it finish with:
[BS] Watching files...

Thank you.

Fix the CI build

Build Issue - Error: getaddrinfo ENOTFOUND npm-registry.snc1

I get the following errors on npm install:

npm ERR! fetch failed http://npm-registry.snc1/package/systemjs-builder-0.11.3.tgz
npm WARN retry will retry, error on last attempt: Error: getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! fetch failed http://npm-registry.snc1/package/karma-coveralls-1.1.0.tgz
npm WARN retry will retry, error on last attempt: Error: getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! fetch failed http://npm-registry.snc1/package/jspm-0.16.0-beta.tgz
npm WARN retry will retry, error on last attempt: Error: getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! fetch failed http://npm-registry.snc1/package/karma-coveralls-1.1.0.tgz
npm WARN retry will retry, error on last attempt: Error: getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! fetch failed http://npm-registry.snc1/package/systemjs-builder-0.11.3.tgz
npm WARN retry will retry, error on last attempt: Error: getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! fetch failed http://npm-registry.snc1/package/jspm-0.16.0-beta.tgz
npm WARN retry will retry, error on last attempt: Error: getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! fetch failed http://npm-registry.snc1/package/karma-coveralls-1.1.0.tgz
npm ERR! fetch failed http://npm-registry.snc1/package/systemjs-builder-0.11.3.tgz
npm ERR! fetch failed http://npm-registry.snc1/package/jspm-0.16.0-beta.tgz
npm ERR! Darwin 14.4.0
npm ERR! argv "node" "/usr/local/bin/npm" "install"
npm ERR! node v0.12.4
npm ERR! npm  v2.10.1
npm ERR! code ENOTFOUND
npm ERR! errno ENOTFOUND
npm ERR! syscall getaddrinfo

npm ERR! network getaddrinfo ENOTFOUND npm-registry.snc1
npm ERR! network This is most likely not a problem with npm itself
npm ERR! network and is related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/foo/bar/employee-scheduling-ui/npm-debug.log

Cannot run gulp without error

Running gulp returns with the following error:

Error: Cannot find module 'readable-stream/transform'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/Applications/MAMP/htdocs/Code/Github/josephdburdick/angular/employee-scheduling-ui/node_modules/gulp-flatten/node_modules/through2/through2.js:1:79)
    at Module._compile (module.js:456:26)
    at Module._extensions..js (module.js:474:10)
    at Object.require.extensions.(anonymous function) [as .js] (/Applications/MAMP/htdocs/Code/Github/josephdburdick/angular/employee-scheduling-ui/node_modules/babel/node_modules/babel-core/lib/api/register/node.js:214:7)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)

Issue with running tests

HI Martin,

I am facing file table overflow issue while running the karma tests, did you see this issue before?

http://stackoverflow.com/questions/35873437/enfile-file-table-overflow-with-karma

Thanks,
Abhi

Test fails

All the test fails.
Command:gulp test:unit

Result:
[09:52:45] Using gulpfile ~/Documents/employee-scheduling-ui/gulpfile.js
[09:52:45] Starting 'karma'...
INFO [karma]: Karma v0.12.31 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
WARN [watcher]: Pattern "/Users/danielezurico/Documents/employee-scheduling-ui/src/vendor/jquery/dist/jquery.js" does not match any file.
WARN [watcher]: Pattern "/Users/danielezurico/Documents/employee-scheduling-ui/src/vendor/angular/angular.js" does not match any file.
WARN [watcher]: Pattern "/Users/danielezurico/Documents/employee-scheduling-ui/src/vendor/angular-animate/angular-animate.js" does not match any file.
WARN [watcher]: Pattern "/Users/danielezurico/Documents/employee-scheduling-ui/src/vendor/bootstrap/dist/js/bootstrap.js" does not match any file.
WARN [watcher]: Pattern "/Users/danielezurico/Documents/employee-scheduling-ui/src/vendor/angular-bootstrap/ui-bootstrap-tpls.js" does not match any file.
WARN [watcher]: Pattern "/Users/danielezurico/Documents/employee-scheduling-ui/src/vendor/angular-ui-router/release/angular-ui-router.js" does not match any file.
WARN [watcher]: Pattern "/Users/danielezurico/Documents/employee-scheduling-ui/src/vendor/angular-mocks/angular-mocks.js" does not match any file.
WARN [watcher]: Pattern "/Users/danielezurico/Documents/employee-scheduling-ui/src/app/*/.spec.js" does not match any file.
ERROR [preprocessor.coverage]: Line 4: Unexpected reserved word
at /Users/danielezurico/Documents/employee-scheduling-ui/src/app/bootstrap.js
ERROR [karma]: [TypeError: Not a string or buffer]
TypeError: Not a string or buffer
at TypeError (native)
at Hash.update (crypto.js:119:16)
at sha1 (/Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma/lib/preprocessor.js:10:8)
at nextPreprocessor (/Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma/lib/preprocessor.js:55:20)
at /Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma-coverage/lib/preprocessor.js:63:7
at Object.Instrumenter.instrument (/Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma-coverage/node_modules/istanbul/lib/instrumenter.js:583:17)
at /Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma-coverage/lib/preprocessor.js:51:18
at nextPreprocessor (/Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma/lib/preprocessor.js:59:28)
at /Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma/lib/preprocessor.js:97:7
at fs.js:336:14
at /Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma/node_modules/graceful-fs/graceful-fs.js:104:5
at /Users/danielezurico/Documents/employee-scheduling-ui/node_modules/plato/node_modules/fs-extra/node_modules/rimraf/node_modules/graceful-fs/graceful-fs.js:90:5
at FSReqWrap.oncomplete (fs.js:99:15)

ERROR [preprocessor.coverage]: Line 1: Unexpected reserved word
at /Users/danielezurico/Documents/employee-scheduling-ui/src/app/components/employee/employee.js
ERROR [karma]: [TypeError: Not a string or buffer]
TypeError: Not a string or buffer
at TypeError (native)
at Hash.update (crypto.js:119:16)
at sha1 (/Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma/lib/preprocessor.js:10:8)
at nextPreprocessor (/Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma/lib/preprocessor.js:55:20)
at /Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma-coverage/lib/preprocessor.js:63:7
at Object.Instrumenter.instrument (/Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma-coverage/node_modules/istanbul/lib/instrumenter.js:583:17)
at /Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma-coverage/lib/preprocessor.js:51:18
at nextPreprocessor (/Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma/lib/preprocessor.js:59:28)
at /Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma/lib/preprocessor.js:97:7
at fs.js:336:14
at /Users/danielezurico/Documents/employee-scheduling-ui/node_modules/karma/node_modules/graceful-fs/graceful-fs.js:104:5
at /Users/danielezurico/Documents/employee-scheduling-ui/node_modules/plato/node_modules/fs-extra/node_modules/rimraf/node_modules/graceful-fs/graceful-fs.js:90:5
at FSReqWrap.oncomplete (fs.js:99:15)

ERROR [preprocessor.coverage]: Line 54: Unexpected reserved word
....

builder.buildSFX is error

I use "systemjs-builder": "^0.12.1".I got errors:
[14:37:19] 'bundle' errored after 11 s
[14:37:19] Error: Error: ENOENT, open 'e:\testall\test3\employee-scheduling-ui-master\src\app\main'
at e:\testall\test3\employee-scheduling-ui-master\gulpfile.js:332:24
at lib$rsvp$$internal$$tryCatch (e:\testall\test3\employee-scheduling-ui-master\node_modules\systemjs-builder\node_modules\rsvp\dist\rsvp.js:489:16)
at lib$rsvp$$internal$$invokeCallback (e:\testall\test3\employee-scheduling-ui-master\node_modules\systemjs-builder\node_modules\rsvp\dist\rsvp.js:501:17)
at lib$rsvp$$internal$$publish (e:\testall\test3\employee-scheduling-ui-master\node_modules\systemjs-builder\node_modules\rsvp\dist\rsvp.js:472:11)
at lib$rsvp$$internal$$publishRejection (e:\testall\test3\employee-scheduling-ui-master\node_modules\systemjs-builder\node_modules\rsvp\dist\rsvp.js:415:7)
at lib$rsvp$asap$$flush (e:\testall\test3\employee-scheduling-ui-master\node_modules\systemjs-builder\node_modules\rsvp\dist\rsvp.js:1290:9)
at process._tickCallback (node.js:355:11)

Angular 1 Component Style

Try follow component path from this article.

Add CI support to push coveralls reports only for branches and not pull request

Currently every CI build (even pull requests) is pushing coverage reports to coveralls. The CI should only push reports to coveralls for branches and not pull request. The proposal should be pass --coveralls flag to karma if we want to push reports to coveralls...

Codeclimate should only analyze app files and not test,mock etc files

Codeclimate is analysing all files which make result incorrect. The (*.spec|*.mock|*-mock|*.e2e|*.po).js should NOT be analyse by codeclimate.

NOTE: not sure if codeclimat support glob pattern

Images are not loaded properly in production bundle code with --cdn flag

It seems like gulp-cdnizer don't change img src path in html templates.