masterkoppa/mastermind

Mastermind SE362 Project

mastermind's Issues

AI Implementation

Right now all the ground work from the GUI perspective is setup for the AI to function correctly. We need to get the AI implemented. See 66c363e for more details on where it actually has to be implemented inside the view.

Input validation

I'm attempting to work on the input validation atm. I haven't been able to work on the crc cards.

Logger Throwing a null pointer exception

It seems like the logger is throwing a null pointer exception in line 106.

Please verify and push a fix for this issue, in the mean time I will disable it on my side so I can continue with it.

Document our solution

Change the MastermindMain to a JPanel

Refactor the MastermindMain class to make it a JPanel like all the other views in our GUI

Game Wond Dialog Shown Multiple Times

Multiple GUI Popups for game actions

At the point in the game when we tell the user the game is over, whether it's because they won, lost, or there was no winner, we're launching multiple popup windows. This isn't affecting game progress, just looks odd.

Cui

I should be able to chat if you guys need me. text me. I haven't worked on the cui quite yet, I have copied the one to be used into the repo. I will create a short explanation of how I think we can implement it either today or tomorrow. I will be starting work on it tonight or tomorrow as well.

Package Name?

We need to decide a package name for each of our classes, or do we want to use the default java package?

Binary Log4j Library in Repository

Should we have the binary log4j library inside the repo, or let everyone keep an individual copy?

Computer Codemaker still showing Secret Code Panel

Even when you select the computer code maker, the secret code panel is still being shown

Clicking "Submit" without specifying colors

The game board allows you to click "submit" even though the user hasn't specified colors yet. Eventually, this causes an exception as you can click submit as much as you want.

Problems With the Design

At the end of today's meeting we got stonewalled by how we were going to handle all the constructors and I think I have found a solution. Were looking at things the wrong way. The Board GUI(View) will have the Submit button. The controller for this view will be instantiated in the main. So the constructor for the View would be something like this:

View(Command submitCommand, Command switchPlayerCommand);

These commands are attached to the actions of switching the player and submitting the command. All the models and access to them is done inside the main where these commands are instaciated. For example:

Command submitCommand = new SubmitPlayCommand(List guesses, CodeMaker codeMakerReference);

and then this is passed to the view. This command will now have access to the models in the backend. Also every model/view association and registration happens in the main thread. So instead of having a singleton or static class we pass in references when we build everything before the program starts in the main.

What do you guys think?

Code Cleanup

Cleanup any un-used methods and variables, hopefully try and get the final jar to compile without any warning of any kind. Documentation for all methods would also be preferable as we move into the next release.

Fix intuitivity

Lutz couldn't figure out that you can choose different colors by repeatedly clicking peg boxes.

Feedback is delayed

Summary

Ok so I'm having a small situation on the GUI right now. If it turns out to be too much trouble a rewrite is not out of the question. I can get input on the program but for some reason the model is lagging behind in the feedback. It can be anything from a subtle bug to a concurrency problem but the point is that the feedback is one turn behind. For example:

• I place the first move
• I hit submit
• The play is submitted and I can see it being printed on the command line but the feedback is completely empty.
• I submit another move, and the feedback is updated with the correct feedback. The only problem is that this is a turn late.

Possible Solution

I think the first approach to fixing this would be running a battery of tests on ProvideFeedback and SubmitGuess Commands and how they interact with each other. Anyone familiar with them willing to take a look at them? Maybe its a problem with the way I call them or something. Any additional documentation with them would be great.

Documentation based on feedback

Ok so it seems like we got penalized in the grading by the lack of documentation in some of our classes. While I was going through them I noticed that we didn't have class descriptions in most of our classes. And some of the method names and arguments were not documented properly.

Whoever is willing to take this issue up please see the document sent by the professor with detailed criticisms to our code.

Input Validation, where?

Im going through the GUI now and the issue of input validation popped up. Where should the input be validated? With a command separately or should it be done in an anonymous action listener? Please provide some input for this issue.

Unit 1 Submission Problems

I spoke with the professor about a note inside of our implementation. The note said that the color selection in our program was not working.

This is sounding very familiar to the problem we had when I downloaded from dropbox for the presentation. The only difference is that when I try it, from the mycourses submission, it works. Can you guys individually test the submitted zip file and see if you encounter any problems?

Before I send a reply to the professor I want to get your approval for this email reply:

Original Thread

Hi Professor Lutz,

What do you mean by the comment inside the Implementation Rubric, "Can't select colors at start, only black"? From our experience the color functionality was present in our code and working by the time of submission.

Thanks in advance.

Regards,

Andres J Ruiz Torres
2nd Year Software Engineering
RIT

---

Didn’t work for me.

MJL

Proposed Reply

Well, that's strange. I just re-downloaded the zip file submitted and tried and it worked flawlessly. This was on my own machine, though I will test on a SE Machine later this weekend to confirm if it does work or not.

A quick note though, we encountered a strange problem similar to the one you mentioned before our presentation were if we downloaded the jar from a cloud filesharing website it would not work as expected, but if we downloaded the source code used to build that and built it at the machine it would work just fine.

My point is, is there anyone we can contact about this problem and figure out how to fix it. From my understanding this program should work regardless of what platform it was built from, in all the supported platforms. In this case it appears this is not happening here.

Additionally if during further investigation we find that this was a java related issue outside of our control is there a chance for reconsideration of those points?

Andres J Ruiz Torres
2nd Year Software Engineering
RIT

ColorPeg buttons not disabling after submit

When submitting a guess, the colorpeg indicators (multi-colored pegs that form the guess) should be disabled for a guess that has passed.

Send the logging command

The logging is currently not working, the code is layed out for the user to select a file name from a file selector. The result is stored in a string and just has to be sent through with the right commands to the model. Once this is working Ill make the check mark persistent through sessions for each game.

CELEBRATION

We can now celebrate and rest, the program has been submitted with all the required documentation. Take the weekend off and celebrate. We did great!

FINALLY DONE!!

Code Refactoring from criticism

Someone needs to take the task of going through the professors comments in our code and fixing any inconsistencies and problems that he found, only the minor tasks that he pointed out. Any major changes should be left to discussion with the team.