mastrup/ourhtageditor

H-tag property editor for Umbraco.

Hi there 👋

Since 2013, I have worked professionally with Umbraco and along the way have become an Umbraco certified master.

Connect with me:

Music

If I am currently coding, I am coding to this lovely tune
^{Or my kids has taken over the playlist and I am listening to something crazy 😭}

ourhtageditor's Issues

Update / optimize angular

The angular part is built by trial and error and should be optimized.

UAAS : $scope.control

Awesome plugin!
Maybe it is an Umbraco Deploy issue, i don't know.
It seems all the data stored inside $scope.control doesn't get deployed when using UAAS.
I think moving the tag and the alignment inside $scope.model.value should resolve this.

Feature Request: Class in Editor

Hi,
I found this when looking for a possbility to change classes for H1 etc. to be semantically correct, but have different sizes. Currently the class goes directly to the template, would be great to have that also editable somewhere in a settings file, so you can have a limited number of classes (via dropdown or similar).

If I can find the time, I´ll maybe give it a try.

Best,
Gerhard

Umbraco Cloud / Deploy

Hi Søren,
Really nice package.
Is there an compatible issue with Umbraco Cloud/Courier. I've found the text heading is being transferred from local to dev, but the tags and style values are not.
Thanks
Martin,

Add font icon in custom font file

Consider to add a custom font file instead of including entire font awesome library, e.g. by using https://icomoon.io/app/

And then consider to add a prefix, e.g. hte or something elso to avoid it conflict with other packages.
The class name will then be icon-hte-heading instead of icon-heading.

Accessibility enhancements of buttons and icons

There's a few things that could be done to enhance accessibility in the package.

• Add aria-hidden="true" to icons (or use <umb-icon> which handle this - this require Umbraco 8.8+ though).

• Use <button type="button"> elements for buttons, e.g. the buttons in prevalue editor.
  https://github.com/mastrup/ourHtagEditor/blob/master/app/App_Plugins/HtagGridEditor/views/headline.editor.html#L7-L13

The button element should also have aria-label if no button text is visible: https://web.dev/button-name/

Feature Request: Allow removal of all alignment options

Be great if you could disable the alignment selection altogether. This would keep the UI clean and sensible when you were not offering a choice to your editors. Great package though!

Feature Request: P tag

It'd be great to have a P tag included in the list of allowed tags. I can try to submit a PR if you'd be interested?

Auto height textarea

At the moment the textarea is set to 1 row and a fixed height of 60px, which has some issues in smaller columns, where text is being cutted off.

It could use something like this to increase the height of the textarea.
It would https://www.jacklmoore.com/autosize/

Use UmbPack to generate package

Currently the grunt-umbraco-package is used to generate the Umbraco package: https://www.npmjs.com/package/grunt-umbraco-package

This is however not up-to-date with support for e.g. icon url and contributors.
The UmbPack is a great tool to generate the Umbraco package https://github.com/umbraco/UmbPack and can also deploy the package to https://our.umbraco.com

I have used it in the Color Pickr package:
https://github.com/bjarnef/color-pickr

where i have a build command to generate the Umbraco and NuGet package:
https://github.com/bjarnef/color-pickr/blob/master/build/build.cmd

Line Breaks

Thank you for a great property editor! I

It would be nice if it was possible to output line breaks. It works in the editor, but it's not outputted.