masukomi / private-comments-mode Goto Github PK
View Code? Open in Web Editor NEWLicense: MIT License
License: MIT License
The repository given in the installation instructions prompts for a "github" username.
The correct (public) repository URL is: https://github.com/masukomi/private-comments-mode.git
Haven't had an opportunity to investigate this as it just happened.
I edited a comment, and that worked as expected, but when the editing window went away i was left with the old version and the new version.
I suspect this is a problem with the code thinking a line is there that isn't anymore or something. Turning PC off and on didn't have an effect. Turning the PC server off an on also didn't have an effect.
🤔 I think it might be useful to enable a "debug mode" in the server that'd spit out all the request data it got...maybe a "logging mode"
The screenshot's kinda 💩because it's a work codebase. Sorry future me (or whoever).
when you comment on a line the private comment should be displayed on the line above it with no line number(s) beside it.
desired behavior
1 <first line of code>
private comment on line 2
another line of private comment
2 <second line of code>
When you comment on a line the private comment has the line number displayed next to the first line of the comment and the line you were commenting on has no line number displayed next to it.
To put it another way, visually, it is taking over the line number's assignment.
actual behavior
1 <first line of code>
2 private comment on line 2
another line of private comment
<second line of code>
emacs-virtual-comment and phantom-inline-comment exhibit the same behavior, so maybe this is just a consequence of emacs behavior and not something easily addressed?
⛔ Warning (private-comments): private-comments--generic-callback[ERROR]: Missing required keys. Only had these: ((project_name_hash . 15ab11337cbe15387c49c4d2430c47cca1f42223881c32fe9f535359b7ca1baa) (file_path_hash . 06e34c24d1814e72b5f01023ecf46264e14c7329faa5aa08eb0523c7847091f2) (line_number . 12) (treeish . c26744bc201))
In case anyone else encounters this, the temporary workaround is to
cd ~/.config/private_comments
grep -r "text from comment"
cd <dir containing matching file>
git rm <matching file>
git commit -m "manually removing obsolete comment"
I think this is a result of rebasing resulting in changed hashes or..... something. Just a guess at this point.
Feeback on the PR to be included in melpa included the following suggestions
private-comments-mode.el
file directlyerror
calls to be user-error
(see below 1)progn
(see below 2)The two checked items are addressed in the melpa_tweaks
branch.
Details on the unchecked items above. Quoted sections are from the feedback on the melpa PR
error
calls should be left as-is, so i just didn't change any rather than only making some of the necessary changes.I think this error:
(error "No private comment found")
should beuser-error
; there are a few other places where I'd suggest replacingerror
withuser-error
such as inprivate-comments-delete
andprivate-comments-record
-- worth double-checking these (user-errors avoid spilling backtraces to the user)
progn
in the else
but maybe i'm misinterpreting.I believe the second
progn
inprivate-comments--apply-callback
shouldn't be required as the "else" part of anif-let
I think the lighter
:lighter " PCM Edit"
should avoid having a space with it (spaces are how we usually distinguish between the different lighters)
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.