Removing the requirement to use a `task_id`

[Andrew-S-Rosen]

Removing the requirement to use a `task_id`

[Andrew-S-Rosen]

Apologies for not being clear. I was knee deep in debugging and being too brief.

Yes, I would recommend having an automatically generated _id field if the user passed task_id=None. In the original example with MontyStore, and _id was automatically generated already. For the JSONStore, there is no such _id field. But I would support this automatic implementation in Store.

[rkingsbury]

Good point @arosen93 . Maybe we could implement this in Store.__init__ such that if you set key=None then the _id field is used by default?

This would require us to manually create ObjectID whenever not using an actual MongoDB - backed store.

[Andrew-S-Rosen]

That seems like a logical approach to me!

[Andrew-S-Rosen]

Motivation for not defaulting to _id: not all Stores have or use _id.

from maggma.stores import JSONStore

with JSONStore("test.json", read_only=False) as store:
    store.update({"test": "hi"})

doesn't work and

from maggma.stores import JSONStore

with JSONStore("test.json", read_only=False) as store:
    store.update({"task_id": "hello", "test": "hi"})

does work and yields a file that contains

[{"task_id": "hello", "test": "hi"}]

with no _id.

[rkingsbury]

Motivation for not defaulting to _id: not all Stores have or use _id.

I'm not sure I understand your point in this example. Is the recommended behavior still to default to an automatically generated _id field if the user passes task_id=None? Obviously we would need to implement this in the base Store class so that it would always be assigned if needed.