Giter Site home page Giter Site logo

Comments (3)

johnson1228 avatar johnson1228 commented on August 17, 2024

@shyuep I have added a class for occupancy analysis. Will add an ipython notebook example soon.

from pymatgen-analysis-diffusion.

shyuep avatar shyuep commented on August 17, 2024

A few issues:

i. The -- attribute is not the right syntax for Sphinx doc.
ii. Indices is not a valid arg in init.
iii. NCount is not pep8 style.
iv. As far as I can tell, this does not support NpT simulations?

For future reference, new features need to be implemented in a separate branch/fork and then a pull request submitted. That way, we can comment on the pull request first.

from pymatgen-analysis-diffusion.

johnson1228 avatar johnson1228 commented on August 17, 2024

Thanks. I have corrected (i) to (iii). As for (iv), you are right that the current version only works for NVT ensemble. In the case of NpT simulations, defining the reference sites is a bit tricky since the cell parameters may change substantially before reaching equilibrium.

from pymatgen-analysis-diffusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.