Giter Site home page Giter Site logo

matsjla / riotquest Goto Github PK

View Code? Open in Web Editor NEW
8.0 3.0 3.0 987 KB

[Deprecated] PHP 7.1+ Library for the Riot Games API

License: MIT License

PHP 99.55% HTML 0.45%
riot-games-api api-client api-framework php php-7 league-of-legends v4 riot-api riot-api-v4

riotquest's Introduction

RiotQuest โ€” API Framework

RiotQuest is a modern PHP 7.1+ framework for the League of Legends API

The framework aims at giving you a simple and elegant way to interact with the API.

Here's a list of some of RiotQuest's features.

  • Automatic Rate Limiting
  • Automatic Caching
  • Laravel Collections over primitive Arrays
  • Environment Variables Support
  • Laravel Integrations
  • DataDragon downloader
  • Automatically updating DataDragon copies
  • Localization available for DataDragon
  • Laravel-like Syntax

The entire project is licensed under the MIT License.

Getting Started

Example

Make a request to Summoner V4 on EUW with Summoner Name "supergrecko"

<?php
use RiotQuest\Client;

$summoner = Client::summoner('euw')->name('supergrecko');
?>

Documentation

The documentation for RiotQuest can be located at https://riotquest.supergrecko.dev/

There is also a mirror available at https://riotquest.netlify.com/

Prerequisites

The library uses Composer for class autoloading and dependency management. Here is a list of things you'll need to get started with RiotQuest.

  • PHP 7.1+
  • ext-json
  • ext-curl
  • Composer

Installation

To install RiotQuest, simply install it using Composer.

$ composer require supergrecko/riot-quest

riotquest's People

Contributors

dependabot-preview[bot] avatar elreco avatar junlarsen avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

riotquest's Issues

Laravel 6 support ?

Hello,

thank you so much for your package. Can you add a laravel 6 support please ?

thank you

Dependabot can't resolve your PHP dependency files

Dependabot can't resolve your PHP dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Your requirements could not be resolved to an installable set of packages.
  Problem 1
    - Installation request for symfony/dotenv 4.3.2 -> satisfiable by symfony/dotenv[v4.3.2].
    - symfony/dotenv v4.3.2 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
  Problem 2
    - Installation request for nesbot/carbon 2.21.3 -> satisfiable by nesbot/carbon[2.21.3].
    - nesbot/carbon 2.21.3 requires php ^7.1.8 || ^8.0 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
  Problem 3
    - Installation request for symfony/cache 4.3.1 -> satisfiable by symfony/cache[v4.3.1].
    - symfony/cache v4.3.1 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
  Problem 4
    - Installation request for phpunit/phpunit 8.2.4 -> satisfiable by phpunit/phpunit[8.2.4].
    - phpunit/phpunit 8.2.4 requires php ^7.2 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
  Problem 5
    - Installation request for symfony/var-dumper 4.3.2 -> satisfiable by symfony/var-dumper[v4.3.2].
    - symfony/var-dumper v4.3.2 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
  Problem 6
    - illuminate/support v5.8.9 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.8 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.4 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.32 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.31 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.30 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.3 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.29 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.28 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.27 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.24 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.22 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.20 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.2 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.19 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.18 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.17 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.15 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.14 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.12 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.11 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - illuminate/support v5.8.0 requires php ^7.1.3 -> your PHP version (7.3.8-1+ubuntu18.04.1+deb.sury.org+1) overridden by "config.platform.php" version (7.1) does not satisfy that requirement.
    - Installation request for illuminate/support 5.8.* -> satisfiable by illuminate/support[v5.8.0, v5.8.11, v5.8.12, v5.8.14, v5.8.15, v5.8.17, v5.8.18, v5.8.19, v5.8.2, v5.8.20, v5.8.22, v5.8.24, v5.8.27, v5.8.28, v5.8.29, v5.8.3, v5.8.30, v5.8.31, v5.8.32, v5.8.4, v5.8.8, v5.8.9].

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

You can mention @dependabot in the comments below to contact the Dependabot team.

"ERROR (code 3): Internal Service Error. Please report this error by opening an issue on GitHub."

Describe the bug
I really don't have a good explanation the request is just not created I'd suppose

To Reproduce
Steps to reproduce the behavior:

  1. use RiotQuest\Client as LeagueAPI;
  2. return LeagueAPI::summoner(strtolower($result->server))->name($result->account_ign);
  3. "ERROR (code 3): Internal Service Error. Please report this error by opening an issue on GitHub."

Expected behavior
Should've returned anything that is not an error

Desktop (please complete the following information):

  • OS: Windows 10
  • PHP Version: 7.2.10
  • RiotQuest Version: ^1.3

Additional context
Should be manifest.json related

Cache key validating not working

Describe the bug
Cache key validating not working

To Reproduce
Steps to reproduce the behavior:

  1. Called freshly account (Works correctly)
  2. Called ranked stats (Works correctly I think)
  3. Called empty match history (I think this is where it breaks)

Expected behavior
I shouldn't get the error message I get on the snippet below

Desktop (please complete the following information):

  • OS: Windows 10
  • PHP Version: 7.2.10
  • RiotQuest Version: 1.3.5

Additional context
Error snippet

#0 E:\XAMPP\htdocs\******\vendor\symfony\cache\Traits\AbstractTrait.php(262): Symfony\Component\Cache\CacheItem::validateKey('riotquest.reque...')
#1 E:\XAMPP\htdocs\******\vendor\symfony\cache\Traits\AbstractAdapterTrait.php(44): Symfony\Component\Cache\Adapter\AbstractAdapter-&gt;getId('riotquest.reque...')
#2 E:\XAMPP\htdocs\******\vendor\symfony\cache-contracts\CacheTrait.php(48): Symfony\Component\Cache\Adapter\AbstractAdapter-&gt;getItem('riotquest.reque...')
#3 E:\XAMPP\htdocs\******\vendor\symfony\cache\Traits\ContractsTrait.php(95): Symfony\Component\Cache\Adapter\AbstractAdapter-&gt;doGet(Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), 'riotquest.reque...', Object(Closure), 1, NULL, NULL)
#4 E:\XAMPP\htdocs\******\vendor\symfony\cache-contracts\CacheTrait.php(30): Symfony\Component\Cache\Adapter\AbstractAdapter-&gt;doGet(Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), 'riotquest.reque...', Object(Closure), 1, NULL)
#5 E:\XAMPP\htdocs\******\vendor\supergrecko\riot-quest\src\RiotQuest\Components\Engine\Request.php(222): Symfony\Component\Cache\Adapter\AbstractAdapter-&gt;get('riotquest.reque...', Object(Closure))
#6 E:\XAMPP\htdocs\******\vendor\supergrecko\riot-quest\src\RiotQuest\Components\Engine\Request.php(105): RiotQuest\Components\Engine\Request-&gt;finalize()
#7 E:\XAMPP\htdocs\******\vendor\supergrecko\riot-quest\src\RiotQuest\Components\Endpoints\Match.php(61): RiotQuest\Components\Engine\Request-&gt;send()
#8 E:\XAMPP\htdocs\******\app\Http\Controllers\UserOrderController.php(93): RiotQuest\Components\Endpoints\Match-&gt;list('VLdpE_EHRBwNzP9...', Array)
#9 [internal function]: App\Http\Controllers\UserOrderController-&gt;index('624')
#10 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Controller.php(54): call_user_func_array(Array, Array)
#11 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\ControllerDispatcher.php(45): Illuminate\Routing\Controller-&gt;callAction('index', Array)
#12 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Route.php(219): Illuminate\Routing\ControllerDispatcher-&gt;dispatch(Object(Illuminate\Routing\Route), Object(App\Http\Controllers\UserOrderController), 'index')
#13 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Route.php(176): Illuminate\Routing\Route-&gt;runController()
#14 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Router.php(680): Illuminate\Routing\Route-&gt;run()
#15 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(30): Illuminate\Routing\Router-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#16 E:\XAMPP\htdocs\******\app\Http\Middleware\isBuyer.php(25): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#17 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): App\Http\Middleware\isBuyer-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#18 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#19 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Middleware\SubstituteBindings.php(41): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#20 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Routing\Middleware\SubstituteBindings-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#21 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#22 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Auth\Middleware\Authenticate.php(43): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#23 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Auth\Middleware\Authenticate-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#24 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#25 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\VerifyCsrfToken.php(75): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#26 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\VerifyCsrfToken-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#27 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#28 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\View\Middleware\ShareErrorsFromSession.php(49): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#29 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\View\Middleware\ShareErrorsFromSession-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#30 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#31 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Session\Middleware\StartSession.php(56): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#32 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Session\Middleware\StartSession-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#33 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#34 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse.php(37): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#35 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#36 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#37 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Cookie\Middleware\EncryptCookies.php(66): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#38 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Cookie\Middleware\EncryptCookies-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#39 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#40 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(104): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#41 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Router.php(682): Illuminate\Pipeline\Pipeline-&gt;then(Object(Closure))
#42 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Router.php(657): Illuminate\Routing\Router-&gt;runRouteWithinStack(Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request))
#43 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Router.php(623): Illuminate\Routing\Router-&gt;runRoute(Object(Illuminate\Http\Request), Object(Illuminate\Routing\Route))
#44 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Router.php(612): Illuminate\Routing\Router-&gt;dispatchToRoute(Object(Illuminate\Http\Request))
#45 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(176): Illuminate\Routing\Router-&gt;dispatch(Object(Illuminate\Http\Request))
#46 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(30): Illuminate\Foundation\Http\Kernel-&gt;Illuminate\Foundation\Http\{closure}(Object(Illuminate\Http\Request))
#47 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php(21): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#48 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\TransformsRequest-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#49 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#50 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php(21): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#51 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\TransformsRequest-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#52 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#53 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\ValidatePostSize.php(27): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#54 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\ValidatePostSize-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#55 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#56 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode.php(62): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#57 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#58 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#59 E:\XAMPP\htdocs\******\vendor\fideloper\proxy\src\TrustProxies.php(57): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#60 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Fideloper\Proxy\TrustProxies-&gt;handle(Object(Illuminate\Http\Request), Object(Closure))
#61 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#62 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(104): Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#63 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(151): Illuminate\Pipeline\Pipeline-&gt;then(Object(Closure))
#64 E:\XAMPP\htdocs\******\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(116): Illuminate\Foundation\Http\Kernel-&gt;sendRequestThroughRouter(Object(Illuminate\Http\Request))
#65 E:\XAMPP\htdocs\******\public\index.php(55): Illuminate\Foundation\Http\Kernel-&gt;handle(Object(Illuminate\Http\Request))
#66 {main}

Logging

Describe the feature you'd like
I'd like to have it so I'm able to disable logging and or get the ability to log using Laravel's default solution.

API Key not being found in Production

Describe the bug
The API Key is not found when in production (using laravel)

To Reproduce
Steps to reproduce the behavior:

  1. Just a normal call.

Expected behavior
Finding the key since the key is set on the .env file both the main .env as the .env in the folder itself

Screenshots
https://i.ibb.co/HV7jfKB/aaaaaa.png

Desktop (please complete the following information):

  • OS: CENTOS 7.4
  • PHP Version: 7.2
  • RiotQuest Version: 1.5.0 (can't update to latest since I'm using laravel 5.8)

Version 1.5.1 breaks on non-Laravel environments

Describe the bug
The 1.5.1 release breaks on non-laravel environment due to missing dependencies which Illuminate/Support pulls from the main Laravel dependency tree.

To Reproduce
Steps to reproduce the behavior:

  1. Create a brand new project
  2. Install v1.5.1
  3. Try to Client::boot()

Expected behavior
The client should work

Desktop (please complete the following information):

  • OS: Windows 10
  • PHP Version: 7.2.13
  • RiotQuest Version: 1.5.1

Additional context
As a temporary workaround downgrading to 1.5.0 seems to work perfectly fine

Error (code 6) on "eune"

Describe the bug
When trying to set the region to eune I get thrown an error code 6

To Reproduce
Steps to reproduce the behavior:

  1. LeagueApi::summoner('eune')->name($result->account_ign)
  2. "ERROR (code 6): Specified region could not be resolved."

Expected behavior
I'm supposed to receive summoner information .

Desktop (please complete the following information):

  • OS: Windows 10
  • PHP Version: 7.2.10
  • RiotQuest Version: 1.3.4

[Laravel] Download static datas in public folder or somewhere else...

Hello :)

What do you think about downloading the json files to the public folder for Laravel ?

'champion' => '/public/data/{locale}/champion.json',
'item' => '/public/data/{locale}/item.json',
'championFull' => '/public/data/{locale}/championFull.json',
'runes' => '/public/data/{locale}/runesReforged.json',
'summoner' => '/public/data/{locale}/summoner.json',
'icon' => '/public/data/{locale}/profileicon.json',
'map' => '/public/data/{locale}/map.json',
'language' => '/public/data/{locale}/language.json',

I don't know if it's possible to specify that path only for Laravel environments.

What do you think about it ?

Thank you ๐Ÿ‘

v1.3.1 Error (code 3)

Describe the bug
The error persists, should be manifest.json related but not sure

To Reproduce
Steps to reproduce the behavior:

  1. use RiotQuest\Client as LeagueAPI;
  2. return LeagueAPI::summoner(strtolower($result->server))->name($result->account_ign);
  3. "ERROR (code 3): Internal Service Error. Please report this error by opening an issue on GitHub."

Expected behavior
Should've returned anything that is not an error

Desktop (please complete the following information):

  • OS: Windows 10
  • PHP Version: 7.2.10
  • RiotQuest Version: ^1.3.1

SCREENSHOT
https://i.imgur.com/eSVvnxU.png

Set ->getRanked() cache time

Is your feature request related to a problem? Please describe.
The main problem is getting fresh ranked data that is not stored for 1 hour.

Describe the solution you'd like
Give me a parameter to set the cache time on the spot.

Describe alternatives you've considered
Give us the chance to set a environment variable with the default TTL.

Code examples, if applicable
$summoner_api->getRanked(60);

List of Matchs

this code is the one i was using to get only matchs from Season 2014 and reports 0 games when it should show all games played in that season.

include ('vendor/autoload.php');
use RiotQuest\Client;
Client::boot();

$accountid = $_GET["id"];

$data = Client::Match('euw')->list($accountid)->getWhereSeason ("4")->getWhereQueue("420");

when using this code

include ('vendor/autoload.php');
use RiotQuest\Client;
Client::boot();

$accountid = $_GET["id"];

$data = Client::Match('euw')->list($accountid);

only show 100 games from 2051 games how can i get the full list?

[QUESTION] How to get current summoner's name from LoL client

I'm new on this API. Just wondering how to get real-time summoner's name from LoL client when joining a match. Is this possible?
I'm aware that OP.GG does it through their Chrome extension, but not sure how it can be done or we have other options.
I know that a simple way could be by filling your summoner name in a website form and refreshing once you join a match, but I'd like to do it without user intervention.
This package looks very interesting!

Error code 3 (Cache related I think)

Describe the bug
A RiotQuest LeagueException has been thrown.
Match the given error code with the ones described at (https://riotquest.supergrecko.dev/docs/exceptions/) for a more verbose description.
ERROR (code 3): Internal Service Error. Please report this error by opening an issue on GitHub.

Maybe allowing to use different cache drivers could help? Not sure

To Reproduce
Steps to reproduce the behavior:

  1. LeagueApi::summoner($info->server, (60 * 2.5))->name($info->account);

Expected behavior
Not to throw me an Error code 3

Desktop (please complete the following information):

  • OS: Windows 10
  • PHP Version: 7.2.10
  • RiotQuest Version: 1.3.7

Additional context

#0 E:\XAMPP\htdocs\----\vendor\supergrecko\riot-quest\src\RiotQuest\Components\Engine\Request.php(158): Symfony\Component\Cache\CacheItem->expiresAfter(150) #1 E:\XAMPP\htdocs\----\vendor\symfony\cache\LockRegistry.php(87): RiotQuest\Components\Engine\Request->RiotQuest\Components\Engine\{closure}(Object(Symfony\Component\Cache\CacheItem), true) #2 E:\XAMPP\htdocs\----\vendor\symfony\cache\Traits\ContractsTrait.php(88): Symfony\Component\Cache\LockRegistry::compute(Object(Closure), Object(Symfony\Component\Cache\CacheItem), true, Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), Object(Closure), NULL) #3 E:\XAMPP\htdocs\----\vendor\symfony\cache-contracts\CacheTrait.php(68): Symfony\Component\Cache\Adapter\AbstractAdapter->Symfony\Component\Cache\Traits\{closure}(Object(Symfony\Component\Cache\CacheItem), true) #4 E:\XAMPP\htdocs\----\vendor\symfony\cache\Traits\ContractsTrait.php(95): Symfony\Component\Cache\Adapter\AbstractAdapter->doGet(Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), 'cfe89021ed82a0d...', Object(Closure), 1, Array, NULL) #5 E:\XAMPP\htdocs\----\vendor\symfony\cache-contracts\CacheTrait.php(30): Symfony\Component\Cache\Adapter\AbstractAdapter->doGet(Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), 'cfe89021ed82a0d...', Object(Closure), 1, Array) #6 E:\XAMPP\htdocs\----\vendor\supergrecko\riot-quest\src\RiotQuest\Components\Engine\Request.php(224): Symfony\Component\Cache\Adapter\AbstractAdapter->get('cfe89021ed82a0d...', Object(Closure)) #7 E:\XAMPP\htdocs\----\vendor\supergrecko\riot-quest\src\RiotQuest\Components\Engine\Request.php(105): RiotQuest\Components\Engine\Request->finalize() #8 E:\XAMPP\htdocs\----\vendor\supergrecko\riot-quest\src\RiotQuest\Components\Endpoints\Summoner.php(55): RiotQuest\Components\Engine\Request->send() #9 E:\XAMPP\htdocs\----\app\Http\Controllers\----er----Controller.php(89): RiotQuest\Components\Endpoints\Summoner->name('CalvinYap') #10 [internal function]: App\Http\Controllers\----er----Controller->index('633') #11 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Controller.php(54): call_user_func_array(Array, Array) #12 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\ControllerDispatcher.php(45): Illuminate\Routing\Controller->callAction('index', Array) #13 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Route.php(219): Illuminate\Routing\ControllerDispatcher->dispatch(Object(Illuminate\Routing\Route), Object(App\Http\Controllers\----er----Controller), 'index') #14 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Route.php(176): Illuminate\Routing\Route->runController() #15 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Router.php(680): Illuminate\Routing\Route->run() #16 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(30): Illuminate\Routing\Router->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #17 E:\XAMPP\htdocs\----\app\Http\Middleware\isLegitimate----er.php(20): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #18 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): App\Http\Middleware\isLegitimate----er->handle(Object(Illuminate\Http\Request), Object(Closure)) #19 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #20 E:\XAMPP\htdocs\----\app\Http\Middleware\is--------er.php(21): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #21 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): App\Http\Middleware\is--------er->handle(Object(Illuminate\Http\Request), Object(Closure)) #22 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #23 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Middleware\SubstituteBindings.php(41): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #24 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Routing\Middleware\SubstituteBindings->handle(Object(Illuminate\Http\Request), Object(Closure)) #25 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #26 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Auth\Middleware\Authenticate.php(43): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #27 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Auth\Middleware\Authenticate->handle(Object(Illuminate\Http\Request), Object(Closure)) #28 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #29 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\VerifyCsrfToken.php(75): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #30 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\VerifyCsrfToken->handle(Object(Illuminate\Http\Request), Object(Closure)) #31 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #32 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\View\Middleware\ShareErrorsFromSession.php(49): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #33 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\View\Middleware\ShareErrorsFromSession->handle(Object(Illuminate\Http\Request), Object(Closure)) #34 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #35 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Session\Middleware\StartSession.php(56): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #36 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Session\Middleware\StartSession->handle(Object(Illuminate\Http\Request), Object(Closure)) #37 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #38 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse.php(37): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #39 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse->handle(Object(Illuminate\Http\Request), Object(Closure)) #40 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #41 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Cookie\Middleware\EncryptCookies.php(66): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #42 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Cookie\Middleware\EncryptCookies->handle(Object(Illuminate\Http\Request), Object(Closure)) #43 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #44 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(104): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #45 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Router.php(682): Illuminate\Pipeline\Pipeline->then(Object(Closure)) #46 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Router.php(657): Illuminate\Routing\Router->runRouteWithinStack(Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request)) #47 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Router.php(623): Illuminate\Routing\Router->runRoute(Object(Illuminate\Http\Request), Object(Illuminate\Routing\Route)) #48 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Router.php(612): Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request)) #49 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(176): Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request)) #50 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(30): Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http\{closure}(Object(Illuminate\Http\Request)) #51 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php(21): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #52 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure)) #53 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #54 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php(21): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #55 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure)) #56 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #57 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\ValidatePostSize.php(27): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #58 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\ValidatePostSize->handle(Object(Illuminate\Http\Request), Object(Closure)) #59 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #60 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode.php(62): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #61 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode->handle(Object(Illuminate\Http\Request), Object(Closure)) #62 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #63 E:\XAMPP\htdocs\----\vendor\fideloper\proxy\src\TrustProxies.php(57): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #64 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Fideloper\Proxy\TrustProxies->handle(Object(Illuminate\Http\Request), Object(Closure)) #65 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #66 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(104): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #67 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(151): Illuminate\Pipeline\Pipeline->then(Object(Closure)) #68 E:\XAMPP\htdocs\----\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(116): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request)) #69 E:\XAMPP\htdocs\----\public\index.php(55): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request)) #70 {main}

Error 3

Describe the bug
I have no idea

Expected behavior
Not Error: 3

Desktop (please complete the following information):

  • OS: Windows 10
  • PHP Version 7.2.10
  • RiotQuest Version 1.3.6

Additional context

[2019-09-22 16:58:58] local.INFO: A RiotQuest LeagueException has been thrown.
             Match the given error code with the ones described 
             at (https://riotquest.supergrecko.dev/docs/exceptions/) 
             for a more verbose description.
             
             ERROR (code 3): Internal Service Error. Please report this error by opening an issue on GitHub.

RiotQuest will move onto 7.4+ once 7.4 has been stabilized

Is your feature request related to a problem? Please describe.
Once 7.4 has been released there will be major optimizations that can be done within the codebase. We will create a stable release for 7.1+ which will stay at that version. That branch will recieve updates if the League APIs change, but will not get new features.

Describe the solution you'd like
We leave a branch at 7.1+ support with a stable release and then move onto 2.0 with 7.4+ only support.

Describe alternatives you've considered
I have considered creating two branches which will be maintained and get new features, but I think it's going to be more beneficial to keep one branch stable for API updates and one for new features.

Code examples, if applicable
We will be replacing all old closures with the new short-closure syntax which is being introduced in 7.4. We will also add types on every class member. This potentially means a new DTO engine as we can typehint the types on props instead of reading from docblock.

Additional context
This proposal might change, we'll see how things evolve.

Filter Stats

How can i filter this stats
image

to get on 5,10,15,20,25,30min?

i dont see on your documentation how to interect with them since on riot it says that is possible to do it

image

Detailed error handling documentation

Is your feature request related to a problem? Please describe.
Having trouble handling errors since there's no documentation that explains to me how to handle it since it looks like it only throws an exception killing the app right away

Describe the solution you'd like
Addition of documentation for error handling

Prefer PSR-6 over PSR-16

Is your feature request related to a problem? Please describe.
Use an existing PSR-6 implementation over the builtin PSR-16 option

Describe the solution you'd like
Change the cache component

Describe alternatives you've considered
Use an existing PSR-16 implementation, but realized a PSR-6 solution will be more robust

Code examples, if applicable
No external code changes, only internal ones.

Additional context
The current component is sort of wack so we're swapping it out for something more robust

getRanked() cache problem(?)

Describe the bug
Getting problem using getRanked()

To Reproduce
Steps to reproduce the behavior:

  1. $api_ranked = $api_summoner->getRanked(60);

Expected behavior
Return ranked information

Desktop (please complete the following information):

  • OS: Windows 10
  • PHP Version 7.2.10
  • RiotQuest Version 1.5.2

Additional context

[2019-11-06 17:54:19] local.INFO: #0 E:\XAMPP\htdocs\********\vendor\symfony\cache\LockRegistry.php(99): RiotQuest\Components\Engine\Request->RiotQuest\Components\Engine\{closure}(Object(Symfony\Component\Cache\CacheItem), true)
#1 E:\XAMPP\htdocs\********\vendor\symfony\cache\Traits\ContractsTrait.php(88): Symfony\Component\Cache\LockRegistry::compute(Object(Closure), Object(Symfony\Component\Cache\CacheItem), true, Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), Object(Closure), NULL)
#2 E:\XAMPP\htdocs\********\vendor\symfony\cache-contracts\CacheTrait.php(68): Symfony\Component\Cache\Adapter\AbstractAdapter->Symfony\Component\Cache\Traits\{closure}(Object(Symfony\Component\Cache\CacheItem), true)
#3 E:\XAMPP\htdocs\********\vendor\symfony\cache\Traits\ContractsTrait.php(95): Symfony\Component\Cache\Adapter\AbstractAdapter->doGet(Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), '63726809f3d1ff5...', Object(Closure), 1, Array, NULL)
#4 E:\XAMPP\htdocs\********\vendor\symfony\cache-contracts\CacheTrait.php(30): Symfony\Component\Cache\Adapter\AbstractAdapter->doGet(Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), '63726809f3d1ff5...', Object(Closure), 1, Array)
#5 E:\XAMPP\htdocs\********\vendor\supergrecko\riot-quest\src\RiotQuest\Components\Engine\Request.php(224): Symfony\Component\Cache\Adapter\AbstractAdapter->get('63726809f3d1ff5...', Object(Closure))
#6 E:\XAMPP\htdocs\********\vendor\supergrecko\riot-quest\src\RiotQuest\Components\Engine\Request.php(105): RiotQuest\Components\Engine\Request->finalize()
#7 E:\XAMPP\htdocs\********\vendor\supergrecko\riot-quest\src\RiotQuest\Components\Endpoints\League.php(37): RiotQuest\Components\Engine\Request->send()
#8 E:\XAMPP\htdocs\********\vendor\supergrecko\riot-quest\src\RiotQuest\Components\Collections\Summoner.php(48): RiotQuest\Components\Endpoints\League->positions('LdNKH5GY61ERuMQ...')
#9 E:\XAMPP\htdocs\********\app\Http\Controllers\User********Controller.php(123): RiotQuest\Components\Collections\Summoner->getRanked(60)
#10 [internal function]: App\Http\Controllers\User********Controller->index('647')
#11 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Controller.php(54): call_user_func_array(Array, Array)
#12 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\ControllerDispatcher.php(45): Illuminate\Routing\Controller->callAction('index', Array)
#13 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Route.php(219): Illuminate\Routing\ControllerDispatcher->dispatch(Object(Illuminate\Routing\Route), Object(App\Http\Controllers\User********Controller), 'index')
#14 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Route.php(176): Illuminate\Routing\Route->runController()
#15 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Router.php(680): Illuminate\Routing\Route->run()
#16 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(30): Illuminate\Routing\Router->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#17 E:\XAMPP\htdocs\********\app\Http\Middleware\isBuyer.php(24): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#18 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): App\Http\Middleware\isBuyer->handle(Object(Illuminate\Http\Request), Object(Closure))
#19 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#20 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Middleware\SubstituteBindings.php(41): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#21 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Routing\Middleware\SubstituteBindings->handle(Object(Illuminate\Http\Request), Object(Closure))
#22 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#23 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Auth\Middleware\Authenticate.php(43): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#24 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Auth\Middleware\Authenticate->handle(Object(Illuminate\Http\Request), Object(Closure))
#25 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#26 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\VerifyCsrfToken.php(75): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#27 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\VerifyCsrfToken->handle(Object(Illuminate\Http\Request), Object(Closure))
#28 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#29 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\View\Middleware\ShareErrorsFromSession.php(49): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#30 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\View\Middleware\ShareErrorsFromSession->handle(Object(Illuminate\Http\Request), Object(Closure))
#31 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#32 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Session\Middleware\StartSession.php(56): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#33 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Session\Middleware\StartSession->handle(Object(Illuminate\Http\Request), Object(Closure))
#34 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#35 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse.php(37): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#36 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse->handle(Object(Illuminate\Http\Request), Object(Closure))
#37 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#38 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Cookie\Middleware\EncryptCookies.php(66): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#39 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Cookie\Middleware\EncryptCookies->handle(Object(Illuminate\Http\Request), Object(Closure))
#40 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#41 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(104): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#42 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Router.php(682): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#43 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Router.php(657): Illuminate\Routing\Router->runRouteWithinStack(Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request))
#44 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Router.php(623): Illuminate\Routing\Router->runRoute(Object(Illuminate\Http\Request), Object(Illuminate\Routing\Route))
#45 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Router.php(612): Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request))
#46 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(176): Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request))
#47 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(30): Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http\{closure}(Object(Illuminate\Http\Request))
#48 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php(21): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#49 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure))
#50 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#51 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php(21): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#52 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure))
#53 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#54 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\ValidatePostSize.php(27): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#55 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\ValidatePostSize->handle(Object(Illuminate\Http\Request), Object(Closure))
#56 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#57 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode.php(62): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#58 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode->handle(Object(Illuminate\Http\Request), Object(Closure))
#59 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#60 E:\XAMPP\htdocs\********\vendor\fideloper\proxy\src\TrustProxies.php(57): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#61 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(163): Fideloper\Proxy\TrustProxies->handle(Object(Illuminate\Http\Request), Object(Closure))
#62 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#63 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(104): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#64 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(151): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#65 E:\XAMPP\htdocs\********\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(116): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request))
#66 E:\XAMPP\htdocs\********\public\index.php(55): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request))
#67 {main}  

Rate limiting

In the documentation the following is mentioned:

You'll need two environment variables to use RiotQuest.
RIOTQUEST_STANDARD_KEY=RGAPI-1234-abcd.... # Riot Games API key
RIOTQUEST_STANDARD_LIMIT=60:20 # 60 requests every 20 seconds

Wouldn't a better solution be to read the limit from the response header of the Riot API (X-App-Rate-Limit) and adjust automatically based on that?
Riots own documentation suggests that you should never hard code any values for rate limiting as they can change at any time.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.