matsn0w/miss-els

Server-sided ELS for FiveM with custom patterns per vehicle, custom sirens, indicator control and more!

miss-els's Issues

Control the sirens regardless of the light stage

You should be able to toggle the siren even when the lights are out.

Do not stop on parse error

The ELS script should just warn the user about a illegible VCF and then continue the script.

"would that prevent the entire script from working properly or just that one file? as of now nothing is working"

Originally posted by @nectar1664 in #2 (reply in thread)

Remove numbers from flash patterns

<Flash /> should be enough to define a flash. The correct order should emerge naturally.

Statics menu only opens after restarting the resource

Sometimes when using the ELS, it bugs and the U menu doesn't open. but when i restart the script then it works. it doenst show a error in console iether

Allow toggling extras for attached trailers

Hey, I was wondering if it is possible to enable the extra's of a trailer, while the player is in the vehicle towing it, without interfering with the vehicles extra's.
A great example of the use would be something like this:

Add stop sign beeping

Describe the solution you'd like
It would be nice if there was an option to enable some beeping sound to indicate that a stop sign is activated. This is common in Dutch vehicles. This should be configurable per vehicle. The sound file should be easily replaceable.

Additional context
Example: https://youtu.be/1n5wRKrxNHc?t=2243

Add extra toggles for static extra's

Would be nice if there was an option to define 'static' extra's, like for takedown lights, that you can map to a specific key.

Maybe something like:

<Extra12 IsElsControlled="true" AllowEnvLight="true" Color="white" Static="true" Key="159" />

The Key option is a nice to have anyway. That'd allow mapping keys per vehicle instead of globally.

VCFdata is nil when other players activate the lights

Hey, so attempting to use this on our server and after installing and getting all the vehicles converted over, I'm getting an error when someone else turns on their lightbar that states VCFdata is indexing a nil value. Can't really spot where the error is originating from however as VCFdata is defined?

https://gyazo.com/ce21b936a736165f0cbb0f97ef8b6563

Much appreciated any help you can give!

Originally posted by @Ninjaborn in #73

Add update checks

Server admins should get a notification in their console when there is a new version of the resource..

Light patterns are not synced properly

Let's assume that the current player is called 'Player A' and one of our friends is called 'Player B'.

When Player A is looking at his own vehicle and starts a light pattern, it looks fantastic. But when he looks at the vehicle of Player B, his pattern may seem 'laggy'.

This problem seems to be caused by a certain limit on how many times the server will sync the extra's on a vehicle. Local changes are visible instantly, but changes are not streamed to other players that fast. This behaviour can also be noticed when manually togglling an extra in a menu (tested with vMenu).

For now, this issue seems to be non-fixable... If you're reading this and you think you have a solution for this, please let me know!

Extra's turn off very briefly at the end of the loop

Sometimes, at the end of a pattern loop, an extra is shortly turned off before 'restarting' the pattern.

Emergency state on all light patterns

AI traffic now treats each light stage as an emergency state, which makes them move to the sides.
However, it would be nice to configure that in the XML which light stage should toggle the emergency state.

For example, the 'STOP' signs / Traffic Advisors etc should not cause traffic to get out of their path to let the vehicle pass.

Allow multiple light stages to be toggled at once

Hey,
i was wondering if it's possible to toggle the secondary lights togheter with the primary lights when pressing Q?
Thanks for helping,

Extra menu is not displayed

Hey, I don't get the extra menu when I press the set button. Only when I restart the MissELS, it works. But when I reconnect then I have the same problem. It always works only after a restart of the script when you are online.

FiveM build: 2545
MISS ELS version: 2.1.1

Add additional env lighting options

The range, intensity and shadow should be overrideable, but with default values set.

Implement base events to support GUI's

Would be nice have a small panel with the light stages etc. represented visually.

Horn Issue

Client/main.lua error whenever driving a car that isn't police which breaks els for that client

[Configurator] Allow moving flashes

Would be nice if you can reorder the flashes in a pattern by draggin them around...

Switch to personal keybinds

Research if it's possible to implement keybinds like this:

This allows players to customize their keybinds individually.

Automatically scan for VCF files

It shoudn't be needed to manually specify each .xml file in the config.

Semver is nil

add me on discord, have some questions

Callum#0500

Car gets repaired for other players when lights are on

When the lights are on and one or more doors are open, other people see them closed somehow.

Keybinds not working in some situations

When in vMenu for example, the keybinds won't work (Q specifically) because it is disabled.

Few issues

Hey

I don't know if its been mentioned i haven't seen but we have a few issues .

One being #77 . The other 2 is when other activate their lights its not flashing as it would in your own car but upon jumping back in you hear the standard sirens playing . This is like this until the lights are turned off and back on again .

Only reset extra's that are enabeld in VCF

This must prevent 'tunring off' extra's that are not lights.

Siren stops working after switching light stage

Whenever I toggle a light stage and I turn on the siren, it works fine.
But when I turn on another light stage (stop signs for example in the video) the siren turns off.
This issue also happens when I have 2 light stages on (blue and stop signs) and I turn one light stage off (turn off stop signs).

Is it possible to make the siren not react to switching light stages?

See video for example. Sorry for poor video quality, had to compress due to the GitHub 10mb filesize.

ELS_Example_BugSiren.mp4

Els randomly stops working

Evening

while using ELS inside fivem it randomly stops the script until you restart it manually .

only error codes we get is below

[ 1383594] [b2189_GTAProce] MainThrd/ ^1SCRIPT ERROR: @ELS/client/main.lua:39: attempt to index a nil value (field '?')^7
[ 1383594] [b2189_GTAProce] MainThrd/ ^3> HandleHorn^7 (^5@ELS/client/main.lua^7:39)
[ 1383594] [b2189_GTAProce] MainThrd/ ^3> fn^7 (^5@ELS/client/main.lua^7:170)

nothing has changed and been dropped into the server as it is in the install.

also I do believe there is a newer version but that one doesn’t work with the server for us if there’s any help with that as well .

many thanks

[Configurator] Visualize patterns

This is a 'nice to have'; it would be great if there was a way to 'play' a created pattern for testing purposes.

Maybe with a canvas and draggable blocks allowing the user to position it 'like on the car' for better visualisation.

Move from NativeUI to WarMenu

Is your feature request related to a problem? Please describe.
The Lua implementation for NativeUI is abandoned. Giving #105, and #110 we should move to a different menu framework that is actively maintained and more stable.

Describe the solution you'd like
WarMenu by warxander seems to be a good option.

Describe alternatives you've considered
LemonUI, but this is written in C#. Unless there's a way to combine a C# menu with the Lua codebase, this is not an option.

Additional context
None.

Is this resource supporting OneSync Infninity?

is thsi supporting onesync infninity?

Expand the statics menu with more options

Describe the solution you'd like
The menu can be used for more than just the statics, having some more options would be nice.

• Add a toggle to enable/disable the headlight flashes

Describe alternatives you've considered

• More keybinds: not practical, already running short
• An additional menu: not practical, one menu seems logic to me

Additional context
In Dutch vehicles, it is actually possible to disable the headlight flashes via the light control panel. This might also be a thing on other countries' vehicles.

F6 menu

hello I cant open the F5 and f6 menu

Lights not synced when entering someone else's vehicle

Describe the bug
If Player A turns on the lights, Player B will see a much slower light pattern than Player A is seeing. it is not syncing correctly over the server

I believe this may be an older issue that was reportedly fixed, however, I am still getting this issue after trying many different methods to fix

Additional context
MISS ELS version: 2.1.1

[Configurator] Extra ID's have no leading 0

VCF's exported by the Configurator are missing a leading zero in their name.

They are now <Extra1 /> for example, which should be <Extra01 /> as the script reads the last characters from the right.

Either fix this in the configurator or take this edge case into account when parsing the XML.

This issue was reported by Gunny Hartman#4134 via my Discord server

Create a VCF configurator GUI

People without coding experience seem to have issues with writing XML. Having a user-friendly GUI would be very nice. Could be hosted in this repo via GitHub Pages, if only using JS.

Only passenger sees light stage changes by himself

When a passenger activates the lights, only he can see it. If the driver activates them, the passenger can see them. The passenger cannot turn them off for driver.

It looks like the event is not streamed to other clients if a passenger activates lights.

No VCF Files

[ script:MISS-ELS] SCRIPT ERROR: @MISS-ELS/server/init.lua:57: Couldn't find any VCF files. Are they in the correct directory?
[ script:MISS-ELS] > scanDir (@MISS-ELS/server/init.lua:57)
[ script:MISS-ELS] > handler (@MISS-ELS/server/init.lua:87)
[ citizen-server-impl] Started resource MISS-ELS

Above error happens in server console. XML files do exist in the xmlFiles folder.
Have used Generator & also renamed examples to not avail.

Operating System: Windows Server 2019

Taillights flashing

Afternoon

having this issue regardless what i change in the metas.

So when i press q i have the 360 lights turn on but also have the brake lights flash on the rear of every vehicle . I want to turn these off so when im braking your able to see this . Also if i toggle k or L these again interact with the brake lights flashing . But if you oress E the standard GTa sirens come on .

Your help is appreciated

`vehicle` is nil when player B is far away from player A

Describe the bug
When player B is far away from player A, player A will get an error because vehicle on line 134 is nil. This happens when player B toggles their lights or sirens on/off.

This issue doesn't appear when both players are near.

This probably also applies to some other parts of the code.

To Reproduce
Steps to reproduce the behavior:

1. Player A: teleport to Zancudo
2. Player B: teleport to LS Airport
3. Player A: monitor F8 console
4. Player B: toggle lights or sirens
5. Player A: take notice of the error

Additional context
FiveM build: 5104
MISS ELS version: 2.1.1

Relevant Discord thread: https://discord.com/channels/941403205064073246/950796981935161364

Add headlight wig wags

Wig wags to be enabled like this https://youtu.be/Knd50CXadzA and be supported .

Add option to activate a static when a pattern is active

Is your feature request related to a problem? Please describe.
It would be nice if it was possible to activate an extra as a static when a pattern is active. This can be useful if an extra should be 'turned on' for the entire loop.

Describe the solution you'd like
Need to think this through carefully. Should be scalable and easy to implement in both the Configurator and the XML.

Describe alternatives you've considered
Currently, a work-around is enabling the extra in each step, but this has the downside of flashing at the end of each loop.

Additional context
This issue was raised by a guy who is trying to create a vehicle with a control panel for the lights (having an visual indicator showing whether the lights are turned on or not).

Exclude additional (repository) files

Maybe move the acutal resource itself into a separate folder and include that as release 'binary'.
That'd reduce the amount of storage that is needed to host this resource.

New structure:

assets/
docs/
resource/
> client/
> html/
> lib/
> server/
> shared/
> xmlFiles/
> config.example.lua
> fxmanifest.lua
.gitignore
README.md

Make indicator controls configurable

It should be possible to change the keybinds for the indicators.

Native emergency mode isn't handled properly

Evening

First of all thank you for your help previously, my next question is however the taillights are disabled if there a way to disable the standard emergency mode that gta v and fivem operate even with ELS activated.

what i mean is when i have 999 mode activated i then go to sound the bullhorn and it stops the standard sirens and ai vehicles stop moving out the way to me.

I hope i made that sound right . if your unsure what i mean let me know and ill try explain it abit better.

Many Thanks

Problem

Alle Spieler die in einem Fahrzeug sitzen hören das Martinshorn obwohl nur einer es an hat wie kann ich das Reparieren

Script crashes if (in config-)specified XML file is not present

I added vehicles to the config.lua but haven't added the XML files yet.
The script prompts an error and is not working on any other vehicle where the XML's ARE there for.

[Configurator] Import existing VCFs

Would be nice if you can import an existing XML file to allow easy editing it.

Separate stages and patterns

Is your feature request related to a problem? Please describe.
Some users have asked questions regarding the creation of asynchronous patterns, especially when multiple light sources are operating at the same time a light stage. This is very hard to 'simulate' with a single pattern.

Describe the solution you'd like
Separate the concepts of 'patterns' and 'light stages': a light stage is a collection of one or more patterns that operate asynchronously and simultaneously. A pattern is a loop of extras being turned on or off for a certain amount of time.

Describe alternatives you've considered
Using two light stages at the same time, but that's giving up one.

els freezes and we can not turn it off or on and error comes up

We get the error main.lua it crashes on the server everyones els and doesnt work again until you reset it.

client/main.lua:123

next siren client/main.lua :123
fn client/main.lua : 227