mattbasta/amo-validator

Validator for addons.mozilla.org

amo-validator's Issues

Move `_build_global` to predefinedentities.py

This shouldn't be a member of the traverser and it's always needed when predefined entities are accessed.

RDFParser should not swallow errors

RDF parse errors should be handled more conservatively.

Reword ChromeManifest contents to sound less like RDF.

Remove the notion of triplets entirely.

Error bundler needs to be better

• Expose compatibility data via output (and update readme)
• Unify the name with the module name
• Break logic out of main module and into helper modules
  • Resource helper
  • Compatibility helper (for_appversions, supports_version, etc.)
  • Subpackage helper (push, pop, etc.)

mozIAsyncFavicons.getFaviconDataForPage gives deprecated warning

nsIFaviconService members removed.
Warning: Several deprecated functions were removed from nsIFaviconService. See https://developer.mozilla.org/docs/XPCOM_Interface_Reference/mozIAsyncFavicons for supported alternatives.
See bug https://bugzilla.mozilla.org/show_bug.cgi?id=838839 for more information.
chrome/content/bookmark.js
221
222
223
.getService(Components.interfaces.mozIAsyncFavicons);
faviconService.getFaviconDataForPage(uri, { onComplete:
function(aURI, aDataLen, aData, aMimeType) {

re-allow installs_allowed_from [*]

the validation at http://localhost:8000/en-US/developers/apps/submit/2 reports Webapp: 'installs_allowed_from'' URL invalid.

WTS statements should not be bounded at 255 characters.

Currently, the DB limits the WTS statements to 255 characters. This should be a TEXT field rather than VARCHAR.

Math

We should (at some point) implement the Math object:

E
LN2
LN10
LOG2E
...

abs
acos
...
tan

http://www.w3schools.com/jsref/jsref_obj_math.asp

Allow tier limiter

Add a command line parameter and/or error bundler attribute that limits the tests to a particular tier. This will help to complete bug 596417.

Getting the following error when running `pip install -r requirements.txt`

error: command 'gcc-4.2' failed with exit status 1

---

Command /usr/bin/python -c "import setuptools;file='/github/amo-validator/build/coverage/setup.py';exec(compile(open(file).read().replace('\r\n', '\n'), file, 'exec'))" install --single-version-externally-managed --record /var/folders/1X/1Xsh0G-AHtKgAUtmvTMG7k+++TI/-Tmp-/pip-TSkBxN-record/install-record.txt failed with error code 1
Exception information:
Traceback (most recent call last):
File "/Library/Python/2.6/site-packages/pip-1.0-py2.6.egg/pip/basecommand.py", line 126, in main
self.run(options, args)
File "/Library/Python/2.6/site-packages/pip-1.0-py2.6.egg/pip/commands/install.py", line 228, in run
requirement_set.install(install_options, global_options)
File "/Library/Python/2.6/site-packages/pip-1.0-py2.6.egg/pip/req.py", line 1093, in install
requirement.install(install_options, global_options)
File "/Library/Python/2.6/site-packages/pip-1.0-py2.6.egg/pip/req.py", line 566, in install
cwd=self.source_dir, filter_stdout=self._filter_install, show_stdout=False)
File "/Library/Python/2.6/site-packages/pip-1.0-py2.6.egg/pip/init.py", line 255, in call_subprocess
% (command_desc, proc.returncode))
InstallationError: Command /usr/bin/python -c "import setuptools;file='/github/amo-validator/build/coverage/setup.py';exec(compile(open(file).read().replace('\r\n', '\n'), file, 'exec'))" install --single-version-externally-managed --record /var/folders/1X/1Xsh0G-AHtKgAUtmvTMG7k+++TI/-Tmp-/pip-TSkBxN-record/install-record.txt failed with error code 1

MPL-Tri licensing

The current license is not only no MPL license, but also GPL incompatible (advertisement clause).
The thing should be re-licensed under MPL-Tri

JS Arguments

The arguments variable needs to be instantiated as a lazy JSArray in every function expression and declaration.

Universal Debug Mode

A better way of managing debug mode needs to be created.

• CLI argument or validate() parameter to enable, rather than a hardcoded switch
• Levels of verbosity
  • Types of output (markup only, JS only, etc.)
  • Ability to fail on exceptions
  • Ability to enter PDB
  • Flow codes, parse codes, both, none
• Lambda evaluation of debug output to prevent performance issues while not in debug mode

Literal members

At least in the case of JSLiteral(str), a bunch of functions and properties need to be implemented (eventually):

split
replace
substr
substring
length
charAt
charCodeAt
concat
fromCharCode
indexOf
lastIndexOf
match
replace
search
slice
toLowerCase
toUpperCase
valueOf

Also, submembers (chars) need to be implemented for JSLiteral(str):

str[index]

For JSLiteral(int):

MIN_VALUE
MAX_VALUE
NEGATIVE_INFINITY
POSITIVE_INFINITY
toExponential
toFixed
toPrecision
toString
valueOf

And JSLiteral(bool):

toString
valueOf

union_members table is MyISAM

All tables should be InnoDB to guarantee atomocity.

Move state tests to registration decorator

Tests like the following should be moved to the registration decorator:

• chrome.manifest presence
• install.rdf presence
• detected_type comparison (against specific value or tuple of values)
• is_subpackage

jslibfetcher should be able to pull tags for github repos

It should automatically get tags for repos like underscore.js and jquery.

Dangerous JS objects

The "dangerous" property for predefined entities should allow a string value. This value should allow the output of a custom error message.

L10n Object Caching

When looking through L10n documents for errors, the entities being compared against (i.e.: en-US) should be cached instead of regenerated on each use. Granted, this is how the SILME library worked, but we should still be more efficient than that.

JSArrays suck.

Arrays need members:

http://www.w3schools.com/jsref/jsref_obj_array.asp