Do not trigger mentions from plugin messages

[mattermost]

Do not trigger mentions from plugin messages

[dhadiseputro]

@jasonblais I'll try to work on this. My idea are (either):

1. Don't trigger mentions from plugins at all, by escaping'@' in https://github.com/mattermost/mattermost-plugin-github/blob/master/server/command.go#L51
2. Add a new option under settings (ex. 'trigger_mentions') that can have a value of true/false which determines to escape '@' .

What I am not sure is how do you guys do escaping of mentions?

[lieut-data]

@dhadiseputro, this is an interesting conundrum. The @ prefixing was recently added to help link a GitHub post back to the Mattermost user of interest. Clicking on a username in that context can be helpful, since it shows the user profile and enables DMs, etc.

There simply currently isn't a way to suppress notifications from an arbitrary post within Mattermost. I'm personally inclined to think that such a feature would be useful, especially for a context like this. @aaronrothschild, maybe this is something to discuss as a higher-level feature request?

[aaronrothschild]

@lieut-data I think this does make sense as something to consider as a higher-level feature. The scenario is similar for our Jira plugin - whenever an activity is detected, we create a DM to that user and it notifies them. We will likely need a an option such as "Do Not trigger Mentions on Jira updates" for example.

[EugenMayer]

Really an important thing for us, any chance this is getting picked up?

Considering the amount of notifications of pushes, this is basically a blocker in using the plugin at all.

I would really love to have this one configurable at least, or hard opt out for now ( until anything more sophisticated is thought about ).

Beside all that, such a lovely integration, that you so much!

[EugenMayer]

Thinking about this twice, i really ask myself "when is this ever usefull". Looking at the code at https://github.com/mattermost/mattermost-plugin-github/blob/master/server/template.go#L85 it basically, if possible, finds the mattermost user corresponding to the git user ( if possible ) and notifies this user about his own action.

How does that make any value to the user? Currently, every time i push, i get myself mentioned in the channel.

We understand mentioning a person as an important "please read this" or "please answer this" - neither of this aspects is in charge here.

It is an action which i already 100% know about and which is streamed into the channel for others to "soft notice" like "reading an activity".

I would provide a simple PR for this but i am very undecided if we want this to be configurable, it really sounds far more like a bug then an enhancement after all.

[EugenMayer]

I'am running the PR #188 on our server now - works like expected (if that helps anybody)

[EugenMayer]

Little update on my side. Since my patch no longer worked an i did not mind to reroll it against 5.37 i disabled the entire plugin.

I rather go without this plugin and not with the fact that all my collegues learn to entirely ignore notification in mattermost since they are bombed by notifications without any use (i just commited, thank you github to tell me that).

I hope there are at least people being happy with this feature and not all of them are basically trying to learn and ignore those notifications, taking down the entire chat app notifications.

Really would have loved to have this feature, but i guess that is just the difference one has to live with compared to slack - integration level and detail.