Comments (11)
Ideally we shift all the github plugin icons to compass icons, but that can be done later. For now we can use font-awesome. I would suggest the outlined version of the comment icon though
from mattermost-plugin-github.
@Kshitij-Katiyar Let's keep is as a HW
from mattermost-plugin-github.
I'm slotted in the icon shown below. I couldn't get the FA v5 icons to work so I found the closest looking one in v4.
https://fontawesome.com/v4/icon/comment-o
from mattermost-plugin-github.
Hi @AdrianoDee! Thanks for creating this issue to discuss this. Would you be interested in implementing this feature?
from mattermost-plugin-github.
@AdrianoDee What is the use case of such a counter/panel? What value does it provide when there are already notifications?
from mattermost-plugin-github.
Hi @mickmister, @hanzei:
- I would be interested but I'm not an expert in Go so it could take some time;
- the point is that with notifications you get notified when you are mentioned and that's it. Having that panel would allow to monitor how the PR you are mentioned are going on. This comes from a project I'm involved in in which each PR is automatically labelled and, based on the labels, reviewers are tagged but do not become assignee.
from mattermost-plugin-github.
@AdrianoDee Great thanks for explaining 👍
I think this feature would bring value as you describe. @hanzei I think this is a welcomed improvement. Thoughts on making this help wanted?
from mattermost-plugin-github.
@mickmister @hanzei Should we make this HW ticket or we should work on this.
from mattermost-plugin-github.
Hi I'd like to pick this up but have some questions:
I'm assuming we want to add this as an overlay trigger to the sidebars, in which case which icon would we want to use?
from mattermost-plugin-github.
Hi I'd like to pick this up but have some questions:
I'm assuming we want to add this as an overlay trigger to the sidebars, in which case which icon would we want to use?
@mickmister @hanzei Can we provide an icon for the sidebar here?
from mattermost-plugin-github.
Hi @cyrusjc, thanks for your interest in contributing 👍
I'm thinking the font awesome comment icon may be appropriate here. This is available by setting the class name fa fa-comment
https://fontawesome.com/icons/comment?f=classic&s=solid. @matthewbirtch Do you have any thoughts on this?
from mattermost-plugin-github.
Related Issues (20)
- this plugin is totally uselsss waste of time HOT 1
- Ephemeral message "Not able to get list of webhooks" after creating a subscription HOT 3
- `issue_creations` subscription with labels should support labeling an existing issue
- Issue/PR descriptions not showing in link tooltips
- Support excluding some users from subscription posts HOT 1
- Support excluding specific comment authors for issue comment subscriptions HOT 6
- For "Issue has been labeled" events, subscriptions do not respect the "render-style" flag for the post size
- Have "PR Merged" subscriptions support filtering labels, for an attached issue
- Subscription posts related to labels should contain a string like "with label x"
- Support `--include-only-org-members` for channel subscriptions HOT 2
- How to troubleshoot? HOT 14
- cleanup / removal of inactive users HOT 6
- Is it possible to make it work properly without setting up the github plugin? HOT 1
- Fix PR subscription error "You cannot update an existing Post" HOT 3
- Consider implementing subscriptions feature as a form/modal HOT 4
- How to remove GitHub integration in mattermost? HOT 8
- Implement server-side localization for the plugin
- Implement webapp-side localization for the plugin
- double underscores in name eaten by markdown HOT 3
- Return proper error reponses from APIs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-plugin-github.