Giter Site home page Giter Site logo

Comments (11)

matthewbirtch avatar matthewbirtch commented on September 22, 2024 2

Ideally we shift all the github plugin icons to compass icons, but that can be done later. For now we can use font-awesome. I would suggest the outlined version of the comment icon though
image

from mattermost-plugin-github.

hanzei avatar hanzei commented on September 22, 2024 1

@Kshitij-Katiyar Let's keep is as a HW

from mattermost-plugin-github.

cyrusjc avatar cyrusjc commented on September 22, 2024 1

I'm slotted in the icon shown below. I couldn't get the FA v5 icons to work so I found the closest looking one in v4.

https://fontawesome.com/v4/icon/comment-o

image

from mattermost-plugin-github.

mickmister avatar mickmister commented on September 22, 2024

Hi @AdrianoDee! Thanks for creating this issue to discuss this. Would you be interested in implementing this feature?

from mattermost-plugin-github.

hanzei avatar hanzei commented on September 22, 2024

@AdrianoDee What is the use case of such a counter/panel? What value does it provide when there are already notifications?

from mattermost-plugin-github.

AdrianoDee avatar AdrianoDee commented on September 22, 2024

Hi @mickmister, @hanzei:

  • I would be interested but I'm not an expert in Go so it could take some time;
  • the point is that with notifications you get notified when you are mentioned and that's it. Having that panel would allow to monitor how the PR you are mentioned are going on. This comes from a project I'm involved in in which each PR is automatically labelled and, based on the labels, reviewers are tagged but do not become assignee.

from mattermost-plugin-github.

mickmister avatar mickmister commented on September 22, 2024

@AdrianoDee Great thanks for explaining 👍

I think this feature would bring value as you describe. @hanzei I think this is a welcomed improvement. Thoughts on making this help wanted?

from mattermost-plugin-github.

Kshitij-Katiyar avatar Kshitij-Katiyar commented on September 22, 2024

@mickmister @hanzei Should we make this HW ticket or we should work on this.

from mattermost-plugin-github.

cyrusjc avatar cyrusjc commented on September 22, 2024

Hi I'd like to pick this up but have some questions:

I'm assuming we want to add this as an overlay trigger to the sidebars, in which case which icon would we want to use?

from mattermost-plugin-github.

Kshitij-Katiyar avatar Kshitij-Katiyar commented on September 22, 2024

Hi I'd like to pick this up but have some questions:

I'm assuming we want to add this as an overlay trigger to the sidebars, in which case which icon would we want to use?

@mickmister @hanzei Can we provide an icon for the sidebar here?

from mattermost-plugin-github.

mickmister avatar mickmister commented on September 22, 2024

Hi @cyrusjc, thanks for your interest in contributing 👍

I'm thinking the font awesome comment icon may be appropriate here. This is available by setting the class name fa fa-comment https://fontawesome.com/icons/comment?f=classic&s=solid. @matthewbirtch Do you have any thoughts on this?

from mattermost-plugin-github.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.