Comments (6)
FYI: There is already a per-user setting in the form of /github mute
. It seems useful to me to have both (a per-subscription and a per-user mute) 👍
from mattermost-plugin-github.
@hanzei Funny enough, I had that in the issue description but removed it for some reason
![](https://private-user-images.githubusercontent.com/6913320/303464665-c351bcfa-a3ab-4026-a386-2abab8758deb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg2MjAwMTksIm5iZiI6MTcxODYxOTcxOSwicGF0aCI6Ii82OTEzMzIwLzMwMzQ2NDY2NS1jMzUxYmNmYS1hM2FiLTQwMjYtYTM4Ni0yYWJhYjg3NThkZWIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYxNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MTdUMTAyMTU5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODZlMWQzZDBkODU2Yjc1YzIwYzBjOTg3OGEzZWRiOGYwMGZjOGIxZDM5ZDBmOWVjNTljMTIxN2UwY2M4NDNmMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.gLsVDVsmxMIy0qMObj0tOLdTUvEkVN3wepIhobq18n0)
Are you suggesting we call the flag mute
when creating/editing the subscription?
from mattermost-plugin-github.
@hanzei I'd like to move this ticket to the monorepo to increase visibility. Do you have any thoughts on my question above?
from mattermost-plugin-github.
My concern is more about whether this setting should be per-user, per-subscription or global. There is already a per-user one. What value does a per-subscription setting add?
from mattermost-plugin-github.
@hanzei The per-user one is for DM notifications. How are you proposing this feature should work? I guess I'm simply not understanding what the exact suggestion is
from mattermost-plugin-github.
@hanzei Do you think this would work well? Or how do you see this working?
/github subscriptions add mattermost/mattermost-plugin-github --exclude-users codecov,mattermod
from mattermost-plugin-github.
Related Issues (20)
- The message generated for the `/github subscriptions list ` slash command should show the excluded repositories (if present). HOT 2
- [Feature request] When linking to pull requests / issues on a private repository, show a preview instead of an error page
- this plugin is totally uselsss waste of time HOT 1
- Ephemeral message "Not able to get list of webhooks" after creating a subscription HOT 3
- `issue_creations` subscription with labels should support labeling an existing issue
- Issue/PR descriptions not showing in link tooltips
- Support excluding some users from subscription posts HOT 1
- For "Issue has been labeled" events, subscriptions do not respect the "render-style" flag for the post size
- Have "PR Merged" subscriptions support filtering labels, for an attached issue
- Subscription posts related to labels should contain a string like "with label x"
- Support `--include-only-org-members` for channel subscriptions HOT 2
- How to troubleshoot? HOT 13
- cleanup / removal of inactive users HOT 6
- Is it possible to make it work properly without setting up the github plugin? HOT 1
- Fix PR subscription error "You cannot update an existing Post" HOT 3
- Consider implementing subscriptions feature as a form/modal HOT 1
- How to remove GitHub integration in mattermost? HOT 8
- Implement server-side localization for the plugin
- Implement webapp-side localization for the plugin
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-plugin-github.