Comments (6)
@mickmister Regarding the approach for the above issue, we can implement the UserHasBeenDeactivated Hook, and whenever a user is deactivated, we can check for the subscriptions linked to the user, if any and delete the subscription. What are your thoughts on this approach, or do you have any other solutions for the approach?
from mattermost-plugin-github.
@ayusht2810 Yeah that sounds great 👍
@nilesingalls Are you wanting to also affect existing deactivated users? That would likely require SQL that we may be able to provide for this
from mattermost-plugin-github.
@mickmister Regarding the above issue, I misunderstood it and posted the wrong approach to it. Sorry for that.
I think the issue states that they don't want to receive the subscription for a user who is inactive on GitHub, as shown in the logs "query":"is:pr is:open review-requested:REDACTED archived:false ","userid":"REDACTED","github username":"REDACTED"
.
But I think the issue is arising from the function HasUnreads
(which posts the user's GitHub todos in certain time interval)
This function is invoked from the
/connected
API, which is called at various places from the client, due to which we are getting the above issue.Isn't deactivating the user from Mattermost server (as the user is also inactive from GitHub) a way to resolve or should we check if the user exist on GitHub and perform further actions?
What are your thoughts on this? Let me know if I am missing something here.
from mattermost-plugin-github.
@ayusht2810 Yeah it doesn't make much sense that these queries would be getting executed if the user is deactivated, and thus not logged into Mattermost. @nilesingalls Are you certain these particular errors are occurring for users that are deactivated from Mattermost?
from mattermost-plugin-github.
These are users who are active in our Mattermost instance but no longer have a github account associated to our github organization. Perhaps our use case is unique in that regard, but we split off a group of users into a separate company.
from mattermost-plugin-github.
@nilesingalls Thanks that makes sense. Are you able to have them each run /github disconnect
?
from mattermost-plugin-github.
Related Issues (20)
- Issue/PR descriptions not showing in link tooltips
- Support excluding some users from subscription posts HOT 1
- Support excluding specific comment authors for issue comment subscriptions HOT 6
- For "Issue has been labeled" events, subscriptions do not respect the "render-style" flag for the post size
- Have "PR Merged" subscriptions support filtering labels, for an attached issue
- Subscription posts related to labels should contain a string like "with label x"
- Support `--include-only-org-members` for channel subscriptions HOT 2
- How to troubleshoot? HOT 14
- Is it possible to make it work properly without setting up the github plugin? HOT 1
- Fix PR subscription error "You cannot update an existing Post" HOT 3
- Consider implementing subscriptions feature as a form/modal HOT 4
- How to remove GitHub integration in mattermost? HOT 8
- Implement server-side localization for the plugin
- Implement webapp-side localization for the plugin
- double underscores in name eaten by markdown HOT 3
- Return proper error reponses from APIs
- v2.4.0
- Make the new Draft PR behavior configurable
- Lower log severity of "Emoji is not supported by Github" warning
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-plugin-github.