Comments (3)
Yeah, that makes sense to me. You'd just be escaping the special characters which seems like a decent fix to me
from mattermost-plugin-github.
Hi @doc-sheet, thanks for filing this issue. This one is interesting.
So when the user posts https://github.com/mattermost/mattermost-data-warehouse/blob/5a88112086f5aefc88ca60ebbbc3668a4ee35ffb/utils/geolite/__main__.py#L10
, we create a post with a link like:
[mattermost/mattermost-data-warehouse/utils/geolite/__main__.py](https://github.com/mattermost/mattermost-data-warehouse/blob/5a88112086f5aefc88ca60ebbbc3668a4ee35ffb/utils/geolite/__main__.py#L10)
, with the underscores being treated as bold instead of preserving them:
![image](https://private-user-images.githubusercontent.com/6913320/342424775-7fd1fe34-6856-445a-b8f8-58c8614d74e2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MTAyMzUsIm5iZiI6MTcyMTUwOTkzNSwicGF0aCI6Ii82OTEzMzIwLzM0MjQyNDc3NS03ZmQxZmUzNC02ODU2LTQ0NWEtYjhmOC01OGM4NjE0ZDc0ZTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjBUMjExMjE1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmIzNDY0ZGMzZDZjYmRjYmMyMWQxOTY0ZTBjMWRhMjkwODZiNGI3ZWRiOWQ0ODJhYjkxNWJlOGM3YzdhMGEzYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.rnRBjoLWKUeHCjvcWH3nkb9-kpQNJmiZWJC0szg3M0Q)
@hmhealey What are your thoughts on this? When creating a markdown link with custom text, some characters can be unintentionally treated as markdown formatting, when they are meant to be kept in tact (such as __main__.py
). If I put backslashes in the link, the markdown is correctly ignored, so the plugin could do this for underscores:
[mattermost/mattermost-data-warehouse/utils/geolite/\_\_main\_\_.py](https://github.com/mattermost/mattermost-data-warehouse/blob/5a88112086f5aefc88ca60ebbbc3668a4ee35ffb/utils/geolite/__main__.py#L10)
rendered as this without the bold markdown:
mattermost/mattermost-data-warehouse/utils/geolite/__main__.py
So the solution could just be to have the plugin prepend underscores in the URL with backslashes
from mattermost-plugin-github.
Is the issue solved?
from mattermost-plugin-github.
Related Issues (20)
- Issue/PR descriptions not showing in link tooltips
- Support excluding some users from subscription posts HOT 1
- Support excluding specific comment authors for issue comment subscriptions HOT 6
- For "Issue has been labeled" events, subscriptions do not respect the "render-style" flag for the post size
- Have "PR Merged" subscriptions support filtering labels, for an attached issue
- Subscription posts related to labels should contain a string like "with label x"
- Support `--include-only-org-members` for channel subscriptions HOT 2
- How to troubleshoot? HOT 13
- cleanup / removal of inactive users HOT 6
- Is it possible to make it work properly without setting up the github plugin? HOT 1
- Fix PR subscription error "You cannot update an existing Post" HOT 3
- Consider implementing subscriptions feature as a form/modal HOT 1
- How to remove GitHub integration in mattermost? HOT 8
- Implement server-side localization for the plugin
- Implement webapp-side localization for the plugin
- Return proper error reponses from APIs
- v2.4.0
- Make the new Draft PR behavior configurable
- Lower log severity of "Emoji is not supported by Github" warning
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-plugin-github.