Improve "Attach to Issue" function

[mattermost]

Improve "Attach to Issue" function

[aaronrothschild]

Knowing that, what happens is:

• Github plugin configured with "gabu9" and GabuTest org, but account connected is "hector2": it will check, with hector2 credentials, if hector2 is blocked from "GabuTest" org, getting 404 (Not blocked).
  So I think there is no way of knowing it a priori. We would know if it is blocked after trying to create the issue comment.

Any ideas?

@hector2 Hmmmm. Interesting problem.

I think returning a genericized message may be the best we can do: Sorry, either you don't have access to the repo {REPO_NAME} with the user {GITHUB_AUTHED_USERNAME} or it is no longer available (404) Does that cover the situation appropriately?

cc @hanzei @DHaussermann

[hectorgabucio]

Hello! Can i work on this issue?

[aaronrothschild]

@hector2 Absolutely, let me know if you have any questions at all!

Removing "Up for Grabs" label for you.

[hectorgabucio]

Hello @aaronrothschild !

I managed to check if the issue has locked the conversation. However, there is a problem checking if the user is blocked from the organization.

I created an organization called "GabuTest", and the owner is "gabu9". In this organization, I blocked myself (hector2).

If I check if the user is blocked (using gabu9 credentials):

curl -u "gabu9" -H "Accept: application/vnd.github.giant-sentry-fist-preview+json" https://api.github.com/orgs/GabuTest/blocks/hector2

The response is 204, it means it is blocked.

However, if I do:
curl -u "hector2" -H "Accept: application/vnd.github.giant-sentry-fist-preview+json" https://api.github.com/orgs/GabuTest/blocks/hector2

The response is 404, I guess because the user itself can't see if it is blocked on an organization.

Knowing that, what happens is:

• Github plugin configured with "gabu9" and GabuTest org, but account connected is "hector2": it will check, with hector2 credentials, if hector2 is blocked from "GabuTest" org, getting 404 (Not blocked).
  So I think there is no way of knowing it a priori. We would know if it is blocked after trying to create the issue comment.

Any ideas?

[hectorgabucio]

@aaronrothschild I tried creating an issue comment in a blocked org repo, and the response was "403 Forbidden" so we could even identify more accurately the problem and say something like "The issue is locked for comments/You don't have permissions to do that action" if you prefer.

[aaronrothschild]

@hector2 Excellent. the more explicit the error message, the better IMO. I would prefer that message.