matthewh806/mdh_modules

vcv rack modules

mdh_modules's Issues

Any chance of a Mac binary?

I would love a Mac binary if possible. Tried to compile, got the following:

src/BpmDancer.cpp:2:10: fatal error: 'component.hpp' file not found

Cannot compile

collect2.exe: error: ld returned 1 exit status
make: *** [C:/msys64/Rack-SDK/compile.mk:52: plugin.dll] Error 1

header corrections, error with addFrame (v1 code)

Fedora 23 Linux
Rack v1.dev.f58fc44
GCC 5.3.1

Greetings ! I hit a few snags when building your v1 repo:

g++  -Wsuggest-override -std=c++11 -Idep/include -fPIC -I../../include -I../../dep/include -MMD -MP -g -O3 -march=athlon-fx -funsafe-math-optimizations -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/game_of_life_sequencer.cpp.o src/game_of_life_sequencer.cpp
src/game_of_life_sequencer.cpp:2:32: fatal error: componentLibrary.hpp: No such file or directory

This error occurred for all files calling componentlibrary.hpp, the error is because of the case you used in componentLibrary.hpp. Linux is case-sensitive, the build failed until I corrected the headers.

This one:

src/BpmDancer.cpp:46:80: error: ‘addFrame’ was not declared in this scope
         addFrame(SVG::load(asset::plugin(pluginInstance, "res/jigglypuff.svg")));

was corrected by repairing the code at line 46 from the above code to this:

addFrameAll(APP->window->loadSvg(asset::plugin(pluginInstance, "res/jigglypuff.svg")));

After these fixes your code compiles for the current (as of today) Rack v1.

Best regards,

Dave Phillips