matubu/minibash

A simple, mini, imperfect version of bash

minibash

🌵 a simple, mini, imperfect version of bash

minibash's Issues

fix all builtins

• unset
• set
• export
• exit
• cd

variables

• a5
• set variables
• export variables
• expand variables
• unset variables
• special variables $* $1 $?
• a'$PATH'

wildcard *, base

• list all file and check pattern
• insert
• remove original
• **
• a*bc -> abzbc => ok

Verifier si il y a des ''

https://github.com/matubu/42minishell/blob/4f678baea46516c3609c55346364a07524b5d8af/src/wildcard.c#L25-L25

to many files open close them

ordering parsing heredoc before boolean operator

echo "cat lol.c | cat > lol.c"

fix infinite loop with recursion ex: cat /dev/urandom | head -n 2 or cat | unknown_command

https://github.com/matubu/42minishell/blob/def46c6dbee3e7836491e8a79ddfd04fc63e1c50/src/pipe.c#L41-L41

export var+=hel

var+=hel

Lire le filedesc de stdout

https://github.com/matubu/42minishell/blob/b440df76187ecbab465b3aab84f1090e40b917b3/src/pipe.c#L60-L60

value=test echo helloworld => will only display helloworld

https://github.com/matubu/42minishell/blob/41bf3934472453451e95aca9b42e6919cc9050d2/src/minishell.c#L64-L64

cat Makefile | grep run: | more

cat /dev/urandom | head -n 5

buildin return value + parsing error

https://github.com/matubu/42minishell/blob/41bf3934472453451e95aca9b42e6919cc9050d2/src/minishell.c#L66-L66

return 1 on parsing error

multiple define a=5 b=6

ex: a=5 b=6

fix heredoc ordering command

fix norminette

• 1
• 2
• 3
• 4
• 5
• 6
• 7
• 8
• 9
• 10

if expanded is not var define

a=a
$a=5 <= will try to find the command a=5 and not define a to 5

ls | ls new line added

echo hello'$PATH'

https://github.com/matubu/42minishell/blob/41bf3934472453451e95aca9b42e6919cc9050d2/src/minishell.c#L68-L68

echo PATH'$PATH hello'

faire des trucs

https://github.com/matubu/42minishell/blob/41bf3934472453451e95aca9b42e6919cc9050d2/src/minishell.c#L98-L98

fix heredoc leaks

''

change $PWD and $OLD_PWD ?

https://github.com/matubu/42minishell/blob/94628881f459d2d756279054d4b6d2cfafd28815/src/builtin.c#L19-L19

status code: $?

• program set exit code
• builtin set exit code
• parsing error set exit code

echo hello > out | cat

Retourner un filedesc du sdout

https://github.com/matubu/42minishell/blob/b440df76187ecbab465b3aab84f1090e40b917b3/src/run.c#L130-L130

check all fd well closed

file open but not close ?
at end of main:

int     i = 0;
while (++i < 255)
	if (lseek(i, 0, SEEK_CUR) != -1)
		printf("\033[31mnot close: %d\n\033[0m", i);

Rendre impossible la lecture de multiple |

https://github.com/matubu/42minishell/blob/231d8eac8a207571be1b688c32ff100ec0aeb2bf/src/pipe_split.c#L74-L74

redirections in

• in error if out already redirected
• pass heredoc to stdin
• parsing
• < file to stdin
• << prompt will not keyword to stdin
• chained heredoc
• no file error

pipe |

• base
• a| b with no spaces.

echo $"PATH"

$"ls"

|| and && with parenthesis

• ||
• &&
• () with recursion
• errors

fix pipes

• 255 ls piped
• cat | cat | ls
• echo "cat lol.c | cat > lol.c"
• cat /dev/urandom | head -n 5
• ls | ls newline added
• echo hello > out | cat

tab separated command ?

cd -

exit 9223372036854775808 or neg

redirect file permission denied

wildcard *, details

• need to be sorted ?

Gerer le cas des quotes pour les pipes

https://github.com/matubu/42minishell/blob/231d8eac8a207571be1b688c32ff100ec0aeb2bf/src/pipe_split.c#L75-L75

check leaks

cat << "" <

cat | cat | ls

should not stop cat when ls end
but cat get a strange behavior and wait two nl but write nothing

ctrl \

ctrl \ kill some program for example: cat (with no arguments) but not a while loop

redirections out

• parsing
• > stdout to file
• >> save stdout with append mode to file
• free me

launch text file with exec permission

echo '' a

output:
[space]a

expected:
a

echo &&|| echo

=test echo helloworld => error

https://github.com/matubu/42minishell/blob/41bf3934472453451e95aca9b42e6919cc9050d2/src/minishell.c#L65-L65