matyb/roman-numerals

A CLI app that converts roman numerals -> arabic integers, and arabic integers -> roman numerals.

roman-numerals's Issues

incomplete unit tests

not all significant permutations w/ integer and numeral conversions are covered, add missing tests to ensure range of numerals are tested adequately.

excessive implementation compared to testing

commit 5fa2334 assumes that all roman numeral permutations are necessary. should have hardcoded return value of "I" to pass test, tested for 3 and while failing hardcoded 3 in implementation to pass test, and tested for next prescribed case and only then considered factoring into a map or data structures holding just necessary numerals for the tests required. adding all the conversion values in one checking was risky and could have allowed garbage or untested code to persist in the implementation. implementation did not evolve as fluidly as a non-presumptive pure tdd implementation should have.

inconsistent naming conventions

variables and method names are too generally named, or are so short that they could be confusing or lack the expressiveness they could have. examples:

• remove converter interface, and expose specific (more explicitly named) conversion methods
• stringbuilder named string, something more specific and less misleading would be better
• toNumber, etc. should be more explicitly named
• other misleading, awkward or overly terse naming should be clarified