mauriciovigolo/file-matcher

Search files recursively using globs, file attributes and content match.

file-matcher's Issues

TypeError: Cannot read property 'content' of undefined

If there aren't file filters it throws the following error:

TypeError: Cannot read property 'content' of undefined
    at FileMatcher.init (.../node_modules/file-matcher/lib/filematcher.js:188:28)
    at FileMatcher.find (.../node_modules/file-matcher/lib/filematcher.js:140:14)

File size limit

Cannot return from wrapping function

When you wrap your file-matcher in a function, it is not possible to use return to exit that function.

See the following example. I''m expecting true or false here but get undefined instead:

var fm = require('file-matcher');

var testStrict = isStrictCodeAvailable();
// testStrict => undefined

function isStrictCodeAvailable() {
    var options = {
        path: '/../example_files/',
        fileFilter: {
            fileNamePattern: '**/*.js',
            content: /use strict/i,
        }
    };

    var fileMatcher = new fm.FileMatcher();
    fileMatcher.find(options)
        .then(function (files) {
            if(files.length > 0) {
                return true;
            } else {
                return false;
            }
        })
        .catch(function (error) {
            // ...
        });
}

There are a lot of functions that use return for jumping out of inner processes (e.g. jQuery.each()) but workarounds as this one don't work because of the asynchronous nature of fileMatcher.find(). Any ideas how to solve this?

File size limit

Do we have a default FileSize limit? And if that's the case, can it be overwritten? I'm having trouble finding the files in my React Project, for some reason the biggest files are ignored, by removing a part of the file, FileMatcher starts finding it again.

The limit seems to be around 250 lines. If the file has roughly 250 or more lines it's ignored. My configuration is as follows:

{
    path: 'src/',
    recursiveSearch: true,
    fileFilter: {
        fileNamePattern: ['**/*.tsx'],
        content: /Component/,
    },
}

The biggest Components are simply ignored.

Error: EMFILE: too many open files

I tried running file-matcher on a large project and I got the error:

   (node:12672) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: EMFILE: too many open files, open 'C:\sessions\XXXXXX.cpp'
   (node:12672) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.