maxep/discogsapi

An Objective-C interface for Discogs API v2.0

discogsapi's Issues

Errors using with xcode 7 and swift 2

Hi there maxine, trying to install the DiscogsAPI cocoapod into a project using Xcode Version 7.0 beta (7A121l) swift 2, using a podfile containing the following:

platform :ios, '7.1'
pod 'DiscogsAPI'
use_frameworks!
xcodeproj '/path to my actual project.xcodeproj'

Ignoring the warnings (46), I get 29 errors before it gives up, as follows. Would really appreciate any help you could give me!

Command /usr/bin/ditto failed with exit code 1
(null): Directory not found for option '-F/Users/haansplosion/Library/Developer/Xcode/DerivedData/MyApp-gzjulonionecwzdqoybpxhoopwbi/Build/Intermediates/SwiftMigration/MyApp/Products/Debug-iphonesimulator/Pods'
(null): Linker command failed with exit code 1 (use -v to see invocation)
Command /bin/sh failed with exit code 23
MyAppUITests Group
Command /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc failed with exit code 1
Command /usr/bin/ditto failed with exit code 1
(null): Linker command failed with exit code 1 (use -v to see invocation)
MyAppTests Group
(null): Linker command failed with exit code 1 (use -v to see invocation)

Pods-DiscogsAPI Group
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/ObjectMapping/RKObjectMapping.h
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/ObjectMapping/RKObjectMapping.h:23:9: Include of non-modular header inside framework module 'RestKit.RKObjectMapping'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/ObjectMapping.h
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/ObjectMapping.h:24:9: Include of non-modular header inside framework module 'RestKit.ObjectMapping'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/ObjectMapping.h:21:9: Could not build module 'RestKit'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Network/RKHTTPRequestOperation.h
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Network/RKHTTPRequestOperation.h:21:9: Include of non-modular header inside framework module 'RestKit.RKHTTPRequestOperation'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Network/RKHTTPRequestOperation.h:22:9: Include of non-modular header inside framework module 'RestKit.RKHTTPRequestOperation'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Network/RKObjectManager.h
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Network/RKObjectManager.h:24:9: Include of non-modular header inside framework module 'RestKit.RKObjectManager'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Vendor/LibComponentLogging/Core/lcl_RK.h
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Vendor/LibComponentLogging/Core/lcl_RK.h:134:1: Expected identifier
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Vendor/LibComponentLogging/Core/lcl_RK.h:134:1: Expected '}'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Vendor/LibComponentLogging/Core/lcl_RK.h:130:31: Expected ';' after enum
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:52:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:53:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:54:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:55:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:56:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:57:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:58:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:59:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:60:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:61:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:62:1: Initializer element is not a compile-time constant
Too many errors emitted, stopping now

DGCollection, DGWantlist's managers never configured

These endpoints are completely unusable as their managers are never set up when DGUser is setup.

Getting tons of keychain save failures on ios 10

(OSStatus) $13 = -34018
2016-09-19 20:19:39.116014 [38153:3716592] [] tcp_connection_cancel 6
2016-09-19 20:19:39.115 [38153:3690891] Unable to add credential with identifier "DGOAuthCredentialDiscogsAccount" (Error -34018)

I get the following error everytime i authorize via oauth on ios 10. The workaround noted here http://stackoverflow.com/questions/29740952/osstatus-error-code-34018 didn't work. Are you seeing tons of failures in new code compiled in xcode 8 on ios 10?

Getting an OAuth error

Getting this error when trying the example:

This URL is an OAuth endpoint, but the request you made doesn't appear to
conform to the OAuth 1.0a protocol.

Please consult these resources:

    - Discogs OAuth docs: http://www.discogs.com/developers/#page:authentication
    - the OAuth specification: http://tools.ietf.org/html/rfc5849
    - the documentation for your OAuth library

for information on how to use this endpoint.

- Discogs, NSErrorFailingURLKey=https://api.discogs.com/oauth/request_token, AFNetworkingOperationFailingURLRequestErrorKey=<NSMutableURLRequest: 0x15c6629d0> { URL: https://api.discogs.com/oauth/request_token }, AFNetworkingOperationFailingURLResponseErrorKey=<NSHTTPURLResponse: 0x15c625fc0> { URL: https://api.discogs.com/oauth/request_token } { status code: 400, headers {
    "Access-Control-Allow-Origin" = "*";
    "Cache-Control" = "public, must-revalidate";
    Connection = close;
    "Content-Length" = 408;
    "Content-Type" = "text/plain";
    Date = "Sun, 04 Oct 2015 21:12:56 GMT";
    "Reproxy-Status" = yes;
    Server = lighttpd;
    "X-Discogs-Media-Type" = "discogs.v2";
} }, NSLocalizedDescription=Expected status code in (200-299), got 400}

Is there something I can do to get this working? I'm using Xcode 7.

I've also had to add this to the info.plist file

    <key>NSAppTransportSecurity</key>
    <dict>
        <key>NSAllowsArbitraryLoads</key>
        <true/>
    </dict>

Delete of wantlist item returns an error even though it succeeded

Delete a wantlist item. I get a 204 (aka "success") yet i get back an error saying it expected 400 level status code?

Error Domain=org.restkit.RestKit.ErrorDomain Code=-1011 "Expected status code in (400-499), got 204" UserInfo={NSLocalizedRecoverySuggestion=, AFRKNetworkingOperationFailingURLRequestErrorKey=<NSMutableURLRequest: 0x618000008210> { URL: https://api.discogs.com/users/nrivard/wants/6686431?notes=&rating=0 }, NSErrorFailingURLKey=https://api.discogs.com/users/nrivard/wants/6686431?notes=&rating=0, AFRKNetworkingOperationFailingURLResponseErrorKey=<NSHTTPURLResponse: 0x61000022d880> { URL: https://api.discogs.com/users/nrivard/wants/6686431?notes=&rating=0 } { status code: 204, headers {
    "Access-Control-Allow-Headers" = "Content-Type, authorization";
    "Access-Control-Allow-Methods" = "GET,PUT,POST,DELETE,PATCH";
    "Access-Control-Allow-Origin" = "*";
    "Cache-Control" = "public, must-revalidate";
    "Content-Length" = 0;
    "Content-Type" = "text/plain";
    Date = "Tue, 28 Mar 2017 03:13:06 GMT";
    Server = nginx;
    "Strict-Transport-Security" = "max-age=16000000";
    "X-Content-Type-Options" = nosniff;
    "X-Discogs-Media-Type" = "discogs.v2";
    "X-Discogs-Ratelimit" = 240;
    "X-Discogs-Ratelimit-Remaining" = 236;
    "X-Discogs-Ratelimit-Used" = 4;
    "X-Frame-Options" = SAMEORIGIN;
    "X-XSS-Protection" = "1; mode=block";
} }, NSLocalizedDescription=Expected status code in (400-499), got 204}

Authentication in auth view doesn't work with google login

My app was rejected by Apple because Google requires their login flow to occur in a system browser, not as part of a webview in a 3rd party app. Not sure what the best solution is here. Perhaps best to explore use of SFAuthenticationSession here, so SFSafariViewController will get automatically launched instead? Otherwise, everyone will have to kick out to regular Safari using the custom callback scheme.

Fail to authenticate

Hi,
I am running DiscogsAPI example project, but I get lots of errors related to the authentication:

Unable to fetch credential with identifier "DGOAuthCredentialDiscogsAccount" (Error -25300)
2015-09-06 13:46:55.846 DiscogsAPI[2341:33891457] T restkit.network:RKObjectRequestOperation.m:148 GET 'https://api.discogs.com/oauth/identity':
request.headers={
Accept = "application/vnd.discogs.v2.discogs+json";
"Accept-Language" = "en-US;q=1";
Authorization = "Discogs key=My Discogs key, secret=My secret";
"User-Agent" = "DiscogsAPI/1 (iPhone; iOS 9.0; Scale/2.00)";
}

In the Info.plist I replaced DISCOGS_APP_CONSUMER_Key with my app's actual consumer key, and DISCOGS_APP_CONSUMER_SECRET with my app's actual consumer secret. I need only Discogs Auth while OAuth is not required by my app.

Did I miss anything in my configuration?

BTW, I am running on XCode 7 Beta 6 on iPhone 6 Simulator.

Can't logout

You are storing credentials in multiple places, not niling out access tokens appropriately etc. I have modified the code to allow DGIdentity.current to be readwrite which does clear out the identity. but subsequent calls to identityWithSuccess succeed immediately when they shouldn't, we should be presented with oauth signin flow.

Rate-limiting ignored

My BatchReleases branch has some work to start to listen to rate-limiting but as it stands, DiscogsAPI just blasts the server with a million concurrent requests.

Do not return any Videos

In DGRelease class,

• (NSArray *)videos{
  return [_videos filteredArrayUsingPredicate:[NSPredicate predicateWithFormat:@"embed == true"]];
  }
  is not return DGVideo list.

property of "videos" is Array of DGVideo, so predicateWithFormat can't be worked.

Memory leak on every request to Discogs

I think this is a RestKit issue but I'm seeing memory leaks on every single request. Here's the callstack:

   0 libsystem_malloc.dylib malloc_zone_malloc
   1 libsystem_malloc.dylib malloc
   2 Foundation -[NSObject(NSKeyValueCoding) validateValue:forKey:error:]
   3 Foundation -[NSObject(NSKeyValueCoding) validateValue:forKeyPath:error:]
   4 RestKit -[RKMappingOperation validateValue:atKeyPath:] /Users/nrivard/Code/DiscogsAPI/Pods/RestKit/Code/ObjectMapping/RKMappingOperation.m:561
   5 RestKit -[RKMappingOperation shouldSetValue:forKeyPath:usingMapping:] /Users/nrivard/Code/DiscogsAPI/Pods/RestKit/Code/ObjectMapping/RKMappingOperation.m:586
   6 RestKit -[RKMappingOperation applyAttributeMapping:withValue:] /Users/nrivard/Code/DiscogsAPI/Pods/RestKit/Code/ObjectMapping/RKMappingOperation.m:732
   7 RestKit -[RKMappingOperation applyAttributeMappings:] /Users/nrivard/Code/DiscogsAPI/Pods/RestKit/Code/ObjectMapping/RKMappingOperation.m:782
   8 RestKit -[RKMappingOperation main] /Users/nrivard/Code/DiscogsAPI/Pods/RestKit/Code/ObjectMapping/RKMappingOperation.m:1240
   9 RestKit -[RKMapperOperation mapRepresentation:toObject:isNew:atKeyPath:usingMapping:metadataList:] /Users/nrivard/Code/DiscogsAPI/Pods/RestKit/Code/ObjectMapping/RKMapperOperation.m:266
  10 RestKit -[RKMapperOperation mapRepresentation:atKeyPath:usingMapping:] /Users/nrivard/Code/DiscogsAPI/Pods/RestKit/Code/ObjectMapping/RKMapperOperation.m:197
  11 RestKit -[RKMapperOperation mapRepresentationOrRepresentations:atKeyPath:usingMapping:] /Users/nrivard/Code/DiscogsAPI/Pods/RestKit/Code/ObjectMapping/RKMapperOperation.m:0
  12 RestKit -[RKMapperOperation mapSourceRepresentationWithMappingsDictionary:] /Users/nrivard/Code/DiscogsAPI/Pods/RestKit/Code/ObjectMapping/RKMapperOperation.m:383
  13 RestKit -[RKMapperOperation main] /Users/nrivard/Code/DiscogsAPI/Pods/RestKit/Code/ObjectMapping/RKMapperOperation.m:422
  14 Foundation -[__NSOperationInternal _start:]
  15 RestKit -[RKObjectResponseMapperOperation performMappingWithObject:error:] /Users/nrivard/Code/DiscogsAPI/Pods/RestKit/Code/Network/RKResponseMapperOperation.m:430
  16 RestKit -[RKResponseMapperOperation main] /Users/nrivard/Code/DiscogsAPI/Pods/RestKit/Code/Network/RKResponseMapperOperation.m:381
  17 Foundation -[__NSOperationInternal _start:]
  18 Foundation __NSOQSchedule_f
  19 libdispatch.dylib _dispatch_client_callout
  20 libdispatch.dylib _dispatch_continuation_pop
  21 libdispatch.dylib _dispatch_async_redirect_invoke
  22 libdispatch.dylib _dispatch_root_queue_drain
  23 libdispatch.dylib _dispatch_worker_thread3
  24 libsystem_pthread.dylib _pthread_wqthread
  25 libsystem_pthread.dylib start_wqthread

Xcode project for working on DiscogsAPI

Can we get an Xcode project so we can actually help contribute to this project? It seems a ton of stuff is broken (this for example: #4) and in order to fix them, there needs to be an Xcode project.