Giter Site home page Giter Site logo

swiftyholidays's Issues

SwiftyHolidays considers LocalDate 2021-12-31 as New Year's Day

Hello,

I was surprised to see that SwiftyHolidays considers 2021-12-31 a holiday in the U.S., specifically New Year's Day. I checked and 2021-12-31 is not a Federal Holiday. In addition, Wall Street was open on that day. Why is then 2021-12-31 considered a holiday?

This is my code snippet:

    func isUnitedStatesHoliday() -> Bool {
        let localDate = self.asLocalDate(in: TimeZone(abbreviation: "EST")!)
        return localDate.isHoliday(in: .unitedStates)
    }

local date looks like:

(lldb) po localDate
▿ LocalDate
  - year : 2021
  - month : 12
  - day : 31

SwiftyHolidays API, public func getHoliday(in country: Country) -> Holiday?, returns:

(lldb) po country.allHolidays(in: year).first { $0.date == self }
▿ Optional<Holiday>
  ▿ some : Holiday
    - name : "New Year\'s Day (observed)"
    ▿ date : LocalDate
      - year : 2021
      - month : 12
      - day : 31

Shouldn't New Year's Day fall on January 1st?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.