maxvar/mcf-reap

(minecraft mod) reap for fabric - right-click on a fully grown plant to harvest and reseed

mcf-reap's Issues

Play plant or break sound

It would be nice if a plant or break sound was played when a crop is harvested.
Just change

public ActionResult onUse(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockHitResult hit) {
    if (!world.isClient() & isMature(state)) {
        return ReapHelper.reap(state, world, pos, player, hand, getSeedsItem().asItem(), getAgeProperty());
    }
    return super.onUse(state, world, pos, player, hand, hit);
}

to

public ActionResult onUse(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockHitResult hit) {
    if(isMature(state)) {
        if (!world.isClient()) {
            return ReapHelper.reap(state, world, pos, player, hand, getSeedsItem().asItem(), getAgeProperty());
        } else {
            player.playSound(SoundEvents.ITEM_CROP_PLANT, 1.0f, 1.0f);
        }
    }
    return super.onUse(state, world, pos, player, hand, hit);
}

update for 1.16-snapshots

Using @Inject instead of @Overwrite?

Hello there, I recently had a request to add compatibility with your mod, as my mod does some stat tracking on breaking crops, the person asking wanted to have using your mod also increment the stat.

However im having some issues getting it to work, because you used @Overwrite instead of @Inject or similar, leaving a simple HEAD injection if your mod is loaded impossible

Would you consider re-writing those parts of your mod to not overwrite methods? Thanks.

I only wish it takes into consideration if you are harvesting using a fortune enchanted tools.

from https://www.curseforge.com/minecraft/mc-mods/simpleharvest?comment=105

add option to collect crops directly into inventory instead of dropping

(discussion here: https://www.curseforge.com/minecraft/mc-mods/maxvar-reap-for-fabric?comment=27)

Crash on server startup

https://pastebin.com/HqPuMsdp

port to 1.18 snapshot

wrong icon shown in mod menu (some stone block?)

update for 1.20.4 and 1.20.5

this mod is really useful in vanilla, will we be seeing it update?

Split common/client sourcesets

use

loom {
   splitEnvironmentSourceSets()

    mods {
        modid {
            sourceSet sourceSets.main
            sourceSet sourceSets.client
        }
    }
 }

update for 20w18a + support fungi, etc

Could not find required mod

Hey!

I installed MC 1.16.4 with Fabric 0.11.1 and newest MCF-Reap.

On startup I get this error:

provide 1.19 version

upgrade for 1.19.3

Update to 1.21?

Will there be an update to this version of the game soon?

add support for Nether Wart

Not work on server

It is not work on server
Everytime I right click the plants, it show me the error on the server, and only have sound but not harvest.

Error executing task on Server
java.lang.RuntimeException: Cannot load class me.shedaniel.clothconfig2.api.AbstractConfigListEntry in environment type SERVER
at Not Enough Crashes deobfuscated stack trace.(1.18.1+build.12) ~[?:?]
at net.fabricmc.loader.impl.transformer.FabricTransformer.transform(FabricTransformer.java:59) ~[fabric-loader-0.12.12.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPreMixinClassByteArray(KnotClassDelegate.java:282) ~[fabric-loader-0.12.12.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:240) ~[fabric-loader-0.12.12.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:150) ~[fabric-loader-0.12.12.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:155) ~[fabric-loader-0.12.12.jar:?]
at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
at net.minecraft.block.CropBlock.onUse(CropBlock:2552) ~[?:?]
at net.minecraft.block.AbstractBlock$AbstractBlockState.onUse(AbstractBlock:937) ~[?:?]
at net.minecraft.server.network.ServerPlayerInteractionManager.redirect$bbo000$activateWithOptionalCactus(ServerPlayerInteractionManager:2029) ~[?:?]
at net.minecraft.server.network.ServerPlayerInteractionManager.interactBlock(ServerPlayerInteractionManager:327) ~[?:?]
at net.minecraft.server.network.ServerPlayNetworkHandler.onPlayerInteractBlock(ServerPlayNetworkHandler:1057) ~[?:?]
at net.minecraft.network.packet.c2s.play.PlayerInteractBlockC2SPacket.apply(PlayerInteractBlockC2SPacket:30) ~[?:?]
at net.minecraft.network.packet.c2s.play.PlayerInteractBlockC2SPacket.apply(PlayerInteractBlockC2SPacket:8) ~[?:?]
at net.minecraft.network.NetworkThreadUtils.method_11072(NetworkThreadUtils:21) ~[?:?]
at net.minecraft.server.ServerTask.run(ServerTask:18) ~[?:?]
at net.minecraft.util.thread.ThreadExecutor.redirect$zkm000$redirectExecuteTask(ThreadExecutor:521) ~[?:?]
at net.minecraft.util.thread.ThreadExecutor.runTask(ThreadExecutor:125) ~[?:?]
at net.minecraft.server.MinecraftServer.runOneTask(MinecraftServer:762) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.runTask(MinecraftServer:756) ~[server-intermediary.jar:?]
at net.minecraft.util.thread.ThreadExecutor.runTasks(ThreadExecutor:110) ~[?:?]
at net.minecraft.server.MinecraftServer.runTasksTillTickEnd(MinecraftServer:740) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.handler$zop000$modifiedRunLoop(MinecraftServer:4365) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer:663) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer:270) ~[server-intermediary.jar:?]
at java.lang.Thread.run(Thread.java:833) [?:?]

add config to mod menu

enable/disable mod, enable/disable direct collection into player's inventory, enable/disable planting sound when reaping.
all options are enabled by default.

the dependency on kotlin language pugin is not needed!

upgrade for 1.18.1