maxwellito/minimator

Minimalist graphical editor

minimator's Issues

Glitch when navigating back from a drawing.

For a split second you can see a column layout flashing when navigating back.

Please include LICENSE

Thanks for creating such a cool tool!

Really glad to see on https://minimator.app/#/about that "the code is open source". However, I can't see a LICENSE file in this repository that meets the Open Source Definition. Can you please add one? GitHub makes this very quick and easy. Thank you!

Touch targets are offset on iPhone 12

Steps to reproduce:

1. Create a 10x10 canvas
2. Draw with finger. The dot selected as the starting point will be five to seven dots directly below your finger.

Arcs are not very “arc-ish”

(Assuming you are not intentionally making the arcs to be not “arc-ish”…)

Like many other graphing programs, Minimator is using Bézier curves to simulate arcs. However the current implementation is not very good, namely if you put 4 such arcs together, they don’t form a good circle. Here I propose to use the method in this doc to do that. This should be very easy to implement: just change the number representing the relative position of the two control points. In the following graph:

Suppose the radius of the arc is 1, then with the current implementation, x = 0.5. According to the doc I linked, a good number for x is 4/3 * tan(π/8) ≈ 0.55228.

I tried this out and made the following graph:

The red circle is the current implementation; the green circle is the improved implementation using the proposed number. The black circles are “true circles” drawn with the circle tag (in quotation marks because the browser may use Bézier curves to implement circle). As you can see, the red circle deviates significantly from the black circle, while the green circle follows it very well (in fact if I made them the same stroke width they are indistinguishable).

Application consistently fails to reload

Minimator worked well the first time I used it in Brave (Chromium spinoff), but after closing it and reloading the page, it now gets stuck on the "Please wait, it's loading" screen.

Checking the developer console, this seems to be caused by issues loading client side data:

storage.js:36 Uncaught Error: Couldn't retrieve the item 1 from LocalStorage.
at Storage.getItem (storage.js:36)
at new HomeCardComponent (home-card.cmp.js:65)
at home.cmp.js:37
at Array.forEach ()
at new HomeComponent (home.cmp.js:36)
at Router.appRouter.onChange (main.js:44)
at Router.hashChange (router.js:35)
at main.js:57

If I switch the browser to incognito mode it works fine, if I switch to another browser it works fine.

Any thoughts on supporting different colors?