Giter Site home page Giter Site logo

consumerjs's People

Contributors

clarity-89 avatar dependabot[bot] avatar sergei-maertens avatar svenvandescheur avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

Forkers

clarity-89

consumerjs's Issues

Support request cancellation

In my use-case I'm using consumerjs to fetch search results based on a number of filters, in a React application. I already de-bounce events, but it happens that a request fires and another search-query is performed before the previous request finishes (thumbnailing on my dev-machine is slow ;) ).

This messes up my component, as the earlier request now overwrites the results from the current search because of the long request time (10s vs 2s for example).

To combat this, I want to be able to cancel the old request. Axios supports this, so this interface should maybe be exposed in ConsumerJS too? See https://github.com/axios/axios#cancellation

Circular structure error when serializing consumer object

__consumer__ property on consumer object causes circular structure error when manually serializing it (for example when saving data to local storage).

Error:

Uncaught TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'CourseConsumer'
    |     property 'client' -> object with constructor 'e'
    --- property 'consumer' closes the circle

Client needs to be loose coupled and hot swappable

Currently, the consumers (this).client is always an instance of the Aurelia http client. This needs to be abstracted so different clients can be used and configured (e.g. a fetch client).

  • Specify the client interface
  • Abstract the current client interface
  • Optionally implement a node.js compatible data client

Add CORS-ability

To be able to make CORS-requests, we should be able to pass the withCredentials: true to axios-requests. This is currently not possible, because consumerjs/axios-http-client cannot be imported to subclass it. This should probably be an option on the abstract-consumer.

Use case:

  1. Run backend server (Django) on http://localhost:8000
  2. Log in - session cookie is set
  3. Run a docker-compose set up on http://localhost
  4. Try to make an authorized request from http://localhost Javascript to http://localhost:8000 and observe that the cookies are not sent.

Implement pagination

This needs te be thought out more clearly, probably would require lists to return a custom type that extends the Array prototype and holds page state related information.

The implementation needs to be generic and not specific for any framework like Django REST. Maybe we should allow something like a pagination class in consumers...

HTTP 204 errors

ConsumerJS expects JSON, while HTTP 204 returns an empty body. This is the case for DELETE requests.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.