mbarbin/eio-rpc

A collection of opinionated libraries designed to build RPC clients and servers with eio

eio-rpc's Issues

Add tests

I was considering two kind of tests to add:

• A end-to-end test that involves running a server and showing a sequence of cli invocation with expectations (expect test).
• A test that connects a client directly with a server running as part of the same process, connecting the handler directly without going through the wire.

TBD.

Issue with `keyval delete` Command Hanging Upon Successful Deletion

I've encountered an issue where the keyval delete command hangs when it successfully deletes a binding.

Assuming a server is running:

$ keyval server run

Here are the steps to reproduce the problem:

$ keyval -- list-keys
()                                    
$ keyval -- set --key a --value Hello
$ keyval -- delete --key b
("Key not found" ((key b)))           
$ keyval -- delete --key a
<hangs>
^C                      

This issue seems to occur only when a binding is actually deleted. If the command is run with a key that doesn't exist, it doesn't hang.

Interestingly, this is the first time I'm using an empty protobuf message with this library (encoding for the type unit returned by the delete rpc in the successful case). Because the behavior depends on the value being returned, I'm considering the possibility that the issue might involve the serialization phase. To be investigated.

Add streaming tests

The current focus in the tests is on unary RPCs. I plan on looking at streaming RPCs next.