mbg033/monero-gui

Monero: the secure, private, untraceable cryptocurrency

monero-gui's Issues

Language selections like in design

https://gyazo.com/841936d07b2b4c345007b5f7b3ef1a96

Error Message When Running Monero Core GUI

I created a private testnet, mined 60 blocks, and successfully transferred between two simplewallets.

I'd like to transfer from a simplewallet to the monero core gui wallet for testing purposes.

When I launch monero-core it says "Connected" under "Network status". However, when I try to transfer from simplewallet to monero-core wallet the balance remains 0 in monero-core wallet even after 6 blocks confirmed the transaction in simplewallet.

In the terminal, it says this...

ERROR /home/administrator/monero-core/bitmonero/src/wallet/wallet2.cpp:780 res.blocks.size() != res.output_indices.size(). THROW EXCEPTION: error::wallet_internal_error

Can anyone point me in the right direction?

In case wallet is password protected, ask user for the password

Check if wallet exists on startup. If it exists - do not start master, start application normally

Implement app popups with with common style used in the app

Different balance in "minimized" mode

(balance for "minimized" mode is hardcoded)

OSX qmake can't find translations

Just cloned repo and trying to build with qt5

qmake

RCC: Error in 'qml.qrc': Cannot find file 'translations/monero-core_de.qm'
RCC: Error in 'qml.qrc': Cannot find file 'translations/monero-core_en.qm'
RCC: Error in 'qml.qrc': Cannot find file 'translations/monero-core_it.qm'
RCC: Error in 'qml.qrc': Cannot find file 'translations/monero-core_pl.qm'
RCC: Error in 'qml.qrc': Cannot find file 'translations/monero-core_ru.qm'
RCC: Error in 'qml.qrc': Cannot find file 'translations/monero-core_zh.qm'

Master: add "daemon address" selection step

or add such edit box into some existing page

Block Wallet-related UI if daemon is not connected

e.g. block "transfer" functionality if daemon not available

Save UI configuration after wizard done

Mac OSX: app crashed after app bundle prepared with macdeployqt

App crashed with the following output:

bash-3.2$ ./monero-core
app startd
QQmlApplicationEngine failed to load component
qrc:///main.qml:34 module "Qt.labs.settings" is not installed
qrc:///main.qml:29 module "QtQuick" is not installed
qrc:///main.qml:31 module "QtQuick.Controls" is not installed
qrc:///main.qml:30 module "QtQuick.Window" is not installed
qrc:///main.qml:33 module "QtQuick.Dialogs" is not installed
qrc:///main.qml:32 module "QtQuick.Controls.Styles" is not installed
qrc:///main.qml:34 module "Qt.labs.settings" is not installed
qrc:///main.qml:29 module "QtQuick" is not installed
qrc:///main.qml:31 module "QtQuick.Controls" is not installed
qrc:///main.qml:30 module "QtQuick.Window" is not installed
qrc:///main.qml:33 module "QtQuick.Dialogs" is not installed
qrc:///main.qml:32 module "QtQuick.Controls.Styles" is not installed
qrc:///main.qml:34 module "Qt.labs.settings" is not installed
qrc:///main.qml:29 module "QtQuick" is not installed
qrc:///main.qml:31 module "QtQuick.Controls" is not installed
qrc:///main.qml:30 module "QtQuick.Window" is not installed
qrc:///main.qml:33 module "QtQuick.Dialogs" is not installed
qrc:///main.qml:32 module "QtQuick.Controls.Styles" is not installed
qrc:///main.qml:34 module "Qt.labs.settings" is not installed
qrc:///main.qml:29 module "QtQuick" is not installed
qrc:///main.qml:31 module "QtQuick.Controls" is not installed
qrc:///main.qml:30 module "QtQuick.Window" is not installed
qrc:///main.qml:33 module "QtQuick.Dialogs" is not installed
qrc:///main.qml:32 module "QtQuick.Controls.Styles" is not installed
qrc:///main.qml:34 module "Qt.labs.settings" is not installed
qrc:///main.qml:29 module "QtQuick" is not installed
qrc:///main.qml:31 module "QtQuick.Controls" is not installed
qrc:///main.qml:30 module "QtQuick.Window" is not installed
qrc:///main.qml:33 module "QtQuick.Dialogs" is not installed
qrc:///main.qml:32 module "QtQuick.Controls.Styles" is not installed
qrc:///main.qml:34 module "Qt.labs.settings" is not installed
qrc:///main.qml:29 module "QtQuick" is not installed
qrc:///main.qml:31 module "QtQuick.Controls" is not installed
qrc:///main.qml:30 module "QtQuick.Window" is not installed
qrc:///main.qml:33 module "QtQuick.Dialogs" is not installed
qrc:///main.qml:32 module "QtQuick.Controls.Styles" is not installed

Segmentation fault: 11

(use make deploy or run build.sh to prepare a bundle)

Some usability concerns

Here is what I think can be considered or ignored :)

1. Confirmation field in password generation dialog is barely visible and confusing, I wasted several minutes to figure out if wallet don't allow me next step because my password is weak or for some another reason.
2. Wallet title bar is annoying, better make it always visible or introduce an auto-hide option.

Prepare all the translatable texts for dynamic translations

qsTr("Something") + translationManager.emptyString

File Path Chooser only opens once

File Path Chooser only opens once

• launch monero-core
• select langauge
• crate new wallet or recreate from seed, doesnt matter
• click into default wallet storage path /home/xxx/Monero Accounts/ to open File Chooser
• close File Chooser via Cancel button
• try to open File Chooser again --> doesnt open

Hide all pages except "Transfer" and "Receive"

for the first beta, we'll have only "transfer" and "receive" functionality

User not asked for password when launching app

on osx, if user sets password on wallet, the next time the wallet is opened, user is not challenged to enter/verify password.

may not be an issue if it has yet to be coded.

Failed build 'cannot find -lwallet_merged2'

When building on Void Linux, with all dependencies installed, the build fails at the final step with

g++ -Wl,-O1 -Wl,-rpath,/usr/lib -o release/bin/monero-core main.o filter.o clipboardAdapter.o oscursor.o WalletManager.o Wallet.o PendingTransaction.o TransactionHistory.o TransactionInfo.o oshelper.o TranslationManager.o qrc_qml.o moc_filter.o moc_clipboardAdapter.o moc_oscursor.o moc_WalletManager.o moc_Wallet.o moc_PendingTransaction.o moc_TransactionHistory.o moc_TransactionInfo.o moc_oshelper.o moc_TranslationManager.o   -L/home/vdo/src/monero-core/bitmonero/lib -lwallet_merged -lwallet_merged2 -Wl,-Bstatic -lboost_serialization -lboost_thread -lboost_system -lboost_date_time -lboost_filesystem -lboost_regex -lboost_chrono -lboost_program_options -lssl -lcrypto -Wl,-Bdynamic -ldl -lQt5Quick -lQt5Widgets -lQt5Gui -lQt5Qml -lQt5Network -lQt5Core -lGL -lpthread 
/usr/bin/ld: cannot find -lwallet_merged2
collect2: error: ld returned 1 exit status

complete log:
https://paste.fedoraproject.org/413036/

Application persistent settings

Following should be saved in persistent settings.

• bool "auto_donations_enabled" // support monero development, shown in wizard
• int "auto_donations_amount" // in percents, auto donation amount
• bool "allow_background_mining" // allows background mining

make clean should remove "bitmonero" directory

Adding Icons for the binary

We need to add icons to the compiled binaries, here are the win and osx icons i did using the monero logo.

I guess for Linux still will be a bit more tricks than adding the icons to the bin/resources, still researching on that.
Archiv.zip

Transfer: handlePayment called twice with single "SEND" click

Add "Receive" page

Integrate "send money" functionality

Fix msys2 deploy

windeployqt from msys2 doesn't put all the runtime dependencies so app can't start outside of msys2 environment

Wallet storage path creation broken

When creating a new wallet or restoring a wallet from seed, selecting a non default storage location for wallet files doesnt quite work.

• launch monero core
• select language
• create new wallet
• Change wallet storage path from /home/xxx/Monero Accouts/ to home/xxx/Desktop/test/
• path displayed is now file:///home/xxx/Destktop/test
• finish wallet creation process by clicking through the defaults

The following folders will get created:

• home/xxx/Desktop/test/
• home/xxx/monero-core/release/bin/file:/home/xxx/Desktop/test/My Account name/ --> this is also where the files are

Port simplewallet to Qt

Implement Qt interface/adaptor for simplewallet so it will be possible to call it from QML

Recive Tab: Integrated Address wrong

Situation right now:

What i would expect:

add a print button to the seed page

monero-core refresh window needs more information

As a user i want to see how the task of scanning the blockchain is processing. Therefore the same Information should be provided to the user as in monero CLI wallet, wich is the current Block Height.

i Imagine something like this:

probably low priority, but since recreation from seed takes a while, this would sure increase the overall user experience

Integrate a "fee multiplier" aka priority

monero-project/monero#878

Allow empty wallet password in the master

Fatal Error when trying to build monero-core

I'm trying to follow the directions from here...

https://github.com/mbg033/monero-core

I'm running a fresh install of Ubuntu 16.04.1 x86 in VirtualBox.

When I get to "make" it gives me the following fatal error.

In file included from main.cpp:38:0:
src/libwalletqt/WalletManager.h:5:32: fatal error: wallet/wallet2_api.h: No such file or directory
compilation terminated.
Makefile:596: recipe for target 'main.o' failed
make: *** [main.o] Error 1

Can anyone point me in the right direction?

Complete wizard path#2

Changes entered by user on Transfer page are not saved on page change

If user entered anything on Transfer page and decided to switch to any other page - changes are gone after Transfer page selected back. Consider to use StackView instead of Loader.

project file: update/compile translation files automatically with make

add qr code to the seed page

https://github.com/M4rtinK/qqr.js

Trailing spaces in transfer address and Payment id

Whenever you enter an address or a payment id that contains a space either at the beginning or the end, GUI rejects it as "Invalid destination address" or "payment id has invalid format" respectively.

User friendliness-wise, i think it would be a nice addition to have the GUI remove these spaces automatically

Implement async versions of WalletManager::openWallet(), WalletManager::closeWallet()

such calls might block for some time, we need to avoid blocking UI

Internationalization. Implement TranslationManager singleton to apply language dynamically

Implement language switch and apply translation on master welcome page

Rename this repository/project to a less-confusing name

Hi, I think that the name of this project and repository is confusing. The core of the project is actually bitmonero. This project is mostly the GUI.

It could be renamed to either:

• monero-gui
• monero-core-gui

Dynamically update "Network Status" indicator

"Network status" indicator on the bottom-left corner should be updated on actual network status change.
Add "connected" property to the Wallet Qt wrapper

Amount Field in Transfer Tab needs validation

I think the Amount Field in Transfer Tab needs some validation.

Situation right now:

• Amount gets not always validated against balance.

With low mixing Count it seems to work:

But with High mixing count it reacts differently and tries to look for outputs to mix before validation against acount balance:

• If Field Amount is empty, Send Button works but nothing happens (same like Address Field) ---> OK
• If Field Amount has invalid value, value gets replaced by dummy value.
  
  

How it should be:

• Amount should always be validated correctly against balance
• Field Amount should be validated correctly, if validation fails, Error message should be displayed.
  Message from Simplewallet is quite cool:

expected number from 0 to 18446744.073709551615

Check and fix Windows build

Ubuntu 16.04: fail to build bitmonero: undefined references lzma_*

Ubuntu 16.04 64-bit:
Building bitmonero with the script in this repository.

/usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/libunwind.a(elf64.o): In function `xz_uncompressed_size':
/build/libunwind-VOtC4T/libunwind-1.1/src/elfxx.c:194: undefined reference to `lzma_stream_footer_decode'
/build/libunwind-VOtC4T/libunwind-1.1/src/elfxx.c:201: undefined reference to `lzma_index_buffer_decode'
/build/libunwind-VOtC4T/libunwind-1.1/src/elfxx.c:205: undefined reference to `lzma_index_size'
/build/libunwind-VOtC4T/libunwind-1.1/src/elfxx.c:210: undefined reference to `lzma_index_end'
/build/libunwind-VOtC4T/libunwind-1.1/src/elfxx.c:207: undefined reference to `lzma_index_uncompressed_size'
/build/libunwind-VOtC4T/libunwind-1.1/src/elfxx.c:210: undefined reference to `lzma_index_end'
/usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/libunwind.a(elf64.o): In function `_Uelf64_extract_minidebuginfo':
/build/libunwind-VOtC4T/libunwind-1.1/src/elfxx.c:278: undefined reference to `lzma_stream_buffer_decode'
collect2: error: ld returned 1 exit status

Check and fix MacOS build

Add application icon

Mac OSX 10.11.5 fails to build - 'QQmlApplicationEngine' file not found

Attempting to build out the GUI wallet and create some better instructions for the crew.

First I found that I had an additional pre-requisite and had to install qt from homebrew. This appears to maybe be part of the problem as QQmlApplicaionEngine appears to be related to qt? Is it perhaps a path issue or something?

Here's what I see in attempting build:
http://pastebin.com/8uu9p9zL

Here are the instructions I'm working on and where I'm stuck:
https://docs.google.com/document/d/1o84WesPBg1jO2eMz_-1lZruQPpnH8b-5SRzIywVuE9Q/edit?usp=sharing

Creation of new account too slow

When creating a new account, monero-core is loading around 5 minutes on my VM.
When creating a new account with CLI wallet, creation process takes around 20 sec on same machine.

Restoring from seed is more or less the same speed with both, so i assume monero-core uses the same way to create new wallets and recreate from seed.

French wallet seed

I see that there is no flag for the French language for a wallet seed. Having one would be useful.

Error connecting to RPC daemon

The GUI shows status as Connected, but on stdout it reports the following:

refreshed
qml: >>> wallet refreshed
qml: >>> wallet updated
ERROR /home/vdo/src/monero-core/bitmonero/src/wallet/wallet2.cpp:590 !r. THROW EXCEPTION: error::no_connection_to_daemon

bitmonerod output:

6-Sep-01 22:56:37.232846 [RPC0]ERROR /DISTRIBUTION-BUILD/src/rpc/core_rpc_server.h:77 Failed to on_get_blocks()
2016-Sep-01 22:56:47.273965 [RPC0]ERROR /DISTRIBUTION-BUILD/src/rpc/core_rpc_server.h:77 Failed to on_get_blocks()
2016-Sep-01 22:56:57.314936 [RPC1]ERROR /DISTRIBUTION-BUILD/src/rpc/core_rpc_server.h:77 Failed to on_get_blocks()
2016-Sep-01 22:56:58.223506 [P2P2][71.202.19.145:56031 INC]Sync data returned unknown top block: 1126602 -> 1009962 [116640 blocks (-81 days) ahead] 
SYNCHRONIZATION started
status
Height: 1126602/1126602 (100.0%) on mainnet, not mining, net hash 25.77 MH/s, v2, up to date, 9+2 connections
2016-Sep-01 22:57:07.355797 [RPC1]ERROR /DISTRIBUTION-BUILD/src/rpc/core_rpc_server.h:77 Failed to on_get_blocks()
2016-Sep-01 22:57:17.396883 [RPC1]ERROR /DISTRIBUTION-BUILD/src/rpc/core_rpc_server.h:77 Failed to on_get_blocks()
2016-Sep-01 22:57:27.437852 [RPC1]ERROR /DISTRIBUTION-BUILD/src/rpc/core_rpc_server.h:77 Failed to on_get_blocks()
2016-Sep-01 22:57:37.478895 [RPC1]ERROR /DISTRIBUTION-BUILD/src/rpc/core_rpc_server.h:77 Failed to on_get_blocks()