mbrezu/cl-messagepack

A Common Lisp implementation of Message Pack

cl-messagepack's Issues

The change to the :initarg of extension-type breaks the test and the code itself.

The change to the :initarg of extension-type from 'id to :id is not compatible with the tests extension-types-encoding and extension-types, which both pass 'messagepack-sym:id to make-instance with the extension-type. Also the :decode-with function that symbol-to-extension-type generates use 'id rather than :id.

Also the "Example" in the documentation string of define-extension-types is broken, just errors when you try to evaluate it.

does not build with SBCL 2.0.9 - slot :initform/:type conflict

Log here: http://report.quicklisp.org/2020-09-28/failure-report/cl-messagepack.html#cl-messagepack

The upshot is that SBCL rejects at compile-time code that has :initform nil :type bar where bar does not include NIL.

Add this implementation to msgpack.org

According to the msgpack website instructions, this involves:

1. Add the keyword msgpack.org[ProjctName] to description of your github repository. ProjectName is typically name of a programming language such as ruby
2. Add one of following files to the root directory of your github repository:

• msgpack.org.md
• README.md
• README.markdown
• README.rdoc
• README.rst
• README

3. Wait a moment. The crawler visits your github repository every hour.

It also suggest naming the project msgpack-lisp.

cl-messagepack access for adolenc

Hi @mbrezu,

I'd suggest to add @adolenc as a collaborateur for cl-messagepack. Sadly I can't do that myself, else I wouldn't have bothered you ;)

Thank you.

Breaking changes to :id initarg

Commit b305346 changed the initarg for defined extension types from :id to messagepack-sym:id and is thus not backwards compatible. This caused a brief headache that could've been avoided by either avoiding breaking changes by using an equivalent alternative, or introducing semantic versioning.

What version of msgpack is implemented?

Is this version 5 compatible? I plan on using this library and I want to know if it can differentiate between strings and binary values. If so I plan on making a pull request to add it.

Thank you for writing this library!

Does not build for me - symbol issue

I get this:

; caught ERROR:
;   READ error during COMPILE-FILE: The symbol "ID" is not external in the MESSAGEPACK package.

Longer log here: http://report.quicklisp.org/2015-01-20/failure-report/cl-messagepack.html

cannot handle dotted pair (bug?)

Hello

Thanks for this library, which I am using for cl-transit.

Surprisingly the library cannot handle dotted pairs (as it'll try to call length on the CDR)...

(mpk:encode '(1 . 2))

is this something wanted?
Happy to work a PR -- let me know!

Cheers