mcfilib/route_soap

Keep your routes clean

route_soap's Issues

Handle Session Controller Demo Hacks

In Improve specs for demo hackz #3314 the session routes are overridden with the demo session controller, a subclass of the session controller.

Until further refactoring, that's the only way to test the demo hacks in the specs. That will however clash with the expectation that sessions routes should go to the SessionsController and not to the DemoSessionsController

If the generator would use a different regex for sessions, that might be helpful.

cc @Filib

Allow optional route params

Optional parameters in the routes are neither replaces with a token, nor are they removed. It generates:

  it { expect(get("/help(/:page)")).to route_to("groups#help", {}) }
  it { expect(get("/technical_support(/:page)")).to route_to("groups#technical_support", {}) }

Options would either be to drop the optional param, or to generate 2 specs, one with and one without the param.

https://github.com/filib/route_soap/blob/master/route_soap.rb#L66 only looks and the required params. http://www.rubydoc.info/docs/rails/4.1.7/ActionDispatch/Journey/Path/Pattern