mcgizzle/haxchange

A uniform collection of API bindings for various cryptocurrency exchanges

haxchange's Issues

Remove Currency' Data Type

the Currency data type is made of a constructor and an auxiliary data type Currency'

data Currency = FIAT Currency' | COIN Currency'

This is overkill, Currency' should be removed and Currency should follow this layout

data Currency = COIN BTC
              | COIN ETH 
                ...
              | FIAT USD
                ... 

Bittrex: alter api call for ticker

call getorderbook instead of gettcker

This will provide the bid and ask volumes.

Testing

Implement hspec for testing each of the API functions.

Initially implement it for Kraken.

Then create a template file to be used when added new exchanges.

Types: Parsing incorrect volume

the FromJSON instances for Ticker types are incorrect.

It reads in the incorrect volume.

Update the ticker type to include volumes for both bid and ask, and alter the FromJSON appropriately

Kraken: Parsing JSON result

At the minute, the handleRes function requires a Bool parameter.

handleRes :: (Show a, FromJSON b, AsValue a) => Bool -> Response a -> IO (Either String b)

Where the Bool is used to decide wether to get the members of the result.

let p = if member then res ^? responseBody . key "result" . members
                  else res ^? responseBody . key "result"

this is an un-elegant hack and should be fixed.

Kraken: Clean up Internal

Refactor out url into function

getUrl :: Opts ->  ([String] -> String) -> String

This can be used to create

getUri :: Opts -> ([String] -> String) -> String
getUri = getUrl (someFunc..)

Should this be generalised to all exchanges and placed in the Utils module?