mcgrof/crda

Central Regulatory Domain Agent

crda's Issues

compile error

CRDA fails to build for me on ubuntu 13.10, with the following errors:

make

GEN keys-gcrypt.c
Trusted pubkeys: pubkeys/linville.key.pub.pem
CC libreg.so
reglib.c: In function ‘reglib_parse_country_simple’:
reglib.c:1130:22: error: argument to ‘sizeof’ in ‘memset’ call is the same expression as the destination; did you mean to dereference it? [-Werror=sizeof-pointer-memaccess]
memset(rd, 0, sizeof(rd));
^
reglib.c: In function ‘reglib_parse_country_dfs’:
reglib.c:1152:22: error: argument to ‘sizeof’ in ‘memset’ call is the same expression as the destination; did you mean to dereference it? [-Werror=sizeof-pointer-memaccess]
memset(rd, 0, sizeof(rd));
^
cc1: all warnings being treated as errors
make: *** [libreg.so] Error 1

Signature of DB always valid if you build without OpenSSL and gcrypt

This may not be an actual issue but I wanted to bring it up. In the event someone builds without OpenSSL and gcrypt, reglib_verify_db_signature always returns 1 (available at https://github.com/mcgrof/crda/blob/master/reglib.c#L203). In the event of DB corruption, regulatory rules could be totally invalid but the CRDA wouldn't know and would return them to the kernel anyway. I'm not sure if this is a big issue since, if you're building a new version of CRDA, you're probably comfortable taking your regulatory risks into your own hands. That said, it still strikes me as potentially dangerous for users to be able to unknowingly break regulatory requirements.

I don't know if this is feasible, or even necessary, but perhaps, the regdb could have a super basic unsigned hash as a protective measure in the event of someone rebuilding CRDA without gcrypt and OpenSSL and database corruption.

reglib.c: 2 * bad calls to scanf

[reglib.c:880]: (warning) scanf without field width limits can crash with huge input data.

Suggest replace mention of %s with %100s.

[reglib.c:941]: (warning) scanf without field width limits can crash with huge input data.

Duplicate.