mcjty/combathelp

combathelp's Issues

PlayerInventoryStore capability not registered

Full details here: squeek502/SpiceOfLife#91

The important bit:

@McJty and I actually made the exact same mistake, and therefore our wires are getting crossed.

Neither of us are registering our capabilities with CapabilityManager.INSTANCE, which means that our @CapabilityInject annotated fields never get populated, which means that we're sending null to getCapability, which then 'succeeds' the conditional and we return our capabilities to eachother incorrectly.

The fix commit for reference: squeek502/SpiceOfLife@06ad04c

Feature Request: Unequip Shield

I really wish there was a keybind for unequipping the shield in 1.9. It gets in the way of building and using some other tools. Since there is already a keybind for equipping it, I feel this would be easily done.

Not working in 1.9.4?

The shield is not equipping when using 1.9.4 version of minecraft

Neither is storing things.

Switching doesn't work

Was just watching Vaygrim's stream and we discussed the mod not working as designed for him on FC2.

We suspect that it might be related to the fact getSlotFor uses stackEqualExact, so if the shield is damaged it doesn't pick up as a valid shield.

Sorry to say I don't have exact version number he's using handy.