mcjty/youtubemodding14

Source code for my YouTube modding tutorial series for Minecraft 1.15 and 1.16

youtubemodding14's Issues

The game crashes when I place a FancyBlock in 1.16

FancyBlock#getShape() will be called in an infinite loop.

GatherDataEvent not firing

GatherDataEvent not firing. Forge: 31.2.25

Error

When I try to sync project with gradle I get:

Unable to start the daemon process.
This problem might be caused by incorrect configuration of the daemon.
For example, an unrecognized jvm option is used.
Please refer to the user guide chapter on the daemon at https://docs.gradle.org/4.9/userguide/gradle_daemon.html
Please read the following process output to find out more:
-----------------------

-----------------------
Check the JVM arguments defined for the gradle process in:
 - gradle.properties in project root directory

I use:

IntelliJ IDEA 2019.2.3 (Community Edition)
Build #IC-192.6817.14, built on September 24, 2019
Runtime version: 11.0.4+10-b304.69 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
GC: ParNew, ConcurrentMarkSweep
Memory: 1490M
Cores: 4
Registry:
Non-Bundled Plugins:

Any ideas?

Pos has private access in Entity

In the getFacingFromEntity function in FirstBlock.java, it throws a error because posX, posY, and posZ all have private access in Entity

BaseLootTableProvider contains incorrectly mapped method calls

Since you wrote the code for BaseLootTableProvider, there have been a couple changes to the mappings.
CopyNBT#func_215881_a => CopyNBT#builder
CopyNTB.builder#func_216055_a => CopyNBT.builder#addOperation

Properties should not be created in the block class

It is not best practice to create properties in the block class. You should instead pass properties to the constructor when creating the block.
By doing this you allow for other mods to potentially extend the block, may not be applicable here but it is still not good to demonstrate bad practices.
See:

YouTubeModding14/src/main/java/com/mcjty/mytutorial/blocks/FirstBlock.java

Lines 36 to 39 in 513b179

	super(Properties.create(Material.IRON)
	.sound(SoundType.METAL)
	.hardnessAndResistance(2.0f)
	.lightValue(14)

Continuations?

Will you be working to continue this tutorial or have you done all that you are going to do with it?

You should invalidate the LazyOptionals in TileEntities

In your tile entity classes with LazyOptional<?> fields, you should be overriding the invalidate method in the tile, and calling lazyOptional.invalidate(); on them.

Structures

Please add structures for 1.14.2

Magic Block Does Not Render with Fabulous Graphics

The translucent part of the Magic Block does not render at all when graphics setting is Fabulous.
It appears as if RenderType.translucent() is not supported by Fabulous graphics.

Hot swap in IDEA

Hi! I've replicated your multi-mob workspace and I think it work very well. The only thing is that I can't change code anymore while debugging because when I do so and recompile, I got an error from IDEA saying that "hot swap failed". I'm changing code inside an existing method, not adding or removing methods or something like that. I've asked about this in the forgegradle minecraft forge forum but got no solutions. Does it work for you?
Sorry if I'm bothering you