mcjtymods/efab

Fabrication

efab's Issues

Error: java.lang.NoClassDefFoundError: Lmcjty/efab/proxy/CommonProxy;

how do i fix this

i contact astral sorcery.

i spoke to astral sorcery and this is what we found. HellFirePvP/AstralSorcery#1201

Pipes Don't Assign Ownership

PipeBlock overrides onBlockPlacedBy, but never calls super.onBlockPlacedBy so McJtyLib ownership is not set correctly and the EFab never recognizes any placed pipes.

The Power Optimizer doesn't affect autocrafting recipes

Recipes that use RF don't craft instantly when crafted with a Crafter, they craft based on the number of Processors instead.

Sound is not affected by a sound muffler

Hey!
Any sound the EFab emits while crafting, e.g. the energy or steam sound, is ignored by the Extra Utlities 2 sound muffler, which is annoying because in my opinion the sound is very penetrating and loud, especially the steam one. Fixing that would also be very appreciated!
MC-version: 1.12.2 -> FTB Continuum
Version: 0.1.0

Support for NBT/Enchantments?

Hi McJty,

Given the following json recipe, it seems to only output regular iron chestplates. We want to make it so that processing certain armors in the efab applies an enchantment to the armor (later on planning to make use of Armory Upgrade. Would it be possible if there could be a syntax that reads for NBT tags?

  {
    "type": "shaped",
    "output": {
      "item": "minecraft:iron_chestplate",
      "ench": [
          {
            "lvl": 1,
            "id": 0
          }
        ]
    },
    "input": [
      "iii",
      "iri",
      "iii"
    ],
    "inputmap": {
      "r": {
        "item": "minecraft:iron_chestplate"
      },
      "i": {
        "item": "thermalfoundation:material:32",
        "meta": "32"
      }
    },
    "time": 30
  },```

ME Controller not craftable

Hello!

I'm trying to craft the ME Controller in the latest version of FTB Continuum, although it seems that it's not possible somehow.
It requires 2000RF/t and therefore I've added 6-8 RF Storages. Nothing is showing up as an error, but as soon as I click on "Start" it immediately shuts off.

What's causing this? I dunno how to find any logs/errors.

Something weird with Efab tanks

Something weird is happening with Efab tanks on the Continuum test server.

The multiblock consists of the crafting grid, a tank with 800mb lava on the east side of the crafting grid and a gear box on the south side of the crafting grid.

Steps I did to cause the crash:

1. Place another tank on top of the lava tank
2. Break the tank
3. Place it on top of the crafting grid
4. Break the tank
5. Place it on the west side of the crafting grid, Crashlog
6. Relaunched, tank is still in inventory.
7. Try placing it again, same crash.
8. Relaunched, tank is now placed, and I have a tank in my inventory. Duped the tank
9. Place the tank south of the gear box, same crash.
10. Place the tank without connection to the multiblock, same crash.
11. Place the tank on the same block as step 10, same crash, no dupe

[Continuum] ME Controller doesn't craft instantly with Power Optimizer

FTBTeam/FTB-Continuum/issues/180

This EFab has a Power Optimizer, but it doesn't craft the ME Controller instantly.

This is the recipe:

This is what it looks like in efab_recipes.cfg:

{
"type": "shaped",
"output": {
"item": "appliedenergistics2:controller"

    },
    "input": [
      "aba",
      "bcb",
      "aba"
    ],
    "inputmap": {
	  "a": {
        "item": "actuallyadditions:block_crystal_empowered",
		"meta": 1
      },
	  "b": {
        "item": "techreborn:part",
		"meta": 3
      },
	  "c": "netherStar"
    },
    "time": 18000,
    "tiers": [
      "GEARBOX",
      "RF",
	  "UPGRADE_DIGITAL",
	  "UPGRADE_POWER"
    ],
    "rfpertick": 2000
  },

tools.

cant craft tools and the upgrades have no crafting recipe.

Can't craft Obsidian

eFab 0.0.37
Using the out-of-the-box eFab settings, I've tried rearranging, etc. Even when I can get the Start button to appear (instead of the ERROR message showing the gearbox-rf bug), I can't get the crafting process to start. It clicks and has no effect in-game. It does however fill the log with this message over and over (sorry, I don't know a way to collapse it or anything):

[17:13:02] [Server thread/FATAL] [net.minecraft.server.MinecraftServer]: Error executing task
java.util.concurrent.ExecutionException: java.lang.AbstractMethodError: Method mcjty/efab/blocks/rfcontrol/RfControlTE.getEnergyStored(Lnet/minecraft/util/EnumFacing;)I is abstract
at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_171]
at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_171]
at net.minecraft.util.Util.func_181617_a(SourceFile:47) [h.class:?]
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:723) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?]
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:185) [chd.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_171]
Caused by: java.lang.AbstractMethodError: Method mcjty/efab/blocks/rfcontrol/RfControlTE.getEnergyStored(Lnet/minecraft/util/EnumFacing;)I is abstract
at mcjty.efab.blocks.rfcontrol.RfControlTE.getEnergyStored(RfControlTE.java) ~[RfControlTE.class:?]
at mcjty.efab.blocks.grid.GridTE.getErrorsForOutput(GridTE.java:1164) ~[GridTE.class:?]
at mcjty.efab.blocks.grid.GridTE.getErrorState(GridTE.java:1123) ~[GridTE.class:?]
at mcjty.efab.network.PacketReturnGridStatus.(PacketReturnGridStatus.java:78) ~[PacketReturnGridStatus.class:?]
at mcjty.efab.network.PacketGetGridStatus$Handler.handle(PacketGetGridStatus.java:47) ~[PacketGetGridStatus$Handler.class:?]
at mcjty.efab.network.PacketGetGridStatus$Handler.lambda$onMessage$0(PacketGetGridStatus.java:38) ~[PacketGetGridStatus$Handler.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_171]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_171]
at net.minecraft.util.Util.func_181617_a(SourceFile:46) ~[h.class:?]
... 5 more

Advanced RF Storage Only Providing the Power of a Regular RF Storage

Advanced RF Storage blocks are only providing the power of regular RF Storage blocks during the crafting operation. For example, in Continuum, the ME Controller requires 2,000 RF/t, but the crafting operation immediately stops after clicking start and the EFab monitor flashes "error". This is when using two Advanced RF Storage blocks (configured at 1,000 RF/t each). However, eight regular RF Storage blocks work fine (configured at 250 RF/t each).

The resolution of issue #12 fixed the initial error before you could even begin the crafting operation. This new issue appears to be caused by this line:

EFab/src/main/java/mcjty/efab/blocks/grid/GridTE.java

Line 400 in d451343

stillneeded = handlePowerPerTick(stillneeded, this.rfStorages, GeneralConfiguration.rfStorageInternalFlow);

Each RF Storage is being capped at the configured value of a regular RF Storage instead of determining the type of RF Storage and using its configured amount.

Mod version: efab-0.1.0

I can seem to make the gearbox?

I click the + icon to add the ingredients to the crafting table but i am not able to craft it?

Gif of what i mean:

https://gyazo.com/fff855a6177c1964a7aeabccc83c6cef

[Question] Is it possible to add upgrades?

Is it possible to add custom upgrades (like the RF and Magic modules) or accept other items as upgrades to be used in recipes?

For example, in FtB Continuum (sorry for the flak you undeservedly took), IE treated wood was made a piece at a time and only required creosote. What if someone wanted to make it also require an infuser item (added with some tweaking mod) or maybe some already existing appropriate sounding mechanical part from another mod.

Advanced RF Storages provide no RF/t to the EFab

Advanced RF Storages provide no RF/t to the EFab. This multiblock should be providing 1050 RF/t , but it only provides 50.

This is using efab-0.0.37.jar

FTBTeam/FTB-Continuum/issues/181

Error: java.lang.NoClassDefFoundError: Lmcjty/efab/proxy/CommonProxy;

how would i fix this?

RF Control blocks do not contribute to the RF/t amount in the craft

This is the setup I have. At this moment, each RF control says in the description that it should give 20rf/t to the craft which make it 80rf/t. The rf storage gives 30rf/t as indicated in the description of the block as well, which brings the RF/T total to 110.

I am trying to craft the base obsidian recipe which needs 10rf/t with 1 rf control. With the 4 that I have, it now needs 40rf/t, but I cannot craft it. If I add another rf Storage, it does start crafting.

It seems that it is not taking in account the RF Control rf/t at all and only using the RF Storage RF/t numbers

EFab causes major rendering lag

I'm currently getting to the end game of FTB and I've noticed that my FPS is tanking, when looking into the issue it seems like for what ever reason EFab crafters cause a massive amount of interference rendering other tile entities.

At the moment a setup that has about 64+ Crafters in one location and I started to profile the area using Lag Goggles and here are the results.

With EFabs:

Without EFabs:

Now... You're going to need to trust me on this next part. Every time I run the profile it seems to choose another random Vanilla entity to blame for the high render time per frame, but it always seems to be related to rendering EFab related machines.

This isn't really a poor computer hardware problem either. My specs are as follows:

Intel i7-7700k @ 4.8 GHz
16GB DDR 4 RAM
GTX 980 x2 in SLI

It would be great to also have a config option to enable and disable complex rendering and have a simpler block version for each machine. Having rotating wheels and piston animations for no reason seems silly.

ConcurrentModificationException in dev env

In development environment, attempting to craft using RF results in issues spammed once per tick.

EFab 0.1.0
McJtyLib 3.0.3
Forge 14.23.4.2736

[Server thread/FATAL] [minecraft/MinecraftServer]: Error executing task
java.util.concurrent.ExecutionException: java.lang.AbstractMethodError: Method mcjty/efab/blocks/rfcontrol/RfControlTE.getEnergyStored(Lnet/minecraft/util/EnumFacing;)I is abstract
	at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_144]
	at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_144]
	at net.minecraft.util.Util.runTask(Util.java:54) [Util.class:?]
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:798) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:743) [MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) [IntegratedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:592) [MinecraftServer.class:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_144]
Caused by: java.lang.AbstractMethodError: Method mcjty/efab/blocks/rfcontrol/RfControlTE.getEnergyStored(Lnet/minecraft/util/EnumFacing;)I is abstract
	at mcjty.efab.blocks.rfcontrol.RfControlTE.getEnergyStored(RfControlTE.java) ~[RfControlTE.class:?]
	at mcjty.efab.blocks.grid.GridTE.getErrorsForOutput(GridTE.java:1207) ~[GridTE.class:?]
	at mcjty.efab.blocks.grid.GridTE.getErrorState(GridTE.java:1166) ~[GridTE.class:?]
	at mcjty.efab.network.PacketReturnGridStatus.<init>(PacketReturnGridStatus.java:78) ~[PacketReturnGridStatus.class:?]
	at mcjty.efab.network.PacketGetGridStatus$Handler.handle(PacketGetGridStatus.java:47) ~[PacketGetGridStatus$Handler.class:?]
	at mcjty.efab.network.PacketGetGridStatus$Handler.lambda$onMessage$0(PacketGetGridStatus.java:38) ~[PacketGetGridStatus$Handler.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_144]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_144]
	at net.minecraft.util.Util.runTask(Util.java:53) ~[Util.class:?]
	... 5 more```

suggestion: Set crafter works without redstone signal

All mods have inverted logic: if no redstone - then work. If redstone == true then stop. Because 99% players want always run machines. Machine must work by default. Only Efab crafter request redstone for working. Its not convenient. I should build redstone wires to each crafter.
Please, invert logic.

astral sorcery

the bow crafting dose not work because of astral sorcery .

efab with unknown fluid

hey got this crash with a fluid not sure which it doesnt know about or whats written wrong
https://pastebin.com/sJ9iPGCL
could you see about making it give a line number when it throws this error.
im using a modified version FTB continum's config. tring to learn it and make it work for my own pack.
seems really tricky to get it how i wants to read it. if you cold add some flexablility this was that'd be much appreciated
https://pastebin.com/N5RJdvvR
^ this is what i have going on

Item Storages Pulls Items from other Storages

Named Item Storages Pulls Items from other Storages.
This happens when both Storages are used currently by a crafter and the recipe contain same Items like Redstone.

End result of this is that for example a single Item like a Redstone is in the wrong Item Storage.

Efab still will not craft anything that requires RF

Attempted to use every single suggestion on previous issue requests posted. None of them work. It makes a short circuit sound, then wont work. First it tried, made it to 20 seconds of crafting, before failing and stopping, and that was with plenty of power pumping into the system from a 10 Million RF storage. Was trying to craft the machine frame to progress. So no, ITS NOT WORKING AS INTENDED.

custom recipe with thermal dynamics doesnt work

i have been trying for a while now to make a custom thermal expansions duct recipe however for some reason it does not seem to like "thermaldynamics:duct_48" i assume because it doesnt like underscored item names as it was also throwing an error for "thermalfoundation:material:323" which i found that FTB continuum had that as metadata so i replicated below.

crash-2018-06-25_19.34.28-client.txt

in the log it says "Expected name at line 14 column 53" in which the script pasted below is an exact copy of what i have got (well, instead of spaced out it is tabbed out with notepad++)

{
"type": "shaped",
"output":{"item": "thermaldynamics:duct_0*3"},
"input":[
"rar",
"pdp",
"rar"
],
"inputmap": {
"r":{"item": "minecraft:redstone"},
"a":{"item": "enderio:item_alloy_ingot", "meta": 4},
"p":{"item": "thermalfoundation:material", "meta": 323},
"d":{"item": "thermaldynamics:duct_48"},},
,"time": 30, "tiers": ["GEARBOX"]}

im no expert but i think efab is throwing errors????

i know this may not need to go to you but i figure it would be faster than ftb trying to contact you.
also i posted this to the ftb teams issue tracker first.

**Modpack ftb continuum Version 1.0.2

**Issue honestly dont know, crashes randomly
related to efab (im no coder and im an idiot so when reading the files i couldn't figure it out)

**Link to Log or Crash File Paste
main/last was the direct copy of what i saw right when i crashed in the video if that helps.

main/ last log: https://paste.feed-the-beast.com/view/5bad566d
old: https://paste.feed-the-beast.com/view/35cf00f4
old: https://paste.feed-the-beast.com/view/b80ed83c

most logs were deleted, the crash happened around 6 or 7 times before the one in the video.

Is it Repeatable?: kinda.... watch video https://youtu.be/Q0qfg9ZFpV4
video may take a bit to be completely uploaded, youtube likes to take their time.

thank you for your time and sorry for my crap typing and spelling skills...

Shapeless recipes are not actually shapeless

Making a shapeless EFab recipe will require the ingredients to be arranged in the same way despite being "shapeless".

Autocrafting bug.

Sometime(at start game) efab not autocrafting. Why?
If break and place any gearbox, then will start crafting.

CraftTweaker Support?

Would it be possible to add CraftTweaker support to EFab recipes? Working with the json has resulted in pretty large and bloated files. The next FTB expert pack, Interactions, is already at 1.5k lines in the json file, and a large amount of it being somewhat repetitive, which could've been done a lot more quickly if there was zenscript support and could do loops.

In addition, it would be less of a nightmare trying to implement NBT tags as IItemStacks already has its own way of handling NBT.

Thanks.

EFab Crash

Forge 14.23.5.2816
EFab 0.2.0

Modpack: Manufactio

Crashing on completing the crafting of an item with EFab. Crash seems to occur when using multiple EFab Crafting Grids at the same time. Cannot replicate at will.

Crashlog: https://pastebin.com/gK5B50ML

Note: similar issue

crafters cannot craft at the same time

I am trying to craft the printed circuits in Continuum.

In the 2 images below, you can see that the screen shows that at least one of them is idle at all time. 1 is always Idle if I try to craft the 4 different printed "STUFF" at the same time.

• They have separate inventory,
• They are all named
• When 3 are working, the 3 of them work.

they need : Gearbox, RF, RF upgrade and Digital upgrade

Please, do release new version. The modpack not playable long time.

How long wait new version? The mod contain very more bugs.
I wait for fix #19, 23, 24, 25

Multiple Efab Crafting Grids on one system cause severe TPS issues

I beleive that this issue is known, but using Tick Profiler I got some data regarding the effects of additional Efab grids on tps

With the 5 Grid setup I was running:
Average Time/tick
grid.GridTE 25.039

Overworld TPS: 2.9333

After removing all but one grid:
Average Time/tick
grid.GridTE: no longer listed(negligable)

Overworld tps: 19.96

The server was operating perfectly even with many grids for a while, but seemingly spontaneously, they started creating severe TPS issues.

[Question/Plea] Having problems crafting the machine frame in FTB Continuum

I try to craft the machine frame and it makes an electic buzzing sound for a second, then stops.
There are no errors listed on the Start button, and my abilities far exceed what is listed as necessary.
When I hit Start, the timer appears above the start button and immediately disappears again.
I have double checked the ingredients in the table, have plenty of the liquid ingredients.
All blocks are connected properly.
I tried re-arranging blocks to see if that mattered.
All energy related blocks have power flowing directly to them and have full power indicators.

I'm at a loss, and am stuck.

Any ideas?

Placing the crafting grid on a big multiblock causes lag spikes or a crash-loop

On the ftbone server I have a big efab multiblock, the multiblock is located in Advanced Rocketry's space station dimension.

Forge: 14.23.3.2678
Efab: 0.0.36
McJtyLib: 2.6.7

It's a 21x21x1 layer of efab bases and 36 of them being rf storages, 9 elevator blocks (OpenBlocks) and one magma block for the boiler.
I have 19 Item Storages, 19 Crafters, 1 Boiler, 1 Steam Engine, 1 Power Optimizer, 1 Rf Control, 2 Pipes, 1 Processor, 1 Efab Crafting Grid, 4 Gearboxes and 9 tanks that each consists of 5 advanced tanks.

The gaps in the layer are supposed to be rf storages.

Now, when I try breaking/placing rf storages the server has a big lag spikes, sometimes enough to boot you off the server, and a couple times it crashed: Crash log

I first discovered this when placing the crafting grid, that's when the first spike happened, and it has happened since, when I removed this crafting grid, the lag spikes stopped happening. When I place it back, the lag spikes start when breaking or placing rf storages, or any other block except efab bases. Break it and the spikes are gone.

I placed it again, this time the server went into a crash loop: Log

Information from Sampler about the block

Reproduced in singleplayer, Sampler (1.73) gave me this Log
In singleplayer I removed all "special" blocks and the levers powering the crafters, still stalling the game.

I think the issue here is how the efab crafting grid handles the calculating of the multiblock when first placed. However I think it's also related to how many block is placed in any direction of the crafting grid. The issue didnt happen when it was placed close to the middle, but as it was moved further towards the corners it increased the time it took to calculate the multiblock to the point the client couldnt handle it anymore and stalled the game.

Recipes

Would it be possible to get some examples for the scripts used in the json file and the name and the save path for the json file.

Idea: Autocrafting Upgrades

At the moment I am playing continuum and I could not find a way (Even after googling it) of autocrafting things that use upgrades like the power or the digital upgrade.

If there is a way I am sorry for spamming your github messages, if not i would suggest an endgame solution for this problem.
Because it is realy annoying to craft thousands of stack manually, even if you use more then 1 crafting Grid.

Sound bug

(bad english)
When i craft using efab+steam, then my sound like as noise. Client-log spaming messages:
[Thread-9/ERROR] [minecraft/SoundManager]: Error in class 'SourceLWJGL OpenAL'
[Thread-9/ERROR] [minecraft/SoundManager]: Channel null in method 'stop'
[Thread-9/ERROR] [minecraft/SoundManager]: Error in class 'SourceLWJGL OpenAL'
[Thread-9/ERROR] [minecraft/SoundManager]: Channel null in method 'stop'
Steam sound(and gearbox sound) start and stop every tick.
I should set all sound volume to 0 in config file.

Expanded Documentation?

Just wondering if there are any plans for extended documentation. I'm finding the base examples to be insufficient.

1. I have no idea how to implement upgrades or what they're intended for.
2. I have no idea what is required or not in a recipe. A simple list of all possible nodes, when they're required, how they're related, etc. Obviously a fluids node is needed for liquid tier crafts, but what else is possible?