md-cwi/afivo-streamer

Code for plasma fluid simulation of streamer discharges

afivo-streamer's Issues

Avoiding chemistry data overwritten by simulation restarts

Currently when we run a simulation, a <simulation name>_rates.txt file is created where the space-time integrated reaction rates are written out.
When restart a simulation using the restart_from_file functionality, this _rates.txt file is overwritten with the data from the later time step, i.e., the older data is lost.

New flux - current control compilation error in 1d and 3d

In the new_flux branch, using the latest commit, the following error occurs during compilation:

make[1]: Warning: File 'm_geometry.mod' has modification time 0.78 s in the future
gfortran -c -o m_field.o ../src/m_field.f90 -O2 -g -std=f2008 -fopenmp -Wall -Wextra -Wimplicit-interface -Wshadow -Wno-unused-dummy-argument -cpp -DNDIM=1 -I../afivo/lib_1d
../src/m_field.f90:603:11:

  603 |           w(i, :) = w(i, :) * twopi * af_cyl_radius_cc(box, i)
      |           1
Error: Rank mismatch in array reference at (1) (2/1)
../src/m_field.f90:603:54:

  603 |           w(i, :) = w(i, :) * twopi * af_cyl_radius_cc(box, i)
      |                                                      1
Warning: Procedure ‘af_cyl_radius_cc’ called with an implicit interface at (1) [-Wimplicit-interface]
../src/m_field.f90:603:54:

  603 |           w(i, :) = w(i, :) * twopi * af_cyl_radius_cc(box, i)
      |                                                      1
Error: Function ‘af_cyl_radius_cc’ at (1) has no IMPLICIT type
../src/m_field.f90:603:21:

  603 |           w(i, :) = w(i, :) * twopi * af_cyl_radius_cc(box, i)
      |                     1
Error: Rank mismatch in array reference at (1) (2/1)
make[1]: *** [../makefiles/makerules.make:30: m_field.o] Error 1
make[1]: Leaving directory '/ufs/hemadity/afivo-streamer/lib_1d'
make: *** [../../makefiles/program.make:49: ../../lib_1d/libstreamer.a] Error 2

It seems the current code isnt working for 1D case. The same occurs when I compile a 3d case as well.
Compiles just fine for 2D.

List of examples of various simulation settings

Hi all,

I think it would be really helpful (for future work) if we put some effort have a list of examples where we demonstrate how various settings in the cfg file affect the simulation results.
Currently, we have a set of .cfg files that demonstrate a particular setup, e.g., multiple pulses, gas heating, 3D.
But we dont have any examples for the numerical settings, e.g., mesh refinement, limiting fluxes, interpolation settings of transport files, dt settings, etc.
The motivation for this opening this issue is that many researchers who tend to use this package dont seem to have a working knowledge of numerical methods which might result in them producing incorrect results.
Then they tend to spend a lot of time trying to understand what is going wrong.
Consequently, there is an over dependence on a single person (usually the code maintainer), which is really inefficient.
So please contribute ideas/working examples (in the form of a .cfg file of a simulation setup, or an image demonstrating the functionality.) which will act as a reference guide for future users of this package. E.g., see the image attached that demonstrates how the streamer length varies when varying 'derefine_dx' by a factor of 0.5.

Cheers

Helmholtz photoionization default coefficients

In m_photoi_helmh.f90, the default value for the 'author' variable is 'Bourdon-3' (which means that the 3-term Bourdon coefficients would be used).
However, in the same file in lines 57-58, the comments say that Luque is the default.
Isnt this wrong?