mdvacca/rn-d3-art-charts

Examples of charts built using D3 and ART in react-native

rn-d3-art-charts's Issues

Possible wrong percentage of pie chart.

Hi! I'm using your code for creating a pie chart and it worked great.
While I was testing with my data, I found that there might be a problem of the percentages of each label and value, because you were using item.number plus % directly instead of using item.number/number of all items from data. I tried to fix it using the code below. Please let me know if my assumption is right. Thanks for your code. Great sample code.
/*
this.totalNumber = 0;
this.props.data.forEach((item)=>{
this.totalNumber += item.number;
})
_value(item) { return (item.number/this.totalNumber).toFixed(3)*100; }
*/

memory-leaks

hey there, really nice code. it taught me a lot , thank you. I find that when I use anim_shape with react-navigation, I get memory leaks, because the animation loop can be running when react-navigation unmounts the component, and then it calls setState on an unmounted component. just wondering if anyone had experienced this?